]> git.ipfire.org Git - thirdparty/git.git/commitdiff
t1400: assert output of update-ref
authorAndrei Rybak <rybak.a.v@gmail.com>
Sat, 18 Mar 2023 15:46:44 +0000 (16:46 +0100)
committerJunio C Hamano <gitster@pobox.com>
Mon, 20 Mar 2023 16:11:42 +0000 (09:11 -0700)
In t1400-update-ref.sh test 'transaction can create and delete' creates
files "expect" and "actual", but doesn't compare them.  Similarly, test
'transaction cannot restart ongoing transaction' redirects output of
"git update-ref" to file "actual", but doesn't check its contents with
any assertions.

Assert output of "git update-ref" in tests to improve test coverage in
t1400-update-ref.sh.

Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t1400-update-ref.sh

index cf58cf025cd2af621f6d58cdaf02d3be0480190c..4d66cd7f4a1fce8ebdaa42a37e7bd8f03853645e 100755 (executable)
@@ -1568,6 +1568,7 @@ test_expect_success 'transaction can create and delete' '
        EOF
        git update-ref --stdin <stdin >actual &&
        printf "%s: ok\n" start commit start commit >expect &&
+       test_cmp expect actual &&
        test_must_fail git show-ref --verify refs/heads/create-and-delete
 '
 
@@ -1595,6 +1596,8 @@ test_expect_success 'transaction cannot restart ongoing transaction' '
        commit
        EOF
        test_must_fail git update-ref --stdin <stdin >actual &&
+       printf "%s: ok\n" start >expect &&
+       test_cmp expect actual &&
        test_must_fail git show-ref --verify refs/heads/restart
 '