t5410: test receive-pack connectivity check

As part of git-recieve-pack(1), the connectivity of objects is checked.
Add a test validating that git-receive-pack(1) fails due to an incoming
packfile that would leave the repository with missing objects. Instead
of creating a new test file, "t5410" is generalized for receive-pack
testing.

Signed-off-by: Justin Tobler <jltobler@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/meson.build b/t/meson.build
index fcfc1c2c2ba80c6eaa49d48abd11694fcb45f4ff..d052fc3e23d2ec78199d987d21394148ff0f890b 100644 (file)
--- a/t/meson.build
+++ b/t/meson.build
@@ -629,7 +629,7 @@ integration_tests = [
   't5407-post-rewrite-hook.sh',
   't5408-send-pack-stdin.sh',
   't5409-colorize-remote-messages.sh',
-  't5410-receive-pack-alternates.sh',
+  't5410-receive-pack.sh',
   't5411-proc-receive-hook.sh',
   't5500-fetch-pack.sh',
   't5501-fetch-push-alternates.sh',

diff --git a/t/t5410-receive-pack-alternates.sh b/t/t5410-receive-pack.sh
similarity index 57%
rename from t/t5410-receive-pack-alternates.sh
rename to t/t5410-receive-pack.sh
index 4e82fd102e37277919dc817187db6ee9fabac884..9afea54a2678ba2866e874a81ad0ec9fa6473461 100755 (executable)
--- a/t/t5410-receive-pack-alternates.sh
+++ b/t/t5410-receive-pack.sh
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-test_description='git receive-pack with alternate ref filtering'
+test_description='git receive-pack'
 
 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
@@ -41,4 +41,25 @@ test_expect_success 'with core.alternateRefsPrefixes' '
        test_cmp expect actual.haves
 '
 
+test_expect_success 'receive-pack missing objects fails connectivity check' '
+       test_when_finished rm -rf repo remote.git setup.git &&
+
+       git init repo &&
+       git -C repo commit --allow-empty -m 1 &&
+       git clone --bare repo setup.git &&
+       git -C repo commit --allow-empty -m 2 &&
+
+       # Capture git-send-pack(1) output sent to git-receive-pack(1).
+       git -C repo send-pack ../setup.git --all \
+               --receive-pack="tee ${SQ}$(pwd)/out${SQ} | git-receive-pack" &&
+
+       # Replay captured git-send-pack(1) output on new empty repository.
+       git init --bare remote.git &&
+       git receive-pack remote.git <out >actual 2>err &&
+
+       test_grep "missing necessary objects" actual &&
+       test_grep "fatal: Failed to traverse parents" err &&
+       test_must_fail git -C remote.git cat-file -e $(git -C repo rev-parse HEAD)
+'
+
 test_done