]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ACPI: thermal: Use strscpy() instead of strcpy()
authorAbdul Rahim <abdul.rahim@myyahoo.com>
Fri, 13 Sep 2024 21:11:35 +0000 (02:41 +0530)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 5 Nov 2024 20:21:28 +0000 (21:21 +0100)
strcpy() is generally considered unsafe and use of strscpy() is
recommended [1].

Also using strscpy() instead of strcpy() makes the following checkpatch
warning go away:

WARNING: Prefer strscpy over strcpy

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy
Signed-off-by: Abdul Rahim <abdul.rahim@myyahoo.com>
Link: https://patch.msgid.link/20240913211156.103864-1-abdul.rahim@myyahoo.com
[ rjw: Changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/thermal.c

index 78db38c7076e459667584bfe5829bd851a1916c4..6671537cb4b7dc641df278640625520270470de9 100644 (file)
@@ -796,9 +796,9 @@ static int acpi_thermal_add(struct acpi_device *device)
                return -ENOMEM;
 
        tz->device = device;
-       strcpy(tz->name, device->pnp.bus_id);
-       strcpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME);
-       strcpy(acpi_device_class(device), ACPI_THERMAL_CLASS);
+       strscpy(tz->name, device->pnp.bus_id);
+       strscpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME);
+       strscpy(acpi_device_class(device), ACPI_THERMAL_CLASS);
        device->driver_data = tz;
 
        acpi_thermal_aml_dependency_fix(tz);