]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
target-sparc: fix register corruption in ldstub if there is no write permission
authorArtyom Tarasenko <atar4qemu@gmail.com>
Fri, 24 Jun 2016 12:34:30 +0000 (14:34 +0200)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Fri, 5 Aug 2016 20:10:07 +0000 (15:10 -0500)
Signed-off-by: Artyom Tarasenko <atar4qemu@gmail.com>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
(cherry picked from commit b64d2e57e704edbb56ae969de864292dd38379bf)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
target-sparc/translate.c

index 7998ff57bf09598f63b2a7870f782b0d67ff9ee3..502510c750602562dc9ee925915e3d1f1c13c849 100644 (file)
@@ -4668,12 +4668,15 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn)
                 case 0xd:       /* ldstub -- XXX: should be atomically */
                     {
                         TCGv r_const;
+                        TCGv tmp = tcg_temp_new();
 
                         gen_address_mask(dc, cpu_addr);
-                        tcg_gen_qemu_ld8u(cpu_val, cpu_addr, dc->mem_idx);
+                        tcg_gen_qemu_ld8u(tmp, cpu_addr, dc->mem_idx);
                         r_const = tcg_const_tl(0xff);
                         tcg_gen_qemu_st8(r_const, cpu_addr, dc->mem_idx);
+                        tcg_gen_mov_tl(cpu_val, tmp);
                         tcg_temp_free(r_const);
+                        tcg_temp_free(tmp);
                     }
                     break;
                 case 0x0f: