]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
iio: adc: aspeed: Use of_property_present()
authorRob Herring (Arm) <robh@kernel.org>
Wed, 31 Jul 2024 19:12:43 +0000 (13:12 -0600)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 3 Aug 2024 11:19:03 +0000 (12:19 +0100)
Use of_property_present() to test for property presence rather than
of_find_property(). This is part of a larger effort to remove callers
of of_find_property() and similar functions. of_find_property() leaks
the DT struct property and data pointers which is a problem for
dynamically allocated nodes which may be freed.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Acked-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Link: https://patch.msgid.link/20240731191312.1710417-5-robh@kernel.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/aspeed_adc.c

index 090416c0d6220befd3ee418f7a6afdc3330831b2..064cddaf639934cf79b87d6f4d4c3f9babad1e81 100644 (file)
@@ -555,8 +555,7 @@ static int aspeed_adc_probe(struct platform_device *pdev)
        if (ret)
                return ret;
 
-       if (of_find_property(data->dev->of_node, "aspeed,battery-sensing",
-                            NULL)) {
+       if (of_property_present(data->dev->of_node, "aspeed,battery-sensing")) {
                if (data->model_data->bat_sense_sup) {
                        data->battery_sensing = 1;
                        if (readl(data->base + ASPEED_REG_ENGINE_CONTROL) &