]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
BUG/MINOR: quic: Dropped packets not counted (with RX buffers full)
authorFrédéric Lécaille <flecaille@haproxy.com>
Wed, 29 Jun 2022 09:24:35 +0000 (11:24 +0200)
committerFrédéric Lécaille <flecaille@haproxy.com>
Thu, 30 Jun 2022 12:24:04 +0000 (14:24 +0200)
When the connection RX buffer is full, the received packets are dropped.
Some of them were not taken into an account by the ->dropped_pkt counter.
This very simple patch has no impact at all on the packet handling workflow.

Must be backported to 2.6.

src/xprt_quic.c

index e55507d630085ef13dbb46a22fdcb11ada6d9541..0be3e64bd049f86c40b42e7170a19a502794b2d9 100644 (file)
@@ -5575,7 +5575,7 @@ static void qc_lstnr_pkt_rcv(unsigned char *buf, const unsigned char *end,
                if (b_tail(&qc->rx.buf) + b_cspace < b_wrap(&qc->rx.buf)) {
                        TRACE_PROTO("Packet dropped",
                                    QUIC_EV_CONN_LPKT, qc, NULL, NULL, qv);
-                       goto err;
+                       goto drop;
                }
 
                /* Let us consume the remaining contiguous space. */