refspec: make sure stack refspec_item variables are zeroed

A couple of functions that used struct refspec_item did not zero out the
structure memory. This can result in unexpected behavior, especially if
additional parameters are ever added to refspec_item in the future. Use
memset to ensure that unset structure members are zero.

It may make sense to convert most of these uses of struct refspec_item
to use either struct initializers or refspec_item_init_or_die. However,
other similar code uses memset. Converting all of these uses has been
left as a future exercise.

Signed-off-by: Jacob Keller <jacob.keller@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/builtin/remote.c b/builtin/remote.c
index c8240e9fcd58b838086dc667414dc78fb3f2912a..542f56e3878b6694e7da6c6141b5e249c511a51e 100644 (file)
--- a/builtin/remote.c
+++ b/builtin/remote.c
@@ -478,6 +478,7 @@ static int get_head_names(const struct ref *remote_refs, struct ref_states *stat
        struct ref *fetch_map = NULL, **fetch_map_tail = &fetch_map;
        struct refspec_item refspec;
 
+       memset(&refspec, 0, sizeof(refspec));
        refspec.force = 0;
        refspec.pattern = 1;
        refspec.src = refspec.dst = "refs/heads/*";

diff --git a/transport.c b/transport.c
index 2d4fd851dc0f8f317e3925e84d2567ff7467fc7f..419be0b6ea4b01933766c1cd6dfa0a3e33e154c4 100644 (file)
--- a/transport.c
+++ b/transport.c
@@ -443,6 +443,7 @@ void transport_update_tracking_ref(struct remote *remote, struct ref *ref, int v
        if (ref->status != REF_STATUS_OK && ref->status != REF_STATUS_UPTODATE)
                return;
 
+       memset(&rs, 0, sizeof(rs));
        rs.src = ref->name;
        rs.dst = NULL;