]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Clear util dir from engines
authorNorbert Pocs <norbertp@openssl.org>
Thu, 20 Nov 2025 16:59:16 +0000 (17:59 +0100)
committerNeil Horman <nhorman@openssl.org>
Thu, 4 Dec 2025 12:32:18 +0000 (07:32 -0500)
Signed-off-by: Norbert Pocs <norbertp@openssl.org>
Reviewed-by: Paul Yang <paulyang.inf@gmail.com>
Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/29305)

test/evp_kdf_test.c
util/err-to-raise
util/fix-includes.sed
util/indent.pro
util/opensslwrap.sh
util/perl/OpenSSL/paramnames.pm
util/perl/TLSProxy/Proxy.pm
util/wrap.pl.in

index 7a07168bc6676f9f472e8dace2c9f71a512e60a8..6a2010b665c365e0c73dbfab47544994577e8f2c 100644 (file)
@@ -2199,9 +2199,7 @@ static int test_kdf_hmac_drbg_settables(void)
          * the digest is also set
          */
         if (OPENSSL_strcasecmp(settableparams[i].key,
-                               OSSL_KDF_PARAM_PROPERTIES) != 0
-                && OPENSSL_strcasecmp(settableparams[i].key,
-                               OSSL_ALG_PARAM_ENGINE) != 0) {
+                               OSSL_KDF_PARAM_PROPERTIES) != 0) {
             TEST_note("Testing set int into %s fails", settableparams[i].key);
             params[0] = OSSL_PARAM_construct_int(settableparams[i].key, &j);
             if (!TEST_int_le(EVP_KDF_CTX_set_params(kctx, params), 0))
index 174686d3ab16bcb557d5484658a4fd1a291fbb11..4eb9159536b2c4a7a07e370f8605254dd17edfaa 100755 (executable)
@@ -13,9 +13,6 @@
 # Consider running util/merge-err-lines first, to catch most (all?) of the
 # cases where the XXXerr() call is split into two lines.
 
-# Do not use this in engines/, they have their own error reporting functions,
-# which do call ERR_raise().
-
 use strict;
 use warnings;
 
index 5b9a834b86264eddc31dcb48d59213e5733713de..16c723bf73d11d8ef84b852d0c2d0e328458ef34 100644 (file)
@@ -1,5 +1,5 @@
 s|internal/([a-z0-9_]+)_int\.h|crypto/\1.h|g ;
-s@internal/(aria.h|asn1_dsa.h|async.h|bn_dh.h|bn_srp.h|chacha.h|(aes|des|cmll)_platform.h|ctype.h|__DECC_INCLUDE_EPILOGUE.H|__DECC_INCLUDE_PROLOGUE.H|dso_conf.h|dso_conf.h|engine.h|lhash.h|md32_common.h|objects.h|poly1305.h|sha.h|siphash.h|sm2err.h|sm2.h|sm4.h|sparse_array.h|store.h|foobar)@crypto/\1@g ;
+s@internal/(aria.h|asn1_dsa.h|async.h|bn_dh.h|bn_srp.h|chacha.h|(aes|des|cmll)_platform.h|ctype.h|__DECC_INCLUDE_EPILOGUE.H|__DECC_INCLUDE_PROLOGUE.H|dso_conf.h|dso_conf.h|lhash.h|md32_common.h|objects.h|poly1305.h|sha.h|siphash.h|sm2err.h|sm2.h|sm4.h|sparse_array.h|store.h|foobar)@crypto/\1@g ;
 s/constant_time_locl/constant_time/g ;
 s/_lo?cl\.h/_local.h/g ;
 s/_int\.h/_local.h/g ;
index 1937cfa476fe4152bf0b9761b1f2d0b67f00ea9e..6fabf305da9a13709f95c3d5066ad79f70f22555 100644 (file)
 -T EC_PRIVATEKEY
 -T EC_builtin_curve
 -T EDIPARTYNAME
--T ENGINE
--T ENGINE_CIPHERS_PTR
--T ENGINE_CLEANUP_CB
--T ENGINE_CLEANUP_ITEM
--T ENGINE_CMD_DEFN
--T ENGINE_CTRL_FUNC_PTR
--T ENGINE_DIGESTS_PTR
--T ENGINE_GEN_FUNC_PTR
--T ENGINE_GEN_INT_FUNC_PTR
--T ENGINE_LOAD_KEY_PTR
--T ENGINE_PILE
--T ENGINE_PILE_DOALL
--T ENGINE_PKEY_ASN1_METHS_PTR
--T ENGINE_PKEY_METHS_PTR
--T ENGINE_SSL_CLIENT_CERT_PTR
--T ENGINE_TABLE
 -T ENUMERATED_NAMES
 -T ERR_STATE
 -T ERR_STRING_DATA
 -T STACK_OF_CONF_VALUE_
 -T STACK_OF_CRYPTO_dynlock_
 -T STACK_OF_DIST_POINT_
--T STACK_OF_ENGINE_
--T STACK_OF_ENGINE_CLEANUP_ITEM_
 -T STACK_OF_ESS_CERT_ID_
 -T STACK_OF_ESS_CERT_ID_V2_
 -T STACK_OF_EVP_PBE_CTL_
 -T STACK_OF_void_
 -T LHASH_OF_ADDED_OBJ_
 -T LHASH_OF_CONF_VALUE_
--T LHASH_OF_ENGINE_PILE_
 -T LHASH_OF_ERR_STATE_
 -T LHASH_OF_ERR_STRING_DATA_
 -T LHASH_OF_FUNCTION_
index 7a388302703e6f47577f82428d6bc7eaa593b095..3a58bfd71b43cda8d5bd180ba57a13446aa05b05 100755 (executable)
@@ -3,9 +3,6 @@
 HERE="`echo $0 | sed -e 's|[^/]*$||'`"
 OPENSSL="${HERE}../apps/openssl"
 
-if [ -d "${HERE}../engines" -a "x$OPENSSL_ENGINES" = "x" ]; then
-       OPENSSL_ENGINES="${HERE}../engines"; export OPENSSL_ENGINES
-fi
 if [ -d "${HERE}../providers" -a "x$OPENSSL_MODULES" = "x" ]; then
        OPENSSL_MODULES="${HERE}../providers"; export OPENSSL_MODULES
 fi
index eed78467df3a1e532b2a88af744e1982f6f70df1..b73863b98557f0d88ee7951f4a063d6c44d07fb6 100644 (file)
@@ -84,14 +84,13 @@ my %params = (
     'OSSL_OBJECT_PARAM_INPUT_TYPE' =>        "input-type", # UTF8_STRING
 
 # Algorithm parameters
-# If "engine",or "properties",are specified, they should always be paired
+# If "properties" is specified, they should always be paired
 # with the algorithm type.
 # Note these are common names that are shared by many types (such as kdf, mac,
 # and pkey) e.g: see MAC_PARAM_DIGEST below.
 
     'OSSL_ALG_PARAM_DIGEST' =>       "digest",       # utf8_string
     'OSSL_ALG_PARAM_CIPHER' =>       "cipher",       # utf8_string
-    'OSSL_ALG_PARAM_ENGINE' =>       "engine",       # utf8_string
     'OSSL_ALG_PARAM_MAC' =>          "mac",          # utf8_string
     'OSSL_ALG_PARAM_PROPERTIES' =>   "properties",   # utf8_string
     'OSSL_ALG_PARAM_FIPS_APPROVED_INDICATOR' => 'fips-indicator',   # int, -1, 0 or 1
@@ -185,7 +184,7 @@ my %params = (
     'OSSL_MAC_PARAM_C_ROUNDS' =>       "c-rounds",      # unsigned int
     'OSSL_MAC_PARAM_D_ROUNDS' =>       "d-rounds",      # unsigned int
 
-# If "engine",or "properties",are specified, they should always be paired
+# If "properties" is specified, they should always be paired
 # with "cipher",or "digest".
 
     'OSSL_MAC_PARAM_CIPHER' =>           '*OSSL_ALG_PARAM_CIPHER',        # utf8 string
@@ -295,7 +294,6 @@ my %params = (
     'OSSL_PKEY_PARAM_SECURITY_CATEGORY' =>   '*OSSL_ALG_PARAM_SECURITY_CATEGORY',
     'OSSL_PKEY_PARAM_DIGEST' =>              '*OSSL_ALG_PARAM_DIGEST',
     'OSSL_PKEY_PARAM_CIPHER' =>              '*OSSL_ALG_PARAM_CIPHER', # utf8 string
-    'OSSL_PKEY_PARAM_ENGINE' =>              '*OSSL_ALG_PARAM_ENGINE', # utf8 string
     'OSSL_PKEY_PARAM_PROPERTIES' =>          '*OSSL_ALG_PARAM_PROPERTIES',
     'OSSL_PKEY_PARAM_DEFAULT_DIGEST' =>      "default-digest",# utf8 string
     'OSSL_PKEY_PARAM_MANDATORY_DIGEST' =>    "mandatory-digest",# utf8 string
@@ -503,7 +501,6 @@ my %params = (
 # Asym cipher parameters
     'OSSL_ASYM_CIPHER_PARAM_DIGEST' =>                   '*OSSL_PKEY_PARAM_DIGEST',
     'OSSL_ASYM_CIPHER_PARAM_PROPERTIES' =>               '*OSSL_PKEY_PARAM_PROPERTIES',
-    'OSSL_ASYM_CIPHER_PARAM_ENGINE' =>                   '*OSSL_PKEY_PARAM_ENGINE',
     'OSSL_ASYM_CIPHER_PARAM_PAD_MODE' =>                 '*OSSL_PKEY_PARAM_PAD_MODE',
     'OSSL_ASYM_CIPHER_PARAM_MGF1_DIGEST' =>              '*OSSL_PKEY_PARAM_MGF1_DIGEST',
     'OSSL_ASYM_CIPHER_PARAM_MGF1_DIGEST_PROPS' =>        '*OSSL_PKEY_PARAM_MGF1_PROPERTIES',
index 91793481e02354a4276cb59c58e1e1873bd2c30c..aa6c9ff9a8f875e3482d76aa39442af7ae7f2f7a 100644 (file)
@@ -330,7 +330,7 @@ sub start
     my $execcmd = $self->execute
         ." s_server -no_comp -provider=p_ossltest -provider=default -propquery ?provider=p_ossltest -state"
         #In TLSv1.3 we issue two session tickets. The default session id
-        #callback gets confused because the ossltest engine causes the same
+        #callback gets confused because the ossltest provider causes the same
         #session id to be created twice due to the changed random number
         #generation. Using "-ext_cache" replaces the default callback with a
         #different one that doesn't get confused.
index 2c9cb29fec04d867f61aeef96d3bc908ec1f9340..221da07b949a0c1143e758d3709fcb200d82c774 100644 (file)
@@ -51,7 +51,6 @@ sub quote_arg_win32 {
 }
 
 my $there = canonpath(catdir(dirname($0), updir()));
-my $std_engines = catdir($there, 'engines');
 my $std_providers = catdir($there, 'providers');
 my $std_openssl_conf = catdir($there, 'apps/openssl.cnf');
 my $unix_shlib_wrap = catfile($there, 'util/shlib_wrap.sh');
@@ -84,8 +83,6 @@ local $ENV{OPENSSL_CONF_INCLUDE} = $std_openssl_conf_include
     if defined $std_openssl_conf_include
        &&($ENV{OPENSSL_CONF_INCLUDE} // '') eq ''
        && -d $std_openssl_conf_include;
-local $ENV{OPENSSL_ENGINES} = $std_engines
-    if ($ENV{OPENSSL_ENGINES} // '') eq '' && -d $std_engines;
 local $ENV{OPENSSL_MODULES} = $std_providers
     if ($ENV{OPENSSL_MODULES} // '') eq '' && -d $std_providers;
 local $ENV{OPENSSL_CONF} = $std_openssl_conf