]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: ethernet: hisilicon: Switch to use hrtimer_setup()
authorNam Cao <namcao@linutronix.de>
Wed, 5 Feb 2025 10:43:31 +0000 (11:43 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 18 Feb 2025 09:35:45 +0000 (10:35 +0100)
hrtimer_setup() takes the callback function pointer as argument and
initializes the timer completely.

Replace hrtimer_init() and the open coded initialization of
hrtimer::function with the new setup mechanism.

Patch was created by using Coccinelle.

Signed-off-by: Nam Cao <namcao@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/11f5140e157cc0cd02a715f531217b021743aa71.1738746872.git.namcao@linutronix.de
drivers/net/ethernet/hisilicon/hip04_eth.c

index a376d4bdf2819be1eb0ea5f7077a813fb5c9ab29..18376bcc718a2075de84b661bc7fd3015dbfa1ff 100644 (file)
@@ -934,8 +934,6 @@ static int hip04_mac_probe(struct platform_device *pdev)
        priv->chan = arg.args[1] * RX_DESC_NUM;
        priv->group = arg.args[2];
 
-       hrtimer_init(&priv->tx_coalesce_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
-
        /* BQL will try to keep the TX queue as short as possible, but it can't
         * be faster than tx_coalesce_usecs, so we need a fast timeout here,
         * but also long enough to gather up enough frames to ensure we don't
@@ -944,7 +942,7 @@ static int hip04_mac_probe(struct platform_device *pdev)
         */
        priv->tx_coalesce_frames = TX_DESC_NUM * 3 / 4;
        priv->tx_coalesce_usecs = 200;
-       priv->tx_coalesce_timer.function = tx_done;
+       hrtimer_setup(&priv->tx_coalesce_timer, tx_done, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
 
        priv->map = syscon_node_to_regmap(arg.np);
        of_node_put(arg.np);