]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: fix use after free
authorEric Blake <eblake@redhat.com>
Tue, 31 Jul 2012 14:05:14 +0000 (08:05 -0600)
committerCole Robinson <crobinso@redhat.com>
Mon, 13 Aug 2012 01:15:46 +0000 (21:15 -0400)
Detected by Coverity.

* src/qemu/qemu_hotplug.c (qemuDomainAttachHostDevice): Avoid
double free of usb on failure.
(cherry picked from commit 665c8cdecc2d91a83f08a6ec95531b0de57c0e0a)

src/qemu/qemu_hotplug.c

index 62de67c9f9f6b91b246c369ea161677e3b8285a2..fcc7c0ff7db146ddcda4f87cc3ca46c773685fc4 100644 (file)
@@ -1170,6 +1170,7 @@ int qemuDomainAttachHostDevice(struct qemud_driver *driver,
 
         if (usbDeviceListAdd(list, usb) < 0) {
             usbFreeDevice(usb);
+            usb = NULL:
             goto cleanup;
         }