wifi: mt76: mt7925: fix a potential array-index-out-of-bounds issue for clc

Due to the lack of checks on the clc array, if the firmware supports
more clc configuration, it will cause illegal memory access.

Cc: stable@vger.kernel.org
Fixes: c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver for mt7925 chips")
Signed-off-by: Ming Yen Hsieh <mingyen.hsieh@mediatek.com>
Link: https://patch.msgid.link/20240819015334.14580-1-mingyen.hsieh@mediatek.com
Signed-off-by: Felix Fietkau <nbd@nbd.name>

diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
index e07b43dd8638ecdec4f14658a0d1e95a70cd5757..748ea6adbc6b3910ccde5b623b410ca7f1548518 100644 (file)
--- a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.c
@@ -638,6 +638,9 @@ static int mt7925_load_clc(struct mt792x_dev *dev, const char *fw_name)
        for (offset = 0; offset < len; offset += le32_to_cpu(clc->len)) {
                clc = (const struct mt7925_clc *)(clc_base + offset);
 
+               if (clc->idx > ARRAY_SIZE(phy->clc))
+                       break;
+
                /* do not init buf again if chip reset triggered */
                if (phy->clc[clc->idx])
                        continue;