]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
scsi: s390: zfcp: Ensure synchronous unit_add
authorPeter Oberparleiter <oberpar@linux.ibm.com>
Tue, 3 Jun 2025 18:21:56 +0000 (20:21 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 9 Jun 2025 19:18:49 +0000 (15:18 -0400)
Improve the usability of the unit_add sysfs attribute by ensuring that
the associated FCP LUN scan processing is completed synchronously.  This
enables configuration tooling to consistently determine the end of the
scan process to allow for serialization of follow-on actions.

While the scan process associated with unit_add typically completes
synchronously, it is deferred to an asynchronous background process if
unit_add is used before initial remote port scanning has completed.  This
occurs when unit_add is used immediately after setting the associated FCP
device online.

To ensure synchronous unit_add processing, wait for remote port scanning
to complete before initiating the FCP LUN scan.

Cc: stable@vger.kernel.org
Reviewed-by: M Nikhil <nikh1092@linux.ibm.com>
Reviewed-by: Nihar Panda <niharp@linux.ibm.com>
Signed-off-by: Peter Oberparleiter <oberpar@linux.ibm.com>
Signed-off-by: Nihar Panda <niharp@linux.ibm.com>
Link: https://lore.kernel.org/r/20250603182252.2287285-2-niharp@linux.ibm.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/s390/scsi/zfcp_sysfs.c

index 41e36af35488eb948a7d40d8e58d3674408a784a..90a84ae98b971c6daa6decc1a4826816918c1ff3 100644 (file)
@@ -449,6 +449,8 @@ static ssize_t zfcp_sysfs_unit_add_store(struct device *dev,
        if (kstrtoull(buf, 0, (unsigned long long *) &fcp_lun))
                return -EINVAL;
 
+       flush_work(&port->rport_work);
+
        retval = zfcp_unit_add(port, fcp_lun);
        if (retval)
                return retval;