]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
Revert "cpufreq: brcmstb-avs-cpufreq: Fix initial command check"
authorColin Ian King <colin.i.king@gmail.com>
Tue, 29 Oct 2024 15:22:27 +0000 (15:22 +0000)
committerViresh Kumar <viresh.kumar@linaro.org>
Wed, 30 Oct 2024 03:16:13 +0000 (08:46 +0530)
Currently the condition ((rc != -ENOTSUPP) || (rc != -EINVAL)) is always
true because rc cannot be equal to two different values at the same time,
so it must be not equal to at least one of them. Fix the original commit
that introduced the issue.

This reverts commit 22a26cc6a51ef73dcfeb64c50513903f6b2d53d8.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Acked-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/cpufreq/brcmstb-avs-cpufreq.c

index ea8438550b490160d219c791d35343776eabea0b..7849c1f9f0627247f05024b845d302c2c7e7fee3 100644 (file)
@@ -474,8 +474,8 @@ static bool brcm_avs_is_firmware_loaded(struct private_data *priv)
        rc = brcm_avs_get_pmap(priv, NULL);
        magic = readl(priv->base + AVS_MBOX_MAGIC);
 
-       return (magic == AVS_FIRMWARE_MAGIC) && ((rc != -ENOTSUPP) ||
-               (rc != -EINVAL));
+       return (magic == AVS_FIRMWARE_MAGIC) && (rc != -ENOTSUPP) &&
+               (rc != -EINVAL);
 }
 
 static unsigned int brcm_avs_cpufreq_get(unsigned int cpu)