Ensure bfd_close after bfd_openw so we don't get multiple bfd_openw

calls for same file.

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index b8918de1a593b1127a7c730ab47aaee2fc5676c9..067e512fc7064fb58dac71ea2868bbd0ba548132 100644 (file)
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,8 @@
+2000-05-24  Alan Modra  <alan@linuxcare.com.au>
+
+       * objdump.c (display_target_list): Close the bfd.
+       (display_info_table): Likewise.
+
 2000-05-23  Philip Blundell  <pb@futuretv.com>
 
        * configure.in: Set version to 2.10.

diff --git a/binutils/objdump.c b/binutils/objdump.c
index 9ad722bb44a7f58e1fa7661e8ae8b34ec098df60..97975054a4bde82edef96fedb63e841873d2d86b 100644 (file)
--- a/binutils/objdump.c
+++ b/binutils/objdump.c
@@ -2651,6 +2651,7 @@ display_target_list ()
        {
          if (bfd_get_error () != bfd_error_invalid_operation)
            nonfatal (p->name);
+         bfd_close (abfd);
          continue;
        }
 
@@ -2658,6 +2659,7 @@ display_target_list ()
        if (bfd_set_arch_mach (abfd, (enum bfd_architecture) a, 0))
          printf ("  %s\n",
                  bfd_printable_arch_mach ((enum bfd_architecture) a, 0));
+      bfd_close (abfd);
     }
   unlink (dummy_name);
   free (dummy_name);
@@ -2725,6 +2727,8 @@ display_info_table (first, last)
                  putchar ('-');
                putchar (' ');
              }
+           if (abfd != NULL)
+             bfd_close (abfd);
          }
        putchar ('\n');
       }