]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
tty: sysrq: delete unnecessary check
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 6 Aug 2025 11:46:12 +0000 (14:46 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Aug 2025 15:42:26 +0000 (17:42 +0200)
This code checks if (write) is true twice in a row.  It's more
readable to delete the first check.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/aJNAhHtKkhWjosDV@stanley.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/sysrq.c

index 97f8a9a5228567641db1ec3b21466744231dd1ad..1f78b0db3b259c3f5280f2dd36c5c268db20a971 100644 (file)
@@ -1133,8 +1133,7 @@ static int sysrq_sysctl_handler(const struct ctl_table *table, int write,
         * Behaves like do_proc_dointvec as t does not have min nor max.
         */
        ret = proc_dointvec_minmax(&t, write, buffer, lenp, ppos);
-
-       if (ret || !write)
+       if (ret)
                return ret;
 
        if (write)