builtin/credential: clear credential before exit

We never release memory associated with `struct credential`. Fix this
and mark the corresponding test as leak free.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/builtin/credential.c b/builtin/credential.c
index 5100d441f24256019b6a9fffa639ffaa643921b5..b72e76dd9a610f866b45f635f45bbf5b1ac45744 100644 (file)
--- a/builtin/credential.c
+++ b/builtin/credential.c
@@ -39,5 +39,7 @@ int cmd_credential(int argc, const char **argv, const char *prefix UNUSED)
        } else {
                usage(usage_msg);
        }
+
+       credential_clear(&c);
        return 0;
 }

diff --git a/t/t0300-credentials.sh b/t/t0300-credentials.sh
index 432f029d4882dff2ce44fcbed9e99145254cbcdf..6a76b7fdbd4557b2df8e34f9683323cf8073ea38 100755 (executable)
--- a/t/t0300-credentials.sh
+++ b/t/t0300-credentials.sh
@@ -1,6 +1,8 @@
 #!/bin/sh
 
 test_description='basic credential helper tests'
+
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 . "$TEST_DIRECTORY"/lib-credential.sh