]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
Correct calculation of Yubikey-Counter
authorNick Porter <nick@portercomputing.co.uk>
Tue, 9 Jan 2024 10:55:04 +0000 (10:55 +0000)
committerNick Porter <nick@portercomputing.co.uk>
Tue, 9 Jan 2024 10:55:04 +0000 (10:55 +0000)
token.use is only 8 bit

src/modules/rlm_yubikey/decrypt.c

index 20b6df8e2ef945ba79014706635df0a44914c49d..2bf454354aefd7b7e0357e197e7b33db2c766607 100644 (file)
@@ -106,7 +106,7 @@ rlm_rcode_t rlm_yubikey_decrypt(rlm_yubikey_t *inst, REQUEST *request, char cons
         *      Combine the two counter fields together so we can do
         *      replay attack checks.
         */
-       counter = (yubikey_counter(token.ctr) << 16) | token.use;
+       counter = (yubikey_counter(token.ctr) << 8) | token.use;
 
        vp = fr_pair_make(request->packet, &request->packet->vps, "Yubikey-Counter", NULL, T_OP_SET);
        if (!vp) {