Fix cosmetic blemishes involving rd_createSubid.

Remove an obsolete comment from AtEOXact_cleanup().  Restore formatting
of a comment in struct RelationData, mangled by the pgindent run in
commit 9af4159fce6654aa0e081b00d02bca40b978745c.  Back-patch to 9.5 (all
supported versions), because another fix stacks on this.

diff --git a/src/backend/utils/cache/relcache.c b/src/backend/utils/cache/relcache.c
index 6859728bc62a94b8f4cb92d18ae757e4c18fdc3c..6ec89fadd6cb6ab0bdf28e3a10ad792b45792684 100644 (file)
--- a/src/backend/utils/cache/relcache.c
+++ b/src/backend/utils/cache/relcache.c
@@ -2717,10 +2717,7 @@ AtEOXact_cleanup(Relation relation, bool isCommit)
         *
         * During commit, reset the flag to zero, since we are now out of the
         * creating transaction.  During abort, simply delete the relcache entry
-        * --- it isn't interesting any longer.  (NOTE: if we have forgotten the
-        * new-ness of a new relation due to a forced cache flush, the entry will
-        * get deleted anyway by shared-cache-inval processing of the aborted
-        * pg_class insertion.)
+        * --- it isn't interesting any longer.
         */
        if (relation->rd_createSubid != InvalidSubTransactionId)
        {

diff --git a/src/include/utils/rel.h b/src/include/utils/rel.h
index ebc00b0d4d4ebe3cf47b789f043435f1ee820168..ca6c0a5adfa60ac54e76819e8f2b9e06f373bed4 100644 (file)
--- a/src/include/utils/rel.h
+++ b/src/include/utils/rel.h
@@ -80,7 +80,7 @@ typedef struct RelationData
        char            rd_indexvalid;  /* state of rd_indexlist: 0 = not valid, 1 =
                                                                 * valid, 2 = temporarily forced */
 
-       /*
+       /*----------
         * rd_createSubid is the ID of the highest subtransaction the rel has
         * survived into; or zero if the rel was not created in the current top
         * transaction.  This can be now be relied on, whereas previously it could
@@ -90,8 +90,13 @@ typedef struct RelationData
         * have forgotten changing it). rd_newRelfilenodeSubid can be forgotten
         * when a relation has multiple new relfilenodes within a single
         * transaction, with one of them occurring in a subsequently aborted
-        * subtransaction, e.g. BEGIN; TRUNCATE t; SAVEPOINT save; TRUNCATE t;
-        * ROLLBACK TO save; -- rd_newRelfilenode is now forgotten
+        * subtransaction, e.g.
+        *              BEGIN;
+        *              TRUNCATE t;
+        *              SAVEPOINT save;
+        *              TRUNCATE t;
+        *              ROLLBACK TO save;
+        *              -- rd_newRelfilenodeSubid is now forgotten
         */
        SubTransactionId rd_createSubid;        /* rel was created in current xact */
        SubTransactionId rd_newRelfilenodeSubid;        /* new relfilenode assigned in