]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
tools/mm/page-types: fix typo in madvise() error message
authorYe Liu <liuye@kylinos.cn>
Wed, 13 May 2026 02:21:16 +0000 (10:21 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 2 Jun 2026 22:22:17 +0000 (15:22 -0700)
Patch series "tools/mm/page-types: Fix misc bugs".

This series fixes three issues in tools/mm/page-types.c:

1. Fix two typos in madvise() error messages ("madvice" -> "madvise")
2. Fix operator precedence bug in the sigbus handler where the ternary
   operator binds looser than addition, producing incorrect offset
   calculation when sigbus_addr is non-NULL
3. Fix --kpageflags option declaration in getopt_long: has_arg should
   be 1 (required_argument) since the option requires a file path

This patch (of 3):

Two error messages incorrectly spelled the madvise() function name as
"madvice".  Fix the typo in both occurrences.

Link: https://lore.kernel.org/20260513022120.58033-1-ye.liu@linux.dev
Link: https://lore.kernel.org/20260513022120.58033-2-ye.liu@linux.dev
Signed-off-by: Ye Liu <liuye@kylinos.cn>
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
Reviewed-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
tools/mm/page-types.c

index d7e5e8902af86e37720887eaac0b02f7a14123ee..6594245217a8d05381d0cc2b6ddbd82f4ed3f42b 100644 (file)
@@ -997,7 +997,7 @@ static void walk_file_range(const char *name, int fd,
 
                /* turn off readahead */
                if (madvise(ptr, len, MADV_RANDOM))
-                       fatal("madvice failed: %s", name);
+                       fatal("madvise failed: %s", name);
 
                if (sigsetjmp(sigbus_jmp, 1)) {
                        end = off + sigbus_addr ? sigbus_addr - ptr : 0;
@@ -1015,7 +1015,7 @@ got_sigbus:
 
                /* turn off harvesting reference bits */
                if (madvise(ptr, len, MADV_SEQUENTIAL))
-                       fatal("madvice failed: %s", name);
+                       fatal("madvise failed: %s", name);
 
                if (pagemap_read(buf, (unsigned long)ptr / page_size,
                                        nr_pages) != nr_pages)