]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
thermal: testing: Simplify tt_get_tt_zone()
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Sun, 10 Nov 2024 13:04:47 +0000 (14:04 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 12 Nov 2024 20:47:18 +0000 (21:47 +0100)
Notice that tt_get_tt_zone() need not use the ret variable in
the tt_thermal_zones list walk and make it return right after
incrementing the reference counter of the matching entry.

No functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/6120304.lOV4Wx5bFT@rjwysocki.net
drivers/thermal/testing/zone.c

index c6d8c66f40f9808d171d00eddf20b6ace2cfbfaf..fb83d2501284d665b3bf4a97f43aed9a324ed071 100644 (file)
@@ -288,19 +288,14 @@ static struct tt_thermal_zone *tt_get_tt_zone(const char *arg)
 
        guard(mutex)(&tt_thermal_zones_lock);
 
-       ret = -EINVAL;
        list_for_each_entry(tt_zone, &tt_thermal_zones, list_node) {
                if (tt_zone->id == id) {
                        tt_zone->refcount++;
-                       ret = 0;
-                       break;
+                       return tt_zone;
                }
        }
 
-       if (ret)
-               return ERR_PTR(ret);
-
-       return tt_zone;
+       return ERR_PTR(-EINVAL);
 }
 
 static void tt_put_tt_zone(struct tt_thermal_zone *tt_zone)