]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: ath12k: fix driver initialization for WoW unsupported devices
authorRameshkumar Sundaram <quic_ramess@quicinc.com>
Wed, 26 Jun 2024 02:42:57 +0000 (08:12 +0530)
committerKalle Valo <quic_kvalo@quicinc.com>
Thu, 27 Jun 2024 16:21:47 +0000 (19:21 +0300)
Commit 4a3c212eee0e ("wifi: ath12k: add basic WoW functionalities") broke
driver initialization, now mac registration is allowed only for devices that
advertise WMI_TLV_SERVICE_WOW, but QCN9274 doesn't support WoW and hence mac
registration is aborted and driver is de-initialized.

Allow mac registration to proceed without WoW Support for devices
that don't advertise WMI_TLV_SERVICE_WOW.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1

Fixes: 4a3c212eee0e ("wifi: ath12k: add basic WoW functionalities")
Signed-off-by: Rameshkumar Sundaram <quic_ramess@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://patch.msgid.link/20240626024257.709460-1-quic_ramess@quicinc.com
drivers/net/wireless/ath/ath12k/wow.c

index 685e8e98d8455fd50ee1f5e1a33b03dfef85119c..c5cba825a84aac457704426b90ebba020420bcc8 100644 (file)
@@ -1001,8 +1001,8 @@ exit:
 
 int ath12k_wow_init(struct ath12k *ar)
 {
-       if (WARN_ON(!test_bit(WMI_TLV_SERVICE_WOW, ar->wmi->wmi_ab->svc_map)))
-               return -EINVAL;
+       if (!test_bit(WMI_TLV_SERVICE_WOW, ar->wmi->wmi_ab->svc_map))
+               return 0;
 
        ar->wow.wowlan_support = ath12k_wowlan_support;