]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
arm64: dts: qcom: msm8916-samsung-a2015: fix polarity of "enable" line of NFC chip
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 29 Sep 2022 01:15:56 +0000 (18:15 -0700)
committerBjorn Andersson <andersson@kernel.org>
Tue, 18 Oct 2022 03:01:46 +0000 (22:01 -0500)
According to s3fwrn5 driver code the "enable" GPIO line is driven "high"
when chip is not in use (mode is S3FWRN5_MODE_COLD), and is driven "low"
when chip is in use.

s3fwrn5_phy_power_ctrl():

...
gpio_set_value(phy->gpio_en, 1);
...
if (mode != S3FWRN5_MODE_COLD) {
msleep(S3FWRN5_EN_WAIT_TIME);
gpio_set_value(phy->gpio_en, 0);
msleep(S3FWRN5_EN_WAIT_TIME);
}

Therefore the line described by "en-gpios" property should be annotated
as "active low".

The wakeup gpio appears to have correct polarity (active high).

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20220929011557.4165216-2-dmitry.torokhov@gmail.com
arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi

index 3255bd3fcb55a0afef160b2bc7be78125dca45f5..5f7cec347a4fe70d62f9e9c679a5b52fff3d3b87 100644 (file)
                        interrupt-parent = <&msmgpio>;
                        interrupts = <21 IRQ_TYPE_EDGE_RISING>;
 
-                       en-gpios = <&msmgpio 20 GPIO_ACTIVE_HIGH>;
+                       en-gpios = <&msmgpio 20 GPIO_ACTIVE_LOW>;
                        wake-gpios = <&msmgpio 49 GPIO_ACTIVE_HIGH>;
 
                        clocks = <&rpmcc RPM_SMD_BB_CLK2_PIN>;