]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: stmmac: intel: remove unnecessary setting max_speed
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Tue, 15 Apr 2025 10:13:55 +0000 (11:13 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 17 Apr 2025 01:25:03 +0000 (18:25 -0700)
Phylink will already limit the MAC speed according to the interface,
so if 2500BASE-X is selected, the maximum speed will be 2.5G.
Similarly, if SGMII is selected, the maximum speed will be 1G.
It is, therefore, not necessary to set a speed limit. Remove setting
plat_dat->max_speed from this glue driver.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/E1u4dIh-000dT5-Kt@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c

index 54db5b778304da61e5a44368f380e80f5d0632c8..96c893dd262f8f5917afbb3be85ce724424c0a3d 100644 (file)
@@ -300,11 +300,8 @@ static void intel_speed_mode_2500(struct net_device *ndev, void *intel_data)
        if (((data & SERDES_LINK_MODE_MASK) >> SERDES_LINK_MODE_SHIFT) ==
            SERDES_LINK_MODE_2G5) {
                dev_info(priv->device, "Link Speed Mode: 2.5Gbps\n");
-               priv->plat->max_speed = 2500;
                priv->plat->phy_interface = PHY_INTERFACE_MODE_2500BASEX;
                priv->plat->mdio_bus_data->default_an_inband = false;
-       } else {
-               priv->plat->max_speed = 1000;
        }
 }