Prefer htab_traverse_noresize

A few spots in gdb were using htab_traverse.  IMO this is almost never
useful and htab_traverse_noresize should be preferred.

diff --git a/gdb/completer.c b/gdb/completer.c
index f1f44109bdce7f5ee000516e35550abdda48180a..bd5118f53c5797086974d7617bc3bb5817dd31e3 100644 (file)
--- a/gdb/completer.c
+++ b/gdb/completer.c
@@ -2058,7 +2058,7 @@ completion_tracker::recompute_lowest_common_denominator ()
        return 1;
       };
 
-  htab_traverse (m_entries_hash.get (), visitor_func, this);
+  htab_traverse_noresize (m_entries_hash.get (), visitor_func, this);
   m_lowest_common_denominator_valid = true;
 }
 

diff --git a/gdb/dwarf2/cu.c b/gdb/dwarf2/cu.c
index aae61cccd212ccfddeed8fb8e212ed2f028017f4..5cb22919c321e85734b4544ec9e57afc47af177d 100644 (file)
--- a/gdb/dwarf2/cu.c
+++ b/gdb/dwarf2/cu.c
@@ -146,7 +146,8 @@ dwarf2_cu::mark ()
     {
       m_mark = true;
       if (m_dependencies != nullptr)
-       htab_traverse (m_dependencies.get (), dwarf2_mark_helper, per_objfile);
+       htab_traverse_noresize (m_dependencies.get (), dwarf2_mark_helper,
+                               per_objfile);
     }
 }
 

diff --git a/gdb/gdb_bfd.c b/gdb/gdb_bfd.c
index cb9a91d09232beab2e7fda37cffd560fc6e2e082..7e272c719c3fcb7eda6b3052c0004d7451d68d33 100644 (file)
--- a/gdb/gdb_bfd.c
+++ b/gdb/gdb_bfd.c
@@ -1200,7 +1200,7 @@ maintenance_info_bfds (const char *arg, int from_tty)
   uiout->table_header (40, ui_left, "filename", "Filename");
 
   uiout->table_body ();
-  htab_traverse (all_bfds, print_one_bfd, uiout);
+  htab_traverse_noresize (all_bfds, print_one_bfd, uiout);
 }
 
 /* BFD related per-inferior data.  */