]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net/mlx5: Fix variable type to match 64bit
authorEran Ben Elisha <eranbe@nvidia.com>
Tue, 10 Aug 2021 18:15:05 +0000 (21:15 +0300)
committerSaeed Mahameed <saeedm@nvidia.com>
Wed, 11 Aug 2021 18:14:33 +0000 (11:14 -0700)
Fix the following smatch warning:
wait_func_handle_exec_timeout() warn: should '1 << ent->idx' be a 64 bit type?

Use 1ULL, to have a 64 bit type variable.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Eran Ben Elisha <eranbe@nvidia.com>
Reviewed-by: Moshe Shemesh <moshe@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/cmd.c

index 9d79c5ec31e9f24b0ddcc512c5367113bddc0bb6..db5dfff585c9907e2961c056558a462f08eb096d 100644 (file)
@@ -877,7 +877,7 @@ static void cb_timeout_handler(struct work_struct *work)
        ent->ret = -ETIMEDOUT;
        mlx5_core_warn(dev, "cmd[%d]: %s(0x%x) Async, timeout. Will cause a leak of a command resource\n",
                       ent->idx, mlx5_command_str(msg_to_opcode(ent->in)), msg_to_opcode(ent->in));
-       mlx5_cmd_comp_handler(dev, 1UL << ent->idx, true);
+       mlx5_cmd_comp_handler(dev, 1ULL << ent->idx, true);
 
 out:
        cmd_ent_put(ent); /* for the cmd_ent_get() took on schedule delayed work */
@@ -994,7 +994,7 @@ static void cmd_work_handler(struct work_struct *work)
                MLX5_SET(mbox_out, ent->out, status, status);
                MLX5_SET(mbox_out, ent->out, syndrome, drv_synd);
 
-               mlx5_cmd_comp_handler(dev, 1UL << ent->idx, true);
+               mlx5_cmd_comp_handler(dev, 1ULL << ent->idx, true);
                return;
        }
 
@@ -1008,7 +1008,7 @@ static void cmd_work_handler(struct work_struct *work)
                poll_timeout(ent);
                /* make sure we read the descriptor after ownership is SW */
                rmb();
-               mlx5_cmd_comp_handler(dev, 1UL << ent->idx, (ent->ret == -ETIMEDOUT));
+               mlx5_cmd_comp_handler(dev, 1ULL << ent->idx, (ent->ret == -ETIMEDOUT));
        }
 }
 
@@ -1068,7 +1068,7 @@ static void wait_func_handle_exec_timeout(struct mlx5_core_dev *dev,
                       mlx5_command_str(msg_to_opcode(ent->in)), msg_to_opcode(ent->in));
 
        ent->ret = -ETIMEDOUT;
-       mlx5_cmd_comp_handler(dev, 1UL << ent->idx, true);
+       mlx5_cmd_comp_handler(dev, 1ULL << ent->idx, true);
 }
 
 static int wait_func(struct mlx5_core_dev *dev, struct mlx5_cmd_work_ent *ent)