]> git.ipfire.org Git - thirdparty/git.git/commitdiff
bisect--helper: retire `--check-and-set-terms` subcommand
authorPranit Bauva <pranit.bauva@gmail.com>
Wed, 3 Feb 2021 21:54:38 +0000 (22:54 +0100)
committerJunio C Hamano <gitster@pobox.com>
Wed, 3 Feb 2021 22:52:09 +0000 (14:52 -0800)
The `--check-and-set-terms` subcommand is no longer from the
git-bisect.sh shell script. Instead the function
`check_and_set_terms()` is called from the C implementation.

Mentored-by: Lars Schneider <larsxschneider@gmail.com>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Mentored-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
Signed-off-by: Tanushree Tumane <tanushreetumane@gmail.com>
Signed-off-by: Miriam Rubio <mirucam@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/bisect--helper.c

index 7ad9b4d55b4d10a90e0c765e63394dbac4688b6e..d69e13335d9c79bb2f8bd1b59bca42106e32b378 100644 (file)
@@ -21,7 +21,6 @@ static GIT_PATH_FUNC(git_path_bisect_first_parent, "BISECT_FIRST_PARENT")
 
 static const char * const git_bisect_helper_usage[] = {
        N_("git bisect--helper --bisect-reset [<commit>]"),
-       N_("git bisect--helper --bisect-check-and-set-terms <command> <good_term> <bad_term>"),
        N_("git bisect--helper --bisect-next-check <good_term> <bad_term> [<term>]"),
        N_("git bisect--helper --bisect-terms [--term-good | --term-old | --term-bad | --term-new]"),
        N_("git bisect--helper --bisect-start [--term-{new,bad}=<term> --term-{old,good}=<term>]"
@@ -1032,7 +1031,6 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
 {
        enum {
                BISECT_RESET = 1,
-               CHECK_AND_SET_TERMS,
                BISECT_NEXT_CHECK,
                BISECT_TERMS,
                BISECT_START,
@@ -1047,8 +1045,6 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
        struct option options[] = {
                OPT_CMDMODE(0, "bisect-reset", &cmdmode,
                         N_("reset the bisection state"), BISECT_RESET),
-               OPT_CMDMODE(0, "check-and-set-terms", &cmdmode,
-                        N_("check and set terms in a bisection state"), CHECK_AND_SET_TERMS),
                OPT_CMDMODE(0, "bisect-next-check", &cmdmode,
                         N_("check whether bad or good terms exist"), BISECT_NEXT_CHECK),
                OPT_CMDMODE(0, "bisect-terms", &cmdmode,
@@ -1084,12 +1080,6 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
                        return error(_("--bisect-reset requires either no argument or a commit"));
                res = bisect_reset(argc ? argv[0] : NULL);
                break;
-       case CHECK_AND_SET_TERMS:
-               if (argc != 3)
-                       return error(_("--check-and-set-terms requires 3 arguments"));
-               set_terms(&terms, argv[2], argv[1]);
-               res = check_and_set_terms(&terms, argv[0]);
-               break;
        case BISECT_NEXT_CHECK:
                if (argc != 2 && argc != 3)
                        return error(_("--bisect-next-check requires 2 or 3 arguments"));