]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
Bluetooth: Use led_set_brightness() in LED trigger activate() callback
authorHans de Goede <hdegoede@redhat.com>
Tue, 27 Aug 2024 10:52:48 +0000 (12:52 +0200)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Tue, 10 Sep 2024 17:06:11 +0000 (13:06 -0400)
A LED trigger's activate() callback gets called when the LED trigger
gets activated for a specific LED, so that the trigger code can ensure
the LED state matches the current state of the trigger condition
(LED_FULL when HCI_UP is set in this case).

led_trigger_event() is intended for trigger condition state changes and
iterates over _all_ LEDs which are controlled by this trigger changing
the brightness of each of them.

In the activate() case only the brightness of the LED which is being
activated needs to change and that LED is passed as an argument to
activate(), switch to led_set_brightness() to only change the brightness
of the LED being activated.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
net/bluetooth/leds.c

index f46847632ffa1e95e30537c173e078c7aa8f9be9..6e349704efe4713b30a32466081a43799bf9ddcb 100644 (file)
@@ -48,7 +48,7 @@ static int power_activate(struct led_classdev *led_cdev)
        htrig = to_hci_basic_led_trigger(led_cdev->trigger);
        powered = test_bit(HCI_UP, &htrig->hdev->flags);
 
-       led_trigger_event(led_cdev->trigger, powered ? LED_FULL : LED_OFF);
+       led_set_brightness(led_cdev, powered ? LED_FULL : LED_OFF);
 
        return 0;
 }