nfp: warn on experimental TLV types

Reserve two TLV types for feature development, and warn in the driver
if they ever leak into production.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.c b/drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.c
index 1f9149bb2ae6b119b571d9e942c62a4d955cfa8b..2190836eaa1d0fd6e2c79c21f8417b1b1ff02a83 100644 (file)
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.c
@@ -113,6 +113,13 @@ int nfp_net_tlv_caps_parse(struct device *dev, u8 __iomem *ctrl_mem,
                                caps->mbox_len = length;
                        }
                        break;
+               case NFP_NET_CFG_TLV_TYPE_EXPERIMENTAL0:
+               case NFP_NET_CFG_TLV_TYPE_EXPERIMENTAL1:
+                       dev_warn(dev,
+                                "experimental TLV type:%u offset:%u len:%u\n",
+                                FIELD_GET(NFP_NET_CFG_TLV_HEADER_TYPE, hdr),
+                                offset, length);
+                       break;
                default:
                        if (!FIELD_GET(NFP_NET_CFG_TLV_HEADER_REQUIRED, hdr))
                                break;

diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.h b/drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.h
index 44d3ea75d043a2867fa6ae717535fae80c6a4dd6..a5149074768924a1d2498af42f44c37cad57d5e8 100644 (file)
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.h
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.h
@@ -489,12 +489,20 @@
  * %NFP_NET_CFG_TLV_TYPE_MBOX:
  * Variable, mailbox area.  Overwrites the default location which is
  * %NFP_NET_CFG_MBOX_BASE and length %NFP_NET_CFG_MBOX_VAL_MAX_SZ.
+ *
+ * %NFP_NET_CFG_TLV_TYPE_EXPERIMENTAL0:
+ * %NFP_NET_CFG_TLV_TYPE_EXPERIMENTAL1:
+ * Variable, experimental IDs.  IDs designated for internal development and
+ * experiments before a stable TLV ID has been allocated to a feature.  Should
+ * never be present in production firmware.
  */
 #define NFP_NET_CFG_TLV_TYPE_UNKNOWN           0
 #define NFP_NET_CFG_TLV_TYPE_RESERVED          1
 #define NFP_NET_CFG_TLV_TYPE_END               2
 #define NFP_NET_CFG_TLV_TYPE_ME_FREQ           3
 #define NFP_NET_CFG_TLV_TYPE_MBOX              4
+#define NFP_NET_CFG_TLV_TYPE_EXPERIMENTAL0     5
+#define NFP_NET_CFG_TLV_TYPE_EXPERIMENTAL1     6
 
 struct device;