]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
ci(lint): exclude `.in` files from ShellCheck lint
authorJan Macku <jamacku@redhat.com>
Mon, 7 Aug 2023 13:11:00 +0000 (15:11 +0200)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Mon, 7 Aug 2023 17:28:23 +0000 (19:28 +0200)
Exclude all `.in` files because they may contain unsupported syntax, and
they have to be preprocessed first. For example:

```sh
Error: SHELLCHECK_WARNING:
./src/rpm/systemd-update-helper.in:130:37: warning[SC1083]: This { is literal. Check expression (missing ;/\n?) or quote it.
```

Related to: https://github.com/systemd/systemd/pull/28521

.github/workflows/differential-shellcheck.yml

index 6f4b69d8a78527861937040f4a3904ada61f3fb8..4b40d397a35853a6406a8f9a1766d8e0859aa880 100644 (file)
@@ -30,4 +30,6 @@ jobs:
       - name: Differential ShellCheck
         uses: redhat-plumbers-in-action/differential-shellcheck@ac4483d8c6713bd2011037f44fe626989468af74
         with:
+          # exclude all `.in` files because they may contain unsupported syntax, and they have to be preprocessed first
+          exclude-path: '**/*.in'
           token: ${{ secrets.GITHUB_TOKEN }}