]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virCPUDefParseXML: Parse uint using virXPathUInt()
authorMichal Privoznik <mprivozn@redhat.com>
Wed, 20 May 2020 13:36:17 +0000 (15:36 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Fri, 1 Oct 2021 08:52:35 +0000 (10:52 +0200)
There is no need to use virXPathULong() and a temporary UL
variable if we can use virXPathUInt() directly.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
src/conf/cpu_conf.c

index 1674cd695781214b8b47f399c1b476b72f610eb4..d31f28dfe7fea653f2a50e357945fc20f75d5a29 100644 (file)
@@ -526,39 +526,33 @@ virCPUDefParseXML(xmlXPathContextPtr ctxt,
     }
 
     if (virXPathNode("./topology[1]", ctxt)) {
-        unsigned long ul;
-
-        if (virXPathULong("string(./topology[1]/@sockets)", ctxt, &ul) < 0) {
+        if (virXPathUInt("string(./topology[1]/@sockets)", ctxt, &def->sockets) < 0) {
             virReportError(VIR_ERR_XML_ERROR, "%s",
                            _("Missing 'sockets' attribute in CPU topology"));
             return -1;
         }
-        def->sockets = (unsigned int) ul;
 
         if (virXPathNode("./topology[1]/@dies", ctxt)) {
-            if (virXPathULong("string(./topology[1]/@dies)", ctxt, &ul) < 0) {
+            if (virXPathUInt("string(./topology[1]/@dies)", ctxt, &def->dies) < 0) {
                 virReportError(VIR_ERR_XML_ERROR, "%s",
                                _("Malformed 'dies' attribute in CPU topology"));
                 return -1;
             }
-            def->dies = (unsigned int) ul;
         } else {
             def->dies = 1;
         }
 
-        if (virXPathULong("string(./topology[1]/@cores)", ctxt, &ul) < 0) {
+        if (virXPathUInt("string(./topology[1]/@cores)", ctxt, &def->cores) < 0) {
             virReportError(VIR_ERR_XML_ERROR, "%s",
                            _("Missing 'cores' attribute in CPU topology"));
             return -1;
         }
-        def->cores = (unsigned int) ul;
 
-        if (virXPathULong("string(./topology[1]/@threads)", ctxt, &ul) < 0) {
+        if (virXPathUInt("string(./topology[1]/@threads)", ctxt, &def->threads) < 0) {
             virReportError(VIR_ERR_XML_ERROR, "%s",
                            _("Missing 'threads' attribute in CPU topology"));
             return -1;
         }
-        def->threads = (unsigned int) ul;
 
         if (!def->sockets || !def->cores || !def->threads || !def->dies) {
             virReportError(VIR_ERR_XML_ERROR, "%s",