driver-sqlpool: Only strdup error on error

Satisfies static analyzers

diff --git a/src/lib-sql/driver-sqlpool.c b/src/lib-sql/driver-sqlpool.c
index 726d7507fc8fd6e08111590dc85a7415d45d2cfc..556d7f62b7ca0dce91a715ea9c028261c019d551 100644 (file)
--- a/src/lib-sql/driver-sqlpool.c
+++ b/src/lib-sql/driver-sqlpool.c
@@ -515,8 +515,9 @@ int driver_sqlpool_init_full(const struct sql_settings *set, const struct sql_db
 
        T_BEGIN {
                const char *tmp = NULL;
-               ret = driver_sqlpool_parse_hosts(db, set->connect_string, &tmp);
-               error = i_strdup(tmp);
+               if ((ret = driver_sqlpool_parse_hosts(db, set->connect_string,
+                                                     &tmp)) < 0)
+                       error = i_strdup(tmp);
        } T_END;
 
        if (ret < 0) {