]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
migration: Don't sync volatile memory after migration completes
authorChaney, Ben <bchaney@akamai.com>
Mon, 16 Jun 2025 20:56:50 +0000 (20:56 +0000)
committerPeter Xu <peterx@redhat.com>
Mon, 23 Jun 2025 20:03:59 +0000 (16:03 -0400)
Syncing volatile memory provides no benefit, instead it can cause
performance issues in some cases.  Only sync memory that is marked as
non-volatile after migration completes on destination.

Signed-off-by: Ben Chaney <bchaney@akamai.com>
Fixes: bd108a44bc29 (migration: ram: Switch to ram block writeback)
Link: https://lore.kernel.org/r/1CC43F59-336F-4A12-84AD-DB89E0A17A95@akamai.com
Signed-off-by: Peter Xu <peterx@redhat.com>
migration/ram.c

index fd8d83b63cb8f06ebd1a485f9502168b9659225f..024d8b3d03d09035d1806aedf2c52815cd6661f7 100644 (file)
@@ -3680,7 +3680,9 @@ static int ram_load_cleanup(void *opaque)
     RAMBlock *rb;
 
     RAMBLOCK_FOREACH_NOT_IGNORED(rb) {
-        qemu_ram_block_writeback(rb);
+        if (memory_region_is_nonvolatile(rb->mr)) {
+            qemu_ram_block_writeback(rb);
+        }
     }
 
     xbzrle_load_cleanup();