]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: stmmac: lpc18xx: use stmmac_get_phy_intf_sel()
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thu, 6 Nov 2025 11:23:21 +0000 (11:23 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sat, 8 Nov 2025 03:05:48 +0000 (19:05 -0800)
Use stmmac_get_phy_intf_sel() to decode the PHY interface mode to the
phy_intf_sel value, and use the result to program the ethernet mode.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1vGy5J-0000000DhQD-46Ob@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c

index 895d16dc0a4b52cd4215a1531e612f79c6fe6d7b..0f6be2a17e659d4016c5d6e6a7f12b5889f48d3c 100644 (file)
@@ -47,15 +47,14 @@ static int lpc18xx_dwmac_probe(struct platform_device *pdev)
                return PTR_ERR(reg);
        }
 
-       if (plat_dat->phy_interface == PHY_INTERFACE_MODE_MII) {
-               ethmode = PHY_INTF_SEL_GMII_MII;
-       } else if (plat_dat->phy_interface == PHY_INTERFACE_MODE_RMII) {
-               ethmode = PHY_INTF_SEL_RMII;
-       } else {
+       if (plat_dat->phy_interface != PHY_INTERFACE_MODE_MII &&
+           plat_dat->phy_interface != PHY_INTERFACE_MODE_RMII) {
                dev_err(&pdev->dev, "Only MII and RMII mode supported\n");
                return -EINVAL;
        }
 
+       ethmode = stmmac_get_phy_intf_sel(plat_dat->phy_interface);
+
        regmap_update_bits(reg, LPC18XX_CREG_CREG6,
                           LPC18XX_CREG_CREG6_ETHMODE_MASK, ethmode);