]> git.ipfire.org Git - thirdparty/libarchive.git/commitdiff
Rename archive_read_finish to archive_read_free and
authorTim Kientzle <kientzle@gmail.com>
Mon, 8 Feb 2010 07:18:22 +0000 (02:18 -0500)
committerTim Kientzle <kientzle@gmail.com>
Mon, 8 Feb 2010 07:18:22 +0000 (02:18 -0500)
archive_write_finish to archive_write_free.  Update all clients,
tests, and documentation to use the new names exclusively.  (Though
I've not yet run a global search-and-replace against the Wiki.  I'll
do that shortly.)

I've preserved the old names as aliases, scheduled to be removed with
libarchive 4.x, so there is no immediate impact to existing code from
this change.

SVN-Revision: 1891

123 files changed:
contrib/shar/shar.c
cpio/cpio.c
examples/minitar/minitar.c
examples/tarfilter.c
examples/untar.c
libarchive/archive.h
libarchive/archive_private.h
libarchive/archive_read.3
libarchive/archive_read.c
libarchive/archive_read_disk.3
libarchive/archive_read_disk.c
libarchive/archive_read_extract.c
libarchive/archive_virtual.c
libarchive/archive_write.3
libarchive/archive_write.c
libarchive/archive_write_disk.3
libarchive/archive_write_disk.c
libarchive/libarchive.3
libarchive/test/test_acl_freebsd.c
libarchive/test/test_acl_pax.c
libarchive/test/test_bad_fd.c
libarchive/test/test_compat_bzip2.c
libarchive/test/test_compat_cpio.c
libarchive/test/test_compat_gtar.c
libarchive/test/test_compat_gzip.c
libarchive/test/test_compat_lzma.c
libarchive/test/test_compat_solaris_tar_acl.c
libarchive/test/test_compat_tar_hardlink.c
libarchive/test/test_compat_xz.c
libarchive/test/test_compat_zip.c
libarchive/test/test_empty_write.c
libarchive/test/test_extattr_freebsd.c
libarchive/test/test_fuzz.c
libarchive/test/test_open_fd.c
libarchive/test/test_open_file.c
libarchive/test/test_open_filename.c
libarchive/test/test_pax_filename_encoding.c
libarchive/test/test_read_compress_program.c
libarchive/test/test_read_data_large.c
libarchive/test/test_read_disk.c
libarchive/test/test_read_disk_entry_from_file.c
libarchive/test/test_read_extract.c
libarchive/test/test_read_file_nonexistent.c
libarchive/test/test_read_format_ar.c
libarchive/test/test_read_format_cpio_afio.c
libarchive/test/test_read_format_cpio_bin.c
libarchive/test/test_read_format_cpio_bin_Z.c
libarchive/test/test_read_format_cpio_bin_be.c
libarchive/test/test_read_format_cpio_bin_bz2.c
libarchive/test/test_read_format_cpio_bin_gz.c
libarchive/test/test_read_format_cpio_bin_lzma.c
libarchive/test/test_read_format_cpio_bin_xz.c
libarchive/test/test_read_format_cpio_odc.c
libarchive/test/test_read_format_cpio_svr4_bzip2_rpm.c
libarchive/test/test_read_format_cpio_svr4_gzip.c
libarchive/test/test_read_format_cpio_svr4_gzip_rpm.c
libarchive/test/test_read_format_cpio_svr4c_Z.c
libarchive/test/test_read_format_empty.c
libarchive/test/test_read_format_gtar_gz.c
libarchive/test/test_read_format_gtar_lzma.c
libarchive/test/test_read_format_gtar_sparse.c
libarchive/test/test_read_format_iso_gz.c
libarchive/test/test_read_format_iso_multi_extent.c
libarchive/test/test_read_format_isojoliet_bz2.c
libarchive/test/test_read_format_isojoliet_long.c
libarchive/test/test_read_format_isojoliet_rr.c
libarchive/test/test_read_format_isorr_bz2.c
libarchive/test/test_read_format_isorr_ce.c
libarchive/test/test_read_format_isorr_new_bz2.c
libarchive/test/test_read_format_isorr_rr_moved.c
libarchive/test/test_read_format_isozisofs_bz2.c
libarchive/test/test_read_format_mtree.c
libarchive/test/test_read_format_pax_bz2.c
libarchive/test/test_read_format_raw.c
libarchive/test/test_read_format_tar.c
libarchive/test/test_read_format_tar_empty_filename.c
libarchive/test/test_read_format_tbz.c
libarchive/test/test_read_format_tgz.c
libarchive/test/test_read_format_tlz.c
libarchive/test/test_read_format_txz.c
libarchive/test/test_read_format_tz.c
libarchive/test/test_read_format_xar.c
libarchive/test/test_read_format_zip.c
libarchive/test/test_read_large.c
libarchive/test/test_read_pax_truncated.c
libarchive/test/test_read_position.c
libarchive/test/test_read_truncated.c
libarchive/test/test_read_uu.c
libarchive/test/test_sparse_basic.c
libarchive/test/test_tar_filenames.c
libarchive/test/test_tar_large.c
libarchive/test/test_ustar_filenames.c
libarchive/test/test_write_compress.c
libarchive/test/test_write_compress_bzip2.c
libarchive/test/test_write_compress_gzip.c
libarchive/test/test_write_compress_lzma.c
libarchive/test/test_write_compress_program.c
libarchive/test/test_write_compress_xz.c
libarchive/test/test_write_disk.c
libarchive/test/test_write_disk_failures.c
libarchive/test/test_write_disk_hardlink.c
libarchive/test/test_write_disk_perms.c
libarchive/test/test_write_disk_secure.c
libarchive/test/test_write_disk_sparse.c
libarchive/test/test_write_disk_symlink.c
libarchive/test/test_write_disk_times.c
libarchive/test/test_write_format_ar.c
libarchive/test/test_write_format_cpio.c
libarchive/test/test_write_format_cpio_empty.c
libarchive/test/test_write_format_cpio_newc.c
libarchive/test/test_write_format_cpio_odc.c
libarchive/test/test_write_format_mtree.c
libarchive/test/test_write_format_pax.c
libarchive/test/test_write_format_shar_empty.c
libarchive/test/test_write_format_tar.c
libarchive/test/test_write_format_tar_empty.c
libarchive/test/test_write_format_tar_ustar.c
libarchive/test/test_write_format_zip.c
libarchive/test/test_write_format_zip_empty.c
libarchive/test/test_write_format_zip_no_compression.c
libarchive/test/test_write_open_memory.c
tar/read.c
tar/write.c

index 12c84255309f663aa1860b49099b0f83fa68c096..6d5c206e2a519f46d42950bbafc0a524d27381a7 100644 (file)
@@ -269,7 +269,7 @@ shar_write(char **fn, size_t nfn)
                }
        }
 
-       if (archive_write_finish(a) != ARCHIVE_OK)
+       if (archive_write_free(a) != ARCHIVE_OK)
                errx(EXIT_FAILURE, "%s", archive_error_string(a));
 
        if (error != 0)
index cab7f01d889158f4c0830c5dcd6198a124cdd066..616b2ea1c05e5c2e2d6da847159c182e0950b4ff 100644 (file)
@@ -545,7 +545,7 @@ mode_out(struct cpio *cpio)
                fprintf(stderr, "%lu %s\n", (unsigned long)blocks,
                    blocks == 1 ? "block" : "blocks");
        }
-       archive_write_finish(cpio->archive);
+       archive_write_free(cpio->archive);
 }
 
 /*
@@ -881,8 +881,8 @@ mode_in(struct cpio *cpio)
                fprintf(stderr, "%lu %s\n", (unsigned long)blocks,
                    blocks == 1 ? "block" : "blocks");
        }
-       archive_read_finish(a);
-       archive_write_finish(ext);
+       archive_read_free(a);
+       archive_write_free(ext);
        exit(cpio->return_value);
 }
 
@@ -956,7 +956,7 @@ mode_list(struct cpio *cpio)
                fprintf(stderr, "%lu %s\n", (unsigned long)blocks,
                    blocks == 1 ? "block" : "blocks");
        }
-       archive_read_finish(a);
+       archive_read_free(a);
        exit(0);
 }
 
@@ -1092,7 +1092,7 @@ mode_pass(struct cpio *cpio, const char *destdir)
                    blocks == 1 ? "block" : "blocks");
        }
 
-       archive_write_finish(cpio->archive);
+       archive_write_free(cpio->archive);
 }
 
 /*
index 7e9011183774377847bd0828fa338d31487c70c9..3e466ae9668e0be39d772ac62ac57f2f672f0b2e 100644 (file)
@@ -289,7 +289,7 @@ create(const char *filename, int compress, const char **argv)
                argv++;
        }
        archive_write_close(a);
-       archive_write_finish(a);
+       archive_write_free(a);
 }
 #endif
 
@@ -353,7 +353,7 @@ extract(const char *filename, int do_extract, int flags)
                        msg("\n");
        }
        archive_read_close(a);
-       archive_read_finish(a);
+       archive_read_free(a);
        exit(0);
 }
 
index b7e08cfc1dac7a7539c25305d07ca53e493d33c5..976dd056e5335fc2263e35e4deac36434b77f1da 100644 (file)
@@ -105,9 +105,9 @@ main(int argc, char **argv)
        if (r != ARCHIVE_EOF)
                die("Error reading archive");
        /* Close the archives.  */
-       if (archive_read_finish(ina) != ARCHIVE_OK)
+       if (archive_read_free(ina) != ARCHIVE_OK)
                die("Error closing input archive");
-       if (archive_write_finish(outa) != ARCHIVE_OK)
+       if (archive_write_free(outa) != ARCHIVE_OK)
                die("Error closing output archive");
        return (0);
 }
index e77adf7012577b53dc4046a5c6db5a1573921acd..98338e10d3b5e33287bb6453151300170d4eb430 100644 (file)
@@ -190,7 +190,7 @@ extract(const char *filename, int do_extract, int flags)
                        msg("\n");
        }
        archive_read_close(a);
-       archive_read_finish(a);
+       archive_read_free(a);
        exit(0);
 }
 
index 8ff934a2e222d82449e6dae868374ca04d3868ca..e2c8b8c1f16319fecfe2a797c29ca83dfab004af 100644 (file)
@@ -482,8 +482,12 @@ __LA_DECL void             archive_read_extract_set_skip_file(struct archive *,
 /* Close the file and release most resources. */
 __LA_DECL int           archive_read_close(struct archive *);
 /* Release all resources and destroy the object. */
-/* Note that archive_read_finish will call archive_read_close for you. */
+/* Note that archive_read_free will call archive_read_close for you. */
+__LA_DECL int           archive_read_free(struct archive *);
+#if ARCHIVE_VERSION_NUMBER < 4000000
+/* Synonym for archive_read_free() for backwards compatibility. */
 __LA_DECL int           archive_read_finish(struct archive *);
+#endif
 
 /*-
  * To create an archive:
@@ -498,7 +502,7 @@ __LA_DECL int                archive_read_finish(struct archive *);
  *      - archive_write_header to write the header
  *      - archive_write_data to write the entry data
  *   5) archive_write_close to close the output
- *   6) archive_write_finish to cleanup the writer and release resources
+ *   6) archive_write_free to cleanup the writer and release resources
  */
 __LA_DECL struct archive       *archive_write_new(void);
 __LA_DECL int           archive_write_set_bytes_per_block(struct archive *,
@@ -573,10 +577,13 @@ __LA_DECL __LA_SSIZE_T     archive_write_data_block(struct archive *,
 #endif
 __LA_DECL int           archive_write_finish_entry(struct archive *);
 __LA_DECL int           archive_write_close(struct archive *);
-/* Libarchive 2.x and later returns an error if this fails. */
-/* It can fail if the archive wasn't already closed, in which case
- * archive_write_finish() will implicitly call archive_write_close(). */
+/* This can fail if the archive wasn't already closed, in which case
+ * archive_write_free() will implicitly call archive_write_close(). */
+__LA_DECL int           archive_write_free(struct archive *);
+#if ARCHIVE_VERSION_NUMBER < 4000000
+/* Synonym for archive_write_free() for backwards compatibility. */
 __LA_DECL int           archive_write_finish(struct archive *);
+#endif
 
 /*
  * Set write options.
@@ -603,7 +610,7 @@ __LA_DECL int               archive_write_set_options(struct archive *_a,
  *      - construct an appropriate struct archive_entry structure
  *      - archive_write_header to create the file/dir/etc on disk
  *      - archive_write_data to write the entry data
- *   4) archive_write_finish to cleanup the writer and release resources
+ *   4) archive_write_free to cleanup the writer and release resources
  *
  * In particular, you can use this in conjunction with archive_read()
  * to pull entries out of an archive and create them on disk.
index 63384b82fed02794e96cf420a3713070d2e438b2..fba3d62a20afb636aca09090b812343fa8e7ec48 100644 (file)
@@ -58,7 +58,7 @@
 
 struct archive_vtable {
        int     (*archive_close)(struct archive *);
-       int     (*archive_finish)(struct archive *);
+       int     (*archive_free)(struct archive *);
        int     (*archive_write_header)(struct archive *,
            struct archive_entry *);
        int     (*archive_write_finish_entry)(struct archive *);
index 742bebfab7f6b1126716f4b41059e5d95f91b887..51eb52e795c9d800f417fbfb6259ef578fa10155 100644 (file)
@@ -69,7 +69,7 @@
 .Nm archive_read_extract2 ,
 .Nm archive_read_extract_set_progress_callback ,
 .Nm archive_read_close ,
-.Nm archive_read_finish
+.Nm archive_read_free
 .Nd functions for reading streaming archives
 .Sh SYNOPSIS
 .In archive.h
 .Ft int
 .Fn archive_read_close "struct archive *"
 .Ft int
-.Fn archive_read_finish "struct archive *"
+.Fn archive_read_free "struct archive *"
 .Sh DESCRIPTION
 These functions provide a complete API for reading streaming archives.
 The general process is to first create the
@@ -457,7 +457,7 @@ object and the archive_entry object so that various statistics
 can be retrieved for the progress display.
 .It Fn archive_read_close
 Complete the archive and invoke the close callback.
-.It Fn archive_read_finish
+.It Fn archive_read_free
 Invokes
 .Fn archive_read_close
 if it was not invoked manually, then release all resources.
@@ -591,7 +591,7 @@ list_archive(const char *name)
     printf("%s\\n",archive_entry_pathname(entry));
     archive_read_data_skip(a);
   }
-  archive_read_finish(a);
+  archive_read_free(a);
   free(mydata);
 }
 
index abb419eea5c7fd02a6f0f532c4993534a0093593..9ed61efb923fce20715b33472432cda3bf783ade 100644 (file)
@@ -60,7 +60,7 @@ static int    choose_format(struct archive_read *);
 static int     cleanup_filters(struct archive_read *);
 static struct archive_vtable *archive_read_vtable(void);
 static int     _archive_read_close(struct archive *);
-static int     _archive_read_finish(struct archive *);
+static int     _archive_read_free(struct archive *);
 
 static struct archive_vtable *
 archive_read_vtable(void)
@@ -69,7 +69,7 @@ archive_read_vtable(void)
        static int inited = 0;
 
        if (!inited) {
-               av.archive_finish = _archive_read_finish;
+               av.archive_free = _archive_read_free;
                av.archive_close = _archive_read_close;
        }
        return (&av);
@@ -779,7 +779,7 @@ cleanup_filters(struct archive_read *a)
  * Release memory and other resources.
  */
 static int
-_archive_read_finish(struct archive *_a)
+_archive_read_free(struct archive *_a)
 {
        struct archive_read *a = (struct archive_read *)_a;
        int i;
@@ -787,7 +787,7 @@ _archive_read_finish(struct archive *_a)
        int r = ARCHIVE_OK;
 
        __archive_check_magic(_a, ARCHIVE_READ_MAGIC, ARCHIVE_STATE_ANY,
-           "archive_read_finish");
+           "archive_read_free");
        if (a->archive.state != ARCHIVE_STATE_CLOSED)
                r = archive_read_close(&a->archive);
 
index b3a09b5283926f0ad46cc2a07cd50ba8699f70bb..c4c4f627721ad10dc7f36907aa27964491880951 100644 (file)
@@ -39,7 +39,7 @@
 .Nm archive_read_disk_set_gname_lookup ,
 .Nm archive_read_disk_set_standard_lookup ,
 .Nm archive_read_close ,
-.Nm archive_read_finish
+.Nm archive_read_free
 .Nd functions for reading objects from disk
 .Sh SYNOPSIS
 .In archive.h
@@ -81,7 +81,7 @@
 .Ft int
 .Fn archive_read_close "struct archive *"
 .Ft int
-.Fn archive_read_finish "struct archive *"
+.Fn archive_read_free "struct archive *"
 .Sh DESCRIPTION
 These functions provide an API for reading information about
 objects on disk.
@@ -178,7 +178,7 @@ This affects the file ownership fields and ACL values in the
 object.
 .It Fn archive_read_close
 This currently does nothing.
-.It Fn archive_write_finish
+.It Fn archive_write_free
 Invokes
 .Fn archive_write_close
 if it was not invoked manually, then releases all resources.
@@ -213,7 +213,7 @@ file_to_archive(struct archive *a, const char *name)
   while ((bytes_read = read(fd, buff, sizeof(buff))) > 0)
     archive_write_data(a, buff, bytes_read);
   archive_write_finish_entry(a);
-  archive_read_finish(ard);
+  archive_read_free(ard);
   archive_entry_free(entry);
 }
 .Ed
index 8fad7f13733451985786f6a4c9a0773dfd78108b..dc43e179c7c5cd824572d5c9ad192ffd069b520d 100644 (file)
@@ -33,7 +33,7 @@ __FBSDID("$FreeBSD: head/lib/libarchive/archive_read_disk.c 189429 2009-03-06 04
 #include "archive_private.h"
 #include "archive_read_disk_private.h"
 
-static int     _archive_read_finish(struct archive *);
+static int     _archive_read_free(struct archive *);
 static int     _archive_read_close(struct archive *);
 static const char *trivial_lookup_gname(void *, gid_t gid);
 static const char *trivial_lookup_uname(void *, uid_t uid);
@@ -45,7 +45,7 @@ archive_read_disk_vtable(void)
        static int inited = 0;
 
        if (!inited) {
-               av.archive_finish = _archive_read_finish;
+               av.archive_free = _archive_read_free;
                av.archive_close = _archive_read_close;
        }
        return (&av);
@@ -129,7 +129,7 @@ archive_read_disk_new(void)
 }
 
 static int
-_archive_read_finish(struct archive *_a)
+_archive_read_free(struct archive *_a)
 {
        struct archive_read_disk *a = (struct archive_read_disk *)_a;
 
index c2f40c54a5dad9d3062228d6eb71f42e2616615c..b698916fe0b3f84423c78f1a7db2204eeb50ff80 100644 (file)
@@ -172,7 +172,7 @@ archive_read_extract_cleanup(struct archive_read *a)
 {
        int ret = ARCHIVE_OK;
 
-       ret = archive_write_finish(a->extract->ad);
+       ret = archive_write_free(a->extract->ad);
        free(a->extract);
        a->extract = NULL;
        return (ret);
index 0bd2d5bc706ccba9a725b7d06d92e4dfd15218ff..836886270f9f926a0b2e04b4a18d08a1bdd6fee3 100644 (file)
@@ -42,17 +42,35 @@ archive_read_close(struct archive *a)
        return ((a->vtable->archive_close)(a));
 }
 
+int
+archive_write_free(struct archive *a)
+{
+       return ((a->vtable->archive_free)(a));
+}
+
+#if ARCHIVE_VERSION_NUMBER < 4000000
+/* For backwards compatibility; will be removed with libarchive 4.0. */
 int
 archive_write_finish(struct archive *a)
 {
-       return ((a->vtable->archive_finish)(a));
+       return ((a->vtable->archive_free)(a));
+}
+#endif
+
+int
+archive_read_free(struct archive *a)
+{
+       return ((a->vtable->archive_free)(a));
 }
 
+#if ARCHIVE_VERSION_NUMBER < 4000000
+/* For backwards compatibility; will be removed with libarchive 4.0. */
 int
 archive_read_finish(struct archive *a)
 {
-       return ((a->vtable->archive_finish)(a));
+       return ((a->vtable->archive_free)(a));
 }
+#endif
 
 int
 archive_write_header(struct archive *a, struct archive_entry *entry)
index ffe0c9b45f0ceb0b89a7baf0468bc429c7bedfa2..9a27409a6a8015f2622ff59a9288278f6858c8aa 100644 (file)
@@ -55,7 +55,7 @@
 .Nm archive_write_data ,
 .Nm archive_write_finish_entry ,
 .Nm archive_write_close ,
-.Nm archive_write_finish
+.Nm archive_write_free
 .Nd functions for creating archives
 .Sh SYNOPSIS
 .In archive.h
 .Ft int
 .Fn archive_write_close "struct archive *"
 .Ft int
-.Fn archive_write_finish "struct archive *"
+.Fn archive_write_free "struct archive *"
 .Sh DESCRIPTION
 These functions provide a complete API for creating streaming
 archive files.
@@ -363,16 +363,16 @@ and
 as needed.
 .It Fn archive_write_close
 Complete the archive and invoke the close callback.
-.It Fn archive_write_finish
+.It Fn archive_write_free
 Invokes
 .Fn archive_write_close
-if it was not invoked manually, then releases all resources.
-Note that this function was declared to return
-.Ft void
-in libarchive 1.x, which made it impossible to detect errors when
+if necessary, then releases all resources.
+If you need detailed information about
 .Fn archive_write_close
-was invoked implicitly from this function.
-This is corrected beginning with libarchive 2.0.
+failures, you should be careful to call it separately, as
+you cannot obtain error information after
+.Fn archive_write_free
+returns.
 .El
 More information about the
 .Va struct archive
@@ -529,7 +529,7 @@ write_archive(const char *outname, const char **filename)
     archive_entry_free(entry);
     filename++;
   }
-  archive_write_finish(a);
+  archive_write_free(a);
 }
 
 int main(int argc, const char **argv)
@@ -580,7 +580,7 @@ may include
 .Fn archive_write_data ,
 .Fn archive_write_close ,
 or
-.Fn archive_write_finish .
+.Fn archive_write_free .
 The client callback can call
 .Fn archive_set_error
 to provide values that can then be retrieved by
index e0d942b0754fdb2cbcbbba5ae874564b0a8a10ae..eba7227221a2af8776e283aaca50ac47477cffde 100644 (file)
@@ -60,7 +60,7 @@ __FBSDID("$FreeBSD: head/lib/libarchive/archive_write.c 201099 2009-12-28 03:03:
 static struct archive_vtable *archive_write_vtable(void);
 
 static int     _archive_write_close(struct archive *);
-static int     _archive_write_finish(struct archive *);
+static int     _archive_write_free(struct archive *);
 static int     _archive_write_header(struct archive *, struct archive_entry *);
 static int     _archive_write_finish_entry(struct archive *);
 static ssize_t _archive_write_data(struct archive *, const void *, size_t);
@@ -73,7 +73,7 @@ archive_write_vtable(void)
 
        if (!inited) {
                av.archive_close = _archive_write_close;
-               av.archive_finish = _archive_write_finish;
+               av.archive_free = _archive_write_free;
                av.archive_write_header = _archive_write_header;
                av.archive_write_finish_entry = _archive_write_finish_entry;
                av.archive_write_data = _archive_write_data;
@@ -383,13 +383,13 @@ _archive_write_close(struct archive *_a)
  * Destroy the archive structure.
  */
 static int
-_archive_write_finish(struct archive *_a)
+_archive_write_free(struct archive *_a)
 {
        struct archive_write *a = (struct archive_write *)_a;
        int r = ARCHIVE_OK;
 
        __archive_check_magic(&a->archive, ARCHIVE_WRITE_MAGIC,
-           ARCHIVE_STATE_ANY, "archive_write_finish");
+           ARCHIVE_STATE_ANY, "archive_write_free");
        if (a->archive.state != ARCHIVE_STATE_CLOSED)
                r = archive_write_close(&a->archive);
 
index 5ed4a5038f180f2cba1373714e5e6fd32887ebdf..7bcecc4e0d3a836b17a16a5c19fae34d9e6cb291 100644 (file)
@@ -38,7 +38,7 @@
 .Nm archive_write_data ,
 .Nm archive_write_finish_entry ,
 .Nm archive_write_close ,
-.Nm archive_write_finish
+.Nm archive_write_free
 .Nd functions for creating objects on disk
 .Sh SYNOPSIS
 .In archive.h
@@ -73,7 +73,7 @@
 .Ft int
 .Fn archive_write_close "struct archive *"
 .Ft int
-.Fn archive_write_finish "struct archive *"
+.Fn archive_write_free "struct archive *"
 .Sh DESCRIPTION
 These functions provide a complete API for creating objects on
 disk from
@@ -239,7 +239,7 @@ The
 .Nm
 library maintains a list of all such deferred attributes and
 sets them when this function is invoked.
-.It Fn archive_write_finish
+.It Fn archive_write_free
 Invokes
 .Fn archive_write_close
 if it was not invoked manually, then releases all resources.
@@ -372,4 +372,4 @@ compact implementation when appropriate.
 There should be a corresponding
 .Nm archive_read_disk
 interface that walks a directory heirarchy and returns archive
-entry objects.
\ No newline at end of file
+entry objects.
index 8857551071be0e5f9d06c69f5e9e6effb7396993..f734037cb54bdc9211d9e4f421dc5944513d61b4 100644 (file)
@@ -255,7 +255,7 @@ static ssize_t      write_data_block(struct archive_write_disk *,
 static struct archive_vtable *archive_write_disk_vtable(void);
 
 static int     _archive_write_close(struct archive *);
-static int     _archive_write_finish(struct archive *);
+static int     _archive_write_free(struct archive *);
 static int     _archive_write_header(struct archive *, struct archive_entry *);
 static int     _archive_write_finish_entry(struct archive *);
 static ssize_t _archive_write_data(struct archive *, const void *, size_t);
@@ -294,7 +294,7 @@ archive_write_disk_vtable(void)
 
        if (!inited) {
                av.archive_close = _archive_write_close;
-               av.archive_finish = _archive_write_finish;
+               av.archive_free = _archive_write_free;
                av.archive_write_header = _archive_write_header;
                av.archive_write_finish_entry = _archive_write_finish_entry;
                av.archive_write_data = _archive_write_data;
@@ -1325,7 +1325,7 @@ _archive_write_close(struct archive *_a)
 }
 
 static int
-_archive_write_finish(struct archive *_a)
+_archive_write_free(struct archive *_a)
 {
        struct archive_write_disk *a = (struct archive_write_disk *)_a;
        int ret;
index 8c19d008a90f1d6adab0d49f39465426ff4dcb1b..c292d386ff825c9204007b8d59d41327a7d4af20 100644 (file)
@@ -24,7 +24,7 @@
 .\"
 .\" $FreeBSD: src/lib/libarchive/libarchive.3,v 1.11 2007/01/09 08:05:56 kientzle Exp $
 .\"
-.Dd August 19, 2006
+.Dd February 6, 2010
 .Dt LIBARCHIVE 3
 .Os
 .Sh NAME
@@ -61,13 +61,14 @@ GNU-format tar archives,
 .It
 most common cpio archive formats,
 .It
-ISO9660 CD images (with or without RockRidge extensions),
+ISO9660 CD images (including RockRidge and Joliet extensions),
 .It
 Zip archives.
 .El
 The library automatically detects archives compressed with
 .Xr gzip 1 ,
 .Xr bzip2 1 ,
+.Xr xz 1 ,
 or
 .Xr compress 1
 and decompresses them transparently.
@@ -87,6 +88,8 @@ archives,
 .It
 POSIX octet-oriented cpio archives,
 .It
+Zip archive,
+.It
 two different variants of shar archives.
 .El
 Pax interchange format is an extension of the tar archive format that
@@ -168,12 +171,12 @@ You can use
 (which works much like the
 .Xr read 2
 system call)
-to read this data from the archive.
+to read this data from the archive, or
+.Fn archive_read_data_block
+which provides a slightly more efficient interface.
 You may prefer to use the higher-level
 .Fn archive_read_data_skip ,
 which reads and discards the data for this entry,
-.Fn archive_read_data_to_buffer ,
-which reads the data into an in-memory buffer,
 .Fn archive_read_data_to_file ,
 which copies the data to the provided file descriptor, or
 .Fn archive_read_extract ,
@@ -192,7 +195,7 @@ Once you have finished reading data from the archive, you
 should call
 .Fn archive_read_close
 to close the archive, then call
-.Fn archive_read_finish
+.Fn archive_read_free
 to release all resources, including all memory allocated by the library.
 .Pp
 The
@@ -230,12 +233,34 @@ You can then use
 to write the actual data.
 .Pp
 After all entries have been written, use the
-.Fn archive_write_finish
+.Fn archive_write_free
 function to release all resources.
 .Pp
 The
 .Xr archive_write 3
 manual page provides more detailed calling information for this API.
+.Sh WRITING ENTRIES TO DISK
+The
+.Xr archive_write_disk 3
+API allows you to write
+.Xr archive_entry 3
+objects to disk using the same API used by
+.Xr archive_write 3 .
+The
+.Xr archive_write_disk 3
+API is used internally by
+.Fn archive_read_extract ;
+using it directly can provide greater control over how entries
+get written to disk.
+This API also makes it possible to share code between
+archive-to-archive copy and archive-to-disk extraction
+operations.
+.Sh READING ENTRIES FROM DISK
+The
+.Xr archive_read_disk 3
+provides some support for populating
+.Xr archive_entry 3
+objects from information in the filesystem.
 .Sh DESCRIPTION
 Detailed descriptions of each function are provided by the
 corresponding manual pages.
@@ -259,7 +284,9 @@ In particular, pax interchange format can easily accommodate pathnames
 in arbitrary character sets that exceed
 .Va PATH_MAX .
 .Sh RETURN VALUES
-Most functions return zero on success, non-zero on error.
+Most functions return
+.Cm ARCHIVE_OK
+(zero) on success, non-zero on error.
 The return value indicates the general severity of the error, ranging
 from
 .Cm ARCHIVE_WARN ,
@@ -329,3 +356,14 @@ stored in an
 is supported by all formats.
 For example, cpio formats do not support nanosecond timestamps;
 old tar formats do not support large device numbers.
+.Pp
+The
+.Xr archive_read_disk 3
+API should support iterating over filesystems;
+that would make it possible to share code among
+disk-to-archive, archive-to-archive, archive-to-disk,
+and disk-to-disk operations.
+Currently, it only supports reading the
+information for a single file.
+(Which is still quite useful, as it hides a lot
+of system-specific details.)
index be502067f5fe1c4f780fc595de6ab4a259741e82..8529ca9fb38c0159b6f8c2847afa7f65a9da5bc6 100644 (file)
@@ -242,7 +242,7 @@ DEFINE_TEST(test_acl_freebsd)
 
        /* Close the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /* Verify the data on disk. */
        assertEqualInt(0, stat("test0", &st));
index d57b6028da787011de3fd33dde3eb52e402b040b..794bc2da817e36ac9de72d6662f9271afa2222b2 100644 (file)
@@ -441,7 +441,7 @@ DEFINE_TEST(test_acl_pax)
 
        /* Close out the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /* Write out the data we generated to a file for manual inspection. */
        assert(NULL != (f = fopen("testout", "wb")));
@@ -500,5 +500,5 @@ DEFINE_TEST(test_acl_pax)
 
        /* Close the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
index 99b74f12b5893254c36f87cd26ef7dc1e5aec5d9..34331b8b30fb7cfffdc4b6a61d2a2fc40433a524 100644 (file)
@@ -33,5 +33,5 @@ DEFINE_TEST(test_bad_fd)
        assertA(0 == archive_read_support_compression_all(a));
        assertA(ARCHIVE_FATAL == archive_read_open_fd(a, -1, 1024));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
index 343f451ae692316536f1f5b2cb9490b300d8c23e..61caa7c21811e6212490beebb2fd8063fc5f4365 100644 (file)
@@ -72,7 +72,7 @@ compat_bzip2(const char *name)
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_TAR_USTAR);
 
        assertEqualInt(ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index 8f97036c4f39a8497b86e15f4d4556613d5c43c8..19ce48d581434fee01256fdd9e1d5c87ab682ab5 100644 (file)
@@ -94,7 +94,7 @@ test_compat_cpio_1(void)
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_CPIO_SVR4_NOCRC);
 
        assertEqualInt(ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index 75262601a9840e9c6461949124b4050e18268a8b..d3c32dbbe3e68fcfc1e21d29c24517a13b459ee1 100644 (file)
@@ -54,7 +54,7 @@ test_compat_gtar_1(void)
        /* Read first entry. */
        assertEqualIntA(a, ARCHIVE_OK, r = archive_read_next_header(a, &ae));
        if (r != ARCHIVE_OK) {
-               archive_read_finish(a);
+               archive_read_free(a);
                return;
        }
        assertEqualString(
@@ -73,7 +73,7 @@ test_compat_gtar_1(void)
        /* Read second entry. */
        assertEqualIntA(a, ARCHIVE_OK, r = archive_read_next_header(a, &ae));
        if (r != ARCHIVE_OK) {
-               archive_read_finish(a);
+               archive_read_free(a);
                return;
        }
        assertEqualString(
@@ -103,7 +103,7 @@ test_compat_gtar_1(void)
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_TAR_GNUTAR);
 
        assertEqualInt(ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index a76b2f8f8d7b911d9acf3d34293752b8ddf36426..b323e694da656a1334145f4824febcd10509ee34 100644 (file)
@@ -50,7 +50,7 @@ verify(const char *name)
        r = archive_read_support_compression_gzip(a);
        if (r == ARCHIVE_WARN) {
                skipping("gzip reading not fully supported on this platform");
-               assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_read_free(a));
                return;
        }
        assertEqualIntA(a, ARCHIVE_OK, r);
@@ -64,7 +64,7 @@ verify(const char *name)
                assertEqualIntA(a, ARCHIVE_OK,
                    archive_read_next_header(a, &ae));
                if (r != ARCHIVE_OK) {
-                       archive_read_finish(a);
+                       archive_read_free(a);
                        return;
                }
                assertEqualString(n[i], archive_entry_pathname(ae));
@@ -79,7 +79,7 @@ verify(const char *name)
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_TAR_USTAR);
 
        assertEqualInt(ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index 6aefbc2ebc30b00afe7a0670207b59982b4088bb..f35456338fb942381afd0720fe05a10af4ebfd52 100644 (file)
@@ -111,7 +111,7 @@ compat_lzma(const char *name)
        r = archive_read_support_compression_lzma(a);
        if (r == ARCHIVE_WARN) {
                skipping("lzma reading not fully supported on this platform");
-               assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_read_free(a));
                return;
        }
        assertEqualIntA(a, ARCHIVE_OK, archive_read_support_format_all(a));
@@ -135,7 +135,7 @@ compat_lzma(const char *name)
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_TAR_USTAR);
 
        assertEqualInt(ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index ca1506a355ed721b05358f193218b3a88f4a8178..0f2355c14c17b0cfc50eb12a33e0c83c068de769 100644 (file)
@@ -124,5 +124,5 @@ DEFINE_TEST(test_compat_solaris_tar_acl)
 
        /* Close the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
index 8490c9d976596120c8b7150aaf751bbc28408bad..4708cd3e8ec1fa49793938a2e3f931a8bc2fd872 100644 (file)
@@ -93,7 +93,7 @@ test_compat_tar_hardlink_1(void)
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_TAR);
 
        assertEqualInt(ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 DEFINE_TEST(test_compat_tar_hardlink)
index c3b790ffbd2bf74ff24b978ff2b5766a6db2c3d1..e71c06667733932ecfbb16e3f1913939fa73f978 100644 (file)
@@ -50,7 +50,7 @@ compat_xz(const char *name)
        r = archive_read_support_compression_xz(a);
        if (r == ARCHIVE_WARN) {
                skipping("xz reading not fully supported on this platform");
-               assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_read_free(a));
                return;
        }
        assertEqualIntA(a, ARCHIVE_OK, archive_read_support_format_all(a));
@@ -74,7 +74,7 @@ compat_xz(const char *name)
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_TAR_USTAR);
 
        assertEqualInt(ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index d7397efd4c3042f6069967ff9113637328895014..1c5747ddf46a4ae53128f228feac682efdd11acd 100644 (file)
@@ -64,7 +64,7 @@ test_compat_zip_1(void)
 
        assertEqualInt(ARCHIVE_OK, archive_read_close(a));
 finish:
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index 669c6032ffdc1bf403394d0f9a565f6f3b591e82..5495177f207f02ba9a092b33892c614800731e32 100644 (file)
@@ -61,7 +61,7 @@ DEFINE_TEST(test_empty_write)
 
                /* Close out the archive. */
                assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-               assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_write_free(a));
        }
 
        /*
@@ -91,7 +91,7 @@ DEFINE_TEST(test_empty_write)
 
                /* Close out the archive. */
                assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-               assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_write_free(a));
        }
 
        /*
@@ -116,5 +116,5 @@ DEFINE_TEST(test_empty_write)
 
        /* Close out the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 }
index 4b19d2762973dc634ad7ba90c5481d6ca0f93ec2..9f4e9d2ef712cbaa5341479c74c613fb682151fd 100644 (file)
@@ -123,7 +123,7 @@ DEFINE_TEST(test_extattr_freebsd)
                assertEqualIntA(a, ARCHIVE_WARN, archive_write_close(a));
        else
                assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /* Verify the data on disk. */
        assertEqualInt(0, stat("test0", &st));
@@ -166,7 +166,7 @@ DEFINE_TEST(test_extattr_freebsd)
        assertEqualInt(xsize, 5);
        assertEqualMem(xval, "12345", xsize);
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
        archive_entry_free(ae);
 #endif
 }
index e5dede932161a22c5eac3da6da2cc3453986571d..86b4d0ce1aafea1b7c977a326eb157c873c43296 100644 (file)
@@ -97,7 +97,7 @@ DEFINE_TEST(test_fuzz)
                            archive_read_support_format_raw(a));
                        r = archive_read_open_filename(a, filename, 16384);
                        if (r != ARCHIVE_OK) {
-                               archive_read_finish(a);
+                               archive_read_free(a);
                                skipping("Cannot uncompress %s", filename);
                                continue;
                        }
@@ -108,7 +108,7 @@ DEFINE_TEST(test_fuzz)
                        assertEqualIntA(a, ARCHIVE_EOF,
                            archive_read_next_header(a, &ae));
                        assertEqualInt(ARCHIVE_OK,
-                           archive_read_finish(a));
+                           archive_read_free(a));
                        assert(size > 0);
                        failure("Internal buffer is not big enough for "
                            "uncompressed test file: %s", filename);
@@ -156,7 +156,7 @@ DEFINE_TEST(test_fuzz)
                                }
                                archive_read_close(a);
                        }
-                       archive_read_finish(a);
+                       archive_read_free(a);
                }
                free(image);
                free(rawimage);
index 5e118ad8f43be6345c1cdbd84ae367d3b1e713f5..3461535ad96cf0798828d387680e89f90061b1d7 100644 (file)
@@ -79,7 +79,7 @@ DEFINE_TEST(test_open_fd)
 
        /* Close out the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /*
         * Now, read the data back.
@@ -110,7 +110,7 @@ DEFINE_TEST(test_open_fd)
        /* Verify the end of the archive. */
        assertEqualIntA(a, ARCHIVE_EOF, archive_read_next_header(a, &ae));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
        close(fd);
 
 
@@ -124,5 +124,5 @@ DEFINE_TEST(test_open_fd)
        assertEqualIntA(a, ARCHIVE_FATAL,
            archive_read_open_fd(a, 100, 512));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
index 871249d872924044a1c21a9b8d0770761d90668c..5153f5a929ae298a7557897cc8caeb90ff415478 100644 (file)
@@ -67,7 +67,7 @@ DEFINE_TEST(test_open_file)
 
        /* Close out the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
        fclose(f);
 
        /*
@@ -102,7 +102,7 @@ DEFINE_TEST(test_open_file)
        /* Verify the end of the archive. */
        assertEqualIntA(a, ARCHIVE_EOF, archive_read_next_header(a, &ae));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        fclose(f);
 }
index 07224cde135ddc39ca08f0fe710cca5b575d366a..e0c7852299bbd3cbc39c01a4938e3ceba5f46e48 100644 (file)
@@ -62,7 +62,7 @@ DEFINE_TEST(test_open_filename)
 
        /* Close out the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /*
         * Now, read the data back.
@@ -93,7 +93,7 @@ DEFINE_TEST(test_open_filename)
        /* Verify the end of the archive. */
        assertEqualIntA(a, ARCHIVE_EOF, archive_read_next_header(a, &ae));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        /*
         * Verify some of the error handling.
@@ -104,6 +104,6 @@ DEFINE_TEST(test_open_filename)
        assertEqualIntA(a, ARCHIVE_FATAL,
            archive_read_open_filename(a, "nonexistent.tar", 512));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
 }
index 5d1a771cfe1dfd00a511b08b662c48db33ef9cc9..e9d8f1974339a03d66f384127d9f92bf54f928e1 100644 (file)
@@ -77,7 +77,7 @@ test_pax_filename_encoding_1(void)
            " characters in it without generating a warning");
        assertEqualInt(ARCHIVE_OK, archive_read_next_header(a, &entry));
        assertEqualString(filename, archive_entry_pathname(entry));
-       archive_read_finish(a);
+       archive_read_free(a);
 }
 
 /*
@@ -152,7 +152,7 @@ test_pax_filename_encoding_2(void)
        archive_entry_free(entry);
 
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /*
         * Now read the entries back.
@@ -178,7 +178,7 @@ test_pax_filename_encoding_2(void)
        assertEqualString(longname, archive_entry_pathname(entry));
 
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 /*
@@ -278,7 +278,7 @@ test_pax_filename_encoding_3(void)
        archive_entry_free(entry);
 
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /*
         * Now read the entries back.
@@ -322,7 +322,7 @@ test_pax_filename_encoding_3(void)
        assertEqualInt(ARCHIVE_EOF, archive_read_next_header(a, &entry));
 
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 DEFINE_TEST(test_pax_filename_encoding)
index 4e6c610de253b3cd2d38b350e5d884cd255564ff..6ef7277aea07a264be9469aa87b7d969f9f3f1c1 100644 (file)
@@ -55,7 +55,7 @@ DEFINE_TEST(test_read_compress_program)
        assertEqualIntA(a, ARCHIVE_FATAL,
            archive_read_open_memory(a, archive, sizeof(archive)));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        /*
         * If we have "gzip -d", try using that.
@@ -78,7 +78,7 @@ DEFINE_TEST(test_read_compress_program)
        assertEqualInt(archive_compression(a), ARCHIVE_COMPRESSION_PROGRAM);
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_TAR_USTAR);
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index 4ec0e801eca9e037737de56f92dcd0305e791c52..5756d7bfc00043493e7e3a1f8f2568e425286c33 100644 (file)
@@ -73,7 +73,7 @@ DEFINE_TEST(test_read_data_large)
 
        /* Close out the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /* Check that archive_read_data can handle 10*10^6 at a pop. */
        assert((a = archive_read_new()) != NULL);
@@ -86,7 +86,7 @@ DEFINE_TEST(test_read_data_large)
        failure("Read expected 10MB, but data read didn't match what was written");
        assert(0 == memcmp(buff2, buff3, sizeof(buff3)));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        /* Check archive_read_data_into_fd */
        assert((a = archive_read_new()) != NULL);
@@ -102,7 +102,7 @@ DEFINE_TEST(test_read_data_large)
        assert(tmpfilefd != 0);
        assertEqualIntA(a, 0, archive_read_data_into_fd(a, tmpfilefd));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
        close(tmpfilefd);
 
        f = fopen(tmpfilename, "rb");
index d52659bb73b099b10bfc9252a5871b2e9b389d16..b93ef87acac98ec009d7a51c77d1c125ebe2d86e 100644 (file)
@@ -164,7 +164,7 @@ DEFINE_TEST(test_read_disk)
                           &umagic, &uname_lookup, &uname_cleanup));
 
        /* Destroy the archive. */
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        /* Verify our cleanup functions got called. */
        assertEqualInt(gmagic, 0x2468);
index ecca778e2537376ae9306345e98456a9ac4b0d0e..9fe358dce5ebcd96c4a92d7335489437719c90e2 100644 (file)
@@ -76,5 +76,5 @@ DEFINE_TEST(test_read_disk_entry_from_file)
 
        /* Destroy the archive. */
        archive_entry_free(entry);
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
index da8499448ba4203a76f0ad9ca4d9e8312f9c2c22..bf84055a78720c53292ed039e2e2d015cadb9f32 100644 (file)
@@ -112,7 +112,7 @@ DEFINE_TEST(test_read_extract)
        }
        /* Close out the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /* Extract the entries to disk. */
        assert((a = archive_read_new()) != NULL);
@@ -133,7 +133,7 @@ DEFINE_TEST(test_read_extract)
        }
        assertA(ARCHIVE_EOF == archive_read_next_header(a, &ae));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        /* Test the entries on disk. */
        /* This first entry was extracted with ARCHIVE_EXTRACT_PERM,
index 9494dbab6f4ff24fe29e68ac5d32f2552347a750..acb72a1e32cc2cb38f3683ebe0e5c8cebb1f290b 100644 (file)
@@ -31,7 +31,7 @@ DEFINE_TEST(test_read_file_nonexistent)
        assertEqualInt(ARCHIVE_OK, archive_read_support_format_all(a));
        assertEqualInt(ARCHIVE_FATAL,
            archive_read_open_filename(a, "notexistent.tar", 512));
-       archive_read_finish(a);
+       archive_read_free(a);
 }
 
 
index 35939d0711fed31ea33b58e90387d6e3b3e99acc..9094d106a97f074ccc649664df9e713b776298af 100644 (file)
@@ -83,5 +83,5 @@ DEFINE_TEST(test_read_format_ar)
        /* Test EOF */
        assertA(1 == archive_read_next_header(a, &ae));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
index 0d7b79a23a5a0a835ca9b391b575f551c7794634..229758ed60e0a507b2c1b6f90db04ef2a9157a39 100644 (file)
@@ -109,7 +109,7 @@ DEFINE_TEST(test_read_format_cpio_afio)
        assertA(archive_compression(a) == ARCHIVE_COMPRESSION_NONE);
        assertA(archive_format(a) == ARCHIVE_FORMAT_CPIO_AFIO_LARGE);
        assertEqualInt(ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
-       
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
+
        free(p);
 }
index 39a7a3d2f2e8d770fb8bfc94784e41dcedcc5d84..78146ba19a3470eba2a111eb9e8a76aac9a695bd 100644 (file)
@@ -54,7 +54,7 @@ DEFINE_TEST(test_read_format_cpio_bin)
        assertA(archive_compression(a) == ARCHIVE_COMPRESSION_NONE);
        assertA(archive_format(a) == ARCHIVE_FORMAT_CPIO_BIN_LE);
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index 95d9ab2fe82daadeaca6610d5880772d16802e31..5c0765aa947950bca140bb23b3750988ea503f85 100644 (file)
@@ -51,7 +51,7 @@ DEFINE_TEST(test_read_format_cpio_bin_Z)
            archive_format_name(a));
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_CPIO_BIN_LE);
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index 8cd59dc5d01ea134b12e174c24af5974a73fb96b..11f8295649623c2aca491ddfbbaba8abd28e7f9f 100644 (file)
@@ -49,7 +49,7 @@ DEFINE_TEST(test_read_format_cpio_bin_be)
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_CPIO_BIN_BE);
        assertEqualIntA(a, ARCHIVE_EOF, archive_read_next_header(a, &ae));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index d7022c919f73893e6840d086daa18e1d6c865af5..a526ed10a2e18ab48db85e4e00c647074e722fd3 100644 (file)
@@ -52,7 +52,7 @@ DEFINE_TEST(test_read_format_cpio_bin_bz2)
        assert(archive_compression(a) == ARCHIVE_COMPRESSION_BZIP2);
        assert(archive_format(a) == ARCHIVE_FORMAT_CPIO_BIN_LE);
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index 4457fb3c6fffe18fc1affe3fa6b25c17c81c13e9..ecb6bf1205d9d0201f0a2b92a15df9dbf65f4c75 100644 (file)
@@ -42,7 +42,7 @@ DEFINE_TEST(test_read_format_cpio_bin_gz)
        r = archive_read_support_compression_gzip(a);
        if (r == ARCHIVE_WARN) {
                skipping("gzip reading not fully supported on this platform");
-               assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_read_free(a));
                return;
        }
        failure("archive_read_support_compression_gzip");
@@ -55,7 +55,7 @@ DEFINE_TEST(test_read_format_cpio_bin_gz)
            ARCHIVE_COMPRESSION_GZIP);
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_CPIO_BIN_LE);
        assertEqualInt(ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index 035b38856d580ca7022cf89aa19553f0668f228c..0c15de99c0b0e3ff4f49a90eb78d38316250ca19 100644 (file)
@@ -45,7 +45,7 @@ DEFINE_TEST(test_read_format_cpio_bin_lzma)
        r = archive_read_support_compression_lzma(a);
        if (r == ARCHIVE_WARN) {
                skipping("lzma reading not fully supported on this platform");
-               assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_read_free(a));
                return;
        }
        assertEqualIntA(a, ARCHIVE_OK, archive_read_support_format_all(a));
@@ -55,6 +55,6 @@ DEFINE_TEST(test_read_format_cpio_bin_lzma)
        assertEqualInt(archive_compression(a), ARCHIVE_COMPRESSION_LZMA);
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_CPIO_BIN_LE);
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
index 813b343fda08dfe71acf54fe4b94469ad6a430d4..4383e7f512924dc957976900058014c171e76be8 100644 (file)
@@ -55,7 +55,7 @@ DEFINE_TEST(test_read_format_cpio_bin_xz)
        r = archive_read_support_compression_xz(a);
        if (r == ARCHIVE_WARN) {
                skipping("xz reading not fully supported on this platform");
-               assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_read_free(a));
                return;
        }
        assertEqualIntA(a, ARCHIVE_OK, archive_read_support_format_all(a));
@@ -65,6 +65,6 @@ DEFINE_TEST(test_read_format_cpio_bin_xz)
        assertEqualInt(archive_compression(a), ARCHIVE_COMPRESSION_XZ);
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_CPIO_BIN_LE);
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
index 01538b5692b86bb4fb491b7a281cead331dd840b..4d42e1729e60c5756727d6dcfda8ab0377ada679 100644 (file)
@@ -58,7 +58,7 @@ DEFINE_TEST(test_read_format_cpio_odc)
        assertA(archive_compression(a) == ARCHIVE_COMPRESSION_NONE);
        assertA(archive_format(a) == ARCHIVE_FORMAT_CPIO_POSIX);
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index 3b4170cb787c70f086a5370d00e21232f4cfdeeb..9c0b92e00f036609a10aafc647da18b9fcd629d7 100644 (file)
@@ -93,7 +93,7 @@ DEFINE_TEST(test_read_format_cpio_svr4_bzip2_rpm)
         r = archive_read_support_compression_bzip2(a);
        if (r == ARCHIVE_WARN) {
                skipping("bzip2 reading not fully supported on this platform");
-               assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_read_free(a));
                return;
         }
        assertEqualIntA(a, ARCHIVE_OK, r);
@@ -122,6 +122,6 @@ DEFINE_TEST(test_read_format_cpio_svr4_bzip2_rpm)
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_CPIO_SVR4_NOCRC);
  
        assertEqualInt(ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
index 8b19a021b0d0050aa10921afab7f38f52020a413..c81b2e59337020093d0feb38a9fe3d019c201476 100644 (file)
@@ -43,7 +43,7 @@ DEFINE_TEST(test_read_format_cpio_svr4_gzip)
        r = archive_read_support_compression_gzip(a);
        if (r == ARCHIVE_WARN) {
                skipping("gzip reading not fully supported on this platform");
-               assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_read_free(a));
                return;
        }
        assertEqualInt(ARCHIVE_OK, archive_read_support_format_all(a));
@@ -55,7 +55,7 @@ DEFINE_TEST(test_read_format_cpio_svr4_gzip)
        assertEqualInt(archive_format(a),
            ARCHIVE_FORMAT_CPIO_SVR4_NOCRC);
        assertEqualInt(ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index eb8a38d9df35d0d958a7fa2650f9bd2f055851e8..1be66670bbf067fd9145a4d1e6ed4cd2f9f6b169 100644 (file)
@@ -93,7 +93,7 @@ DEFINE_TEST(test_read_format_cpio_svr4_gzip_rpm)
         r = archive_read_support_compression_gzip(a);
        if (r == ARCHIVE_WARN) {
                skipping("gzip reading not fully supported on this platform");
-               assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_read_free(a));
                return;
         }
        assertEqualIntA(a, ARCHIVE_OK, r);
@@ -122,6 +122,6 @@ DEFINE_TEST(test_read_format_cpio_svr4_gzip_rpm)
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_CPIO_SVR4_NOCRC);
  
        assertEqualInt(ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
index 59f920238bc2c3ffb808685c7d114e4b2bbc9e49..912824c49d72ff376ce4e8481a76cf01825804c8 100644 (file)
@@ -52,7 +52,7 @@ DEFINE_TEST(test_read_format_cpio_svr4c_Z)
        failure("archive_format_name(a)=\"%s\"", archive_format_name(a));
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_CPIO_SVR4_CRC);
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index 0dc91ac8b3594c707e20a544d3a41a99e15d4553..c16b6bb9fbe3727a1ccc8776fd647ebbffd42303 100644 (file)
@@ -39,5 +39,5 @@ DEFINE_TEST(test_read_format_empty)
        assertA(archive_compression(a) == ARCHIVE_COMPRESSION_NONE);
        assertA(archive_format(a) == ARCHIVE_FORMAT_EMPTY);
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
index 3071b1d0b497746f169c34f65dbea84a55ea14cf..4140a8a8781694f581bf13d9aa8db77738a013cb 100644 (file)
@@ -43,7 +43,7 @@ DEFINE_TEST(test_read_format_gtar_gz)
        r = archive_read_support_compression_gzip(a);
        if (r == ARCHIVE_WARN) {
                skipping("gzip reading not fully supported on this platform");
-               assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_read_free(a));
                return;
        }
        assertEqualInt(ARCHIVE_OK, archive_read_support_format_all(a));
@@ -54,7 +54,7 @@ DEFINE_TEST(test_read_format_gtar_gz)
            ARCHIVE_COMPRESSION_GZIP);
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_TAR_GNUTAR);
        assertEqualInt(ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index ab8e5ff594c1e55af2c258c7cf56605d4e485fe7..9e57771737e0916eb920ffd62bb7a12921611a30 100644 (file)
@@ -49,7 +49,7 @@ DEFINE_TEST(test_read_format_gtar_lzma)
        r = archive_read_support_compression_lzma(a);
        if (r == ARCHIVE_WARN) {
                skipping("lzma reading not fully supported on this platform");
-               assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_read_free(a));
                return;
        }
 
@@ -68,7 +68,7 @@ DEFINE_TEST(test_read_format_gtar_lzma)
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_TAR_GNUTAR);
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
 finish:
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index 5a5ed2504268039eebf9dcbd34c467417bacc3a7..8ac5946712a2c8242806245917888547a7fd1155 100644 (file)
@@ -195,7 +195,7 @@ verify_archive_file(const char *name, struct archive_contents *ac)
                struct contents *cts = ac->contents;
 
                if (!assertEqualIntA(a, 0, archive_read_next_header(a, &ae))) {
-                       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+                       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
                        return;
                }
                failure("Name mismatch in archive %s", name);
@@ -233,7 +233,7 @@ verify_archive_file(const char *name, struct archive_contents *ac)
                                        failure("%s: Unexpected trailing data",
                                            name);
                                        assert(actual.o <= expect.o);
-                                       archive_read_finish(a);
+                                       archive_read_free(a);
                                        return;
                                }
                                actual.d++;
@@ -255,7 +255,7 @@ verify_archive_file(const char *name, struct archive_contents *ac)
        assertEqualIntA(a, ARCHIVE_EOF, err);
 
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index 822b969e335d1375fa62746282d928d65434527d..4b7712d8ce933a8f1ba562ada1ec61f81145f9ff 100644 (file)
@@ -46,7 +46,7 @@ DEFINE_TEST(test_read_format_iso_gz)
            ARCHIVE_COMPRESSION_COMPRESS);
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_ISO9660);
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index da4f6124e9d1785c742e88cf542e84f885c5af07..6a967f05894f55995f5e308e4686344eb413de31 100644 (file)
@@ -88,7 +88,7 @@ DEFINE_TEST(test_read_format_iso_multi_extent)
 
        /* Close the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index 3efe2a38b95f89026bcfb859f4d369f67649ad95..15479c64090a2deec4bde032dc4835901751cd7b 100644 (file)
@@ -129,6 +129,6 @@ DEFINE_TEST(test_read_format_isojoliet_bz2)
 
        /* Close the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
index e5a8d4eed0b9a657474f80ae31a8b50136a08b15..d8e520e4e170f104b9b892deb53fd9b678848829 100644 (file)
@@ -136,6 +136,6 @@ DEFINE_TEST(test_read_format_isojoliet_long)
 
        /* Close the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
index 42fe9a847af69a0b455cdd7d377fb910cb92898b..3c22fce117f38cd99ecedcd0ac6711f921c13646 100644 (file)
@@ -154,6 +154,6 @@ DEFINE_TEST(test_read_format_isojoliet_rr)
 
        /* Close the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
index 029d3d2f81111b5678b43bd6e176cf06029bccaa..f3fc983825fdbde06d46ac80a17f3f055bdb905f 100644 (file)
@@ -197,7 +197,7 @@ DEFINE_TEST(test_read_format_isorr_bz2)
 
        /* Close the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index 22dd12d516f4fe9a3fb46d9194cea41343f4706c..84b2e7743989ed12ba56133d277d8c742436881a 100644 (file)
@@ -217,7 +217,7 @@ DEFINE_TEST(test_read_format_isorr_ce)
 
        /* Close the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index ec665aeeae22519f4aa25624fea1c1b96fdb0b9e..28c2bacdd2115a24768650cc2e732f699fbce31f 100644 (file)
@@ -198,7 +198,7 @@ DEFINE_TEST(test_read_format_isorr_new_bz2)
 
        /* Close the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index ef300226eedb75045e41b42c148a4bff7f6aa2e6..da33e58acfac5e3322bf323345a863b0fca74d0e 100644 (file)
@@ -264,7 +264,7 @@ DEFINE_TEST(test_read_format_isorr_rr_moved)
 
        /* Close the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index 7fcceb9cd4093181f11bf5cec6436ebee98fb9b4..cd07404490e72de354d689281b7d62949e4025df 100644 (file)
@@ -181,7 +181,7 @@ DEFINE_TEST(test_read_format_isozisofs_bz2)
 
        /* Close the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index ce6e92086dc0a0a46ad50e1799ac158b733be8ac..e3a3dd2815d94d62a545fcd4ab66c97cb436f9f9 100644 (file)
@@ -106,7 +106,7 @@ test_read_format_mtree1(void)
 
        assertEqualIntA(a, ARCHIVE_EOF, archive_read_next_header(a, &ae));
        assertEqualInt(ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 static void
@@ -131,7 +131,7 @@ test_read_format_mtree2(void)
        assertEqualInt(archive_entry_filetype(ae), AE_IFDIR);
        assertEqualIntA(a, ARCHIVE_EOF, archive_read_next_header(a, &ae));
        assertEqualInt(ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index af70b366308551dc38f354b5dfab019c800c4c47..54f6fcd0926a4964e7feb1011ff1ee3d3485e3f6 100644 (file)
@@ -60,7 +60,7 @@ DEFINE_TEST(test_read_format_pax_bz2)
        assertEqualInt(archive_compression(a), ARCHIVE_COMPRESSION_BZIP2);
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_TAR_PAX_INTERCHANGE);
        assertEqualIntA(a,ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index cd5f00ee1bf8fa02111bdc39bf4fb803a30837c0..a21e4ea960b205947ffcc05307f1712d36632c05 100644 (file)
@@ -59,7 +59,7 @@ DEFINE_TEST(test_read_format_raw)
        /* Test EOF */
        assertEqualIntA(a, ARCHIVE_EOF, archive_read_next_header(a, &ae));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
 
        /* Second, try the same with a compressed file. */
@@ -85,5 +85,5 @@ DEFINE_TEST(test_read_format_raw)
        /* Test EOF */
        assertEqualIntA(a, ARCHIVE_EOF, archive_read_next_header(a, &ae));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
index a1a48f5f9ac660e9b813ab1c1405d08237820607..a820092755e75d54d19c4d46d3e1709a799745a6 100644 (file)
@@ -76,7 +76,7 @@ static void verifyEmpty(void)
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_TAR);
 
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 /* Single entry with a hardlink. */
@@ -444,7 +444,7 @@ static void verify(unsigned char *d, size_t s,
        f(ae);
 
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
        free(buff);
 }
 
index 467284076187e223fe87016a32c00357136ad6b8..5832fc8bfab726033f0e3bbbf95c8004acaae99e 100644 (file)
@@ -58,5 +58,5 @@ DEFINE_TEST(test_read_format_tar_empty_filename)
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_TAR_USTAR);
 
        assertEqualInt(ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
index 06d8cad4798310069c4c9e318c7a390e48ffe737..f64aa7c452915eac797e0a47bb449531e5628640 100644 (file)
@@ -43,7 +43,7 @@ DEFINE_TEST(test_read_format_tbz)
        r = archive_read_support_compression_bzip2(a);
        if (r != ARCHIVE_OK) {
                skipping("Bzip2 support");
-               archive_read_finish(a);
+               archive_read_free(a);
                return;
        }
        assertEqualIntA(a, ARCHIVE_OK, archive_read_support_format_all(a));
@@ -53,7 +53,7 @@ DEFINE_TEST(test_read_format_tbz)
        assertEqualInt(archive_compression(a), ARCHIVE_COMPRESSION_BZIP2);
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_TAR_USTAR);
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index f411b43380262f665e9e556ada430ba63194e98f..e19853664388a232d00300ed43091960fb49f806 100644 (file)
@@ -43,7 +43,7 @@ DEFINE_TEST(test_read_format_tgz)
        r = archive_read_support_compression_gzip(a);
        if (r == ARCHIVE_WARN) {
                skipping("gzip reading not fully supported on this platform");
-               assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_read_free(a));
                return;
        }
        assertEqualInt(ARCHIVE_OK, archive_read_support_format_all(a));
@@ -54,7 +54,7 @@ DEFINE_TEST(test_read_format_tgz)
            ARCHIVE_COMPRESSION_GZIP);
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_TAR_USTAR);
        assertEqualInt(ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK,archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK,archive_read_free(a));
 }
 
 
index 7dd09a0c518ebe2874a57ee5f1fc64773d522567..ef1c0ab3c1c87811a66ec0f30f908557899cff81 100644 (file)
@@ -46,7 +46,7 @@ DEFINE_TEST(test_read_format_tlz)
        r = archive_read_support_compression_lzma(a);
        if (r == ARCHIVE_WARN) {
                skipping("lzma reading not fully supported on this platform");
-               assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_read_free(a));
                return;
        }
        assertEqualIntA(a, ARCHIVE_OK, archive_read_support_format_all(a));
@@ -56,5 +56,5 @@ DEFINE_TEST(test_read_format_tlz)
        assertEqualInt(archive_compression(a), ARCHIVE_COMPRESSION_LZMA);
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_TAR_USTAR);
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
index acff175c56f7b854f05c0d01df6a0befb17142a1..29fdd88c4bed50091051ceec55b3e9b4c2a986c8 100644 (file)
@@ -49,7 +49,7 @@ DEFINE_TEST(test_read_format_txz)
        r = archive_read_support_compression_xz(a);
        if (r == ARCHIVE_WARN) {
                skipping("xz reading not fully supported on this platform");
-               assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_read_free(a));
                return;
        }
        assertEqualIntA(a, ARCHIVE_OK, archive_read_support_format_all(a));
@@ -59,5 +59,5 @@ DEFINE_TEST(test_read_format_txz)
        assertEqualInt(archive_compression(a), ARCHIVE_COMPRESSION_XZ);
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_TAR_USTAR);
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
index e477fb7487fa6e54e4398177d348d95565c70463..b6a7bc1409aa9e3b57eb64ae2114cac283733561 100644 (file)
@@ -51,7 +51,7 @@ DEFINE_TEST(test_read_format_tz)
        failure("archive_format_name(a)=\"%s\"", archive_format_name(a));
        assertEqualInt(archive_format(a), ARCHIVE_FORMAT_TAR_USTAR);
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index 872918a55c27ecc79dd15a87ad895cdaf6c798a4..7d6ad4a7058a0e0ada292c72a97dab671c4015e6 100644 (file)
@@ -636,7 +636,7 @@ static void verify(unsigned char *d, size_t s,
                 * This filter won't be used this test.  */
                if (ARCHIVE_OK != archive_read_support_compression_bzip2(a)) {
                        skipping("Unsupported bzip2");
-                       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+                       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
                        return;
                }
                break;
@@ -649,7 +649,7 @@ static void verify(unsigned char *d, size_t s,
        r = archive_read_support_format_xar(a);
        if (r == ARCHIVE_WARN) {
                skipping("xar reading not fully supported on this platform");
-               assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_read_free(a));
                return;
        }
        assert((buff = malloc(100000)) != NULL);
@@ -676,7 +676,7 @@ static void verify(unsigned char *d, size_t s,
        assertEqualInt(ARCHIVE_EOF, archive_read_next_header(a, &ae));
 
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
        free(buff);
 }
 
index 00a40bc123aa599cb7eabbb74cf8b90212267aa0..a4d96f868adf5facc6a6ff15cbb2ec519f15234a 100644 (file)
@@ -82,7 +82,7 @@ DEFINE_TEST(test_read_format_zip)
        assertA(archive_format(a) == ARCHIVE_FORMAT_ZIP);
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
 finish:
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 
index 6083aa519cb9db4a8a3887d1e999c191286483e3..342876fd2c8184428e41295560cd1e375072b5c9 100644 (file)
@@ -58,7 +58,7 @@ DEFINE_TEST(test_read_large)
        assertA(0 == archive_write_header(a, entry));
        archive_entry_free(entry);
        assertA((int)sizeof(testdata) == archive_write_data(a, testdata, sizeof(testdata)));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        assert(NULL != (a = archive_read_new()));
        assertA(0 == archive_read_support_format_all(a));
@@ -66,7 +66,7 @@ DEFINE_TEST(test_read_large)
        assertA(0 == archive_read_open_memory(a, buff, sizeof(buff)));
        assertA(0 == archive_read_next_header(a, &entry));
        assertA(0 == archive_read_data_into_buffer(a, testdatacopy, sizeof(testdatacopy)));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
        assert(0 == memcmp(testdata, testdatacopy, sizeof(testdata)));
 
 
@@ -83,7 +83,7 @@ DEFINE_TEST(test_read_large)
        assert(0 < tmpfilefd);
        assertA(0 == archive_read_data_into_fd(a, tmpfilefd));
        close(tmpfilefd);
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        f = fopen(tmpfilename, "rb");
        assertEqualInt(sizeof(testdatacopy),
index 740d9bd7ba8e73938649b9522252f649fc9c93d0..372adff2a96326ada98fbbf067127a05cea459cf 100644 (file)
@@ -61,7 +61,7 @@ DEFINE_TEST(test_read_pax_truncated)
 
        /* Close out the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /* Now, read back a truncated version of the archive and
         * verify that we get an appropriate error. */
@@ -105,7 +105,7 @@ DEFINE_TEST(test_read_pax_truncated)
                }
        wrap_up:
                assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-               assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_read_free(a));
        }
 
 
@@ -146,7 +146,7 @@ DEFINE_TEST(test_read_pax_truncated)
                }
        wrap_up2:
                assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-               assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_read_free(a));
        }
 
        /* Now, damage the archive in various ways and test the responses. */
@@ -162,7 +162,7 @@ DEFINE_TEST(test_read_pax_truncated)
        assertA(0 == archive_read_open_memory(a, buff2, used));
        assertEqualIntA(a, ARCHIVE_WARN, archive_read_next_header(a, &ae));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        /* Damage the size field in the pax attributes. */
        memcpy(buff2, buff, buff_size);
@@ -173,7 +173,7 @@ DEFINE_TEST(test_read_pax_truncated)
        assertA(0 == archive_read_open_memory(a, buff2, used));
        assertEqualIntA(a, ARCHIVE_WARN, archive_read_next_header(a, &ae));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        /* Damage the size field in the pax attributes. */
        memcpy(buff2, buff, buff_size);
@@ -186,7 +186,7 @@ DEFINE_TEST(test_read_pax_truncated)
        assertA(0 == archive_read_open_memory(a, buff2, used));
        assertEqualIntA(a, ARCHIVE_WARN, archive_read_next_header(a, &ae));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        /* Damage the size field in the pax attributes. */
        memcpy(buff2, buff, buff_size);
@@ -200,7 +200,7 @@ DEFINE_TEST(test_read_pax_truncated)
        assertA(0 == archive_read_open_memory(a, buff2, used));
        assertEqualIntA(a, ARCHIVE_WARN, archive_read_next_header(a, &ae));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        /* Damage the size field in the pax attributes. */
        memcpy(buff2, buff, buff_size);
@@ -212,7 +212,7 @@ DEFINE_TEST(test_read_pax_truncated)
        assertA(0 == archive_read_open_memory(a, buff2, used));
        assertEqualIntA(a, ARCHIVE_WARN, archive_read_next_header(a, &ae));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        /* Damage the size field in the pax attributes. */
        memcpy(buff2, buff, buff_size);
@@ -223,7 +223,7 @@ DEFINE_TEST(test_read_pax_truncated)
        assertA(0 == archive_read_open_memory(a, buff2, used));
        assertEqualIntA(a, ARCHIVE_WARN, archive_read_next_header(a, &ae));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        /* Damage the ustar header. */
        memcpy(buff2, buff, buff_size);
@@ -234,7 +234,7 @@ DEFINE_TEST(test_read_pax_truncated)
        assertA(0 == archive_read_open_memory(a, buff2, used));
        assertEqualIntA(a, ARCHIVE_FATAL, archive_read_next_header(a, &ae));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        /*
         * TODO: Damage the ustar header in various ways and fixup the
index f786f6d4ffc80ea1aedbab11716908918d6402d3..cdaa783d6369472b61ed77bceb857a53565c2445 100644 (file)
@@ -59,7 +59,7 @@ DEFINE_TEST(test_read_position)
                    == (size_t)archive_write_data(a, nulls, sizeof(nulls)));
        }
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /* Read the archive back. */
        assert(NULL != (a = archive_read_new()));
@@ -90,5 +90,5 @@ DEFINE_TEST(test_read_position)
        assert(read_position == (intmax_t)archive_read_header_position(a));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
        assert(read_position == (intmax_t)archive_read_header_position(a));
-       archive_read_finish(a);
+       archive_read_free(a);
 }
index 470801222af713dd7614ffb0433725b06f61fa83..c7d20c0bd08c5c8f35627db7ad2c3ceae06fa3f8 100644 (file)
@@ -56,7 +56,7 @@ DEFINE_TEST(test_read_truncated)
 
        /* Close out the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /* Now, read back a truncated version of the archive and
         * verify that we get an appropriate error. */
@@ -93,7 +93,7 @@ DEFINE_TEST(test_read_truncated)
                }
        wrap_up:
                assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-               assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_read_free(a));
        }
 
 
@@ -132,6 +132,6 @@ DEFINE_TEST(test_read_truncated)
                }
        wrap_up2:
                assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-               assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_read_free(a));
        }
 }
index a5de09af7406143c3c34f96a21f3e829c255cc1a..a0979a81041f6fa7191c78e1cca624613bb5498d 100644 (file)
@@ -119,7 +119,7 @@ test_read_uu_sub(const char *uudata, size_t uusize)
                    archive_format_name(a));
                assertEqualInt(archive_format(a), ARCHIVE_FORMAT_TAR_USTAR);
                assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-               assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_read_free(a));
        }
        free(buff);
 }
index 3a5486f23189cfaaca5f167a64f06d00029a7a59..c40ff9760e221da6c136bbd94407fad4a3dd74b1 100644 (file)
@@ -333,5 +333,5 @@ DEFINE_TEST(test_sparse_basic)
        strcpy(p, "/file3");
        verify_sparse_file(a, path, sparse_file3, 0);
 
-       archive_read_finish(a);
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
index 9ca4d6eea1f5a6b17f928e65ea277982f5bd6516..aead684c4955b13e65163d79aeea87d0b893a248 100644 (file)
@@ -101,7 +101,7 @@ test_filename(const char *prefix, int dlen, int flen)
 
        /* Close out the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /*
         * Now, read the data back.
@@ -135,7 +135,7 @@ test_filename(const char *prefix, int dlen, int flen)
        /* Verify the end of the archive. */
        assert(1 == archive_read_next_header(a, &ae));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 DEFINE_TEST(test_tar_filenames)
index 280fea2f25410103153c9bbccf690b9db5df51a9..30f7efe49c2f8c9183ecf771931220737eeec8d8 100644 (file)
@@ -256,7 +256,7 @@ DEFINE_TEST(test_tar_large)
 
        /* Close out the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /*
         * Open the same archive for reading.
@@ -282,7 +282,7 @@ DEFINE_TEST(test_tar_large)
 
        /* Close out the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        free(memdata.buff);
        free(filedata);
index 9970367030aa60cd684217cd4c5ebed9ff9b3a25..ffd263c03a7f086151caf3e57c75bf6dfb2de015 100644 (file)
@@ -111,7 +111,7 @@ test_filename(const char *prefix, int dlen, int flen)
 
        /* Close out the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /*
         * Now, read the data back.
@@ -153,7 +153,7 @@ test_filename(const char *prefix, int dlen, int flen)
        failure("This fails if entries were written that should not have been written.  dlen=%d, flen=%d", dlen, flen);
        assertEqualInt(1, archive_read_next_header(a, &ae));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 DEFINE_TEST(test_ustar_filenames)
index 2842e07c5be1c62de79a23a36a660db56a3d13ec..aebcb76f206081f26baaf0ebae28ec9461ab06eb 100644 (file)
@@ -68,7 +68,7 @@ DEFINE_TEST(test_write_compress)
 
 
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /*
         * Now, read the data back.
@@ -87,7 +87,7 @@ DEFINE_TEST(test_write_compress)
                assertEqualInt((int)datasize, archive_entry_size(ae));
        }
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        free(data);
        free(buff);
index c0c249bce5fd7775db692bd5bb7b9ef650579b48..00ad5ca7fe50ff9b9c7d2e75632eb17f9ea304df 100644 (file)
@@ -58,7 +58,7 @@ DEFINE_TEST(test_write_compress_bzip2)
        r = archive_write_set_compression_bzip2(a);
        if (r == ARCHIVE_FATAL) {
                skipping("bzip2 writing not supported on this platform");
-               assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_write_free(a));
                return;
        }
        assertEqualIntA(a, ARCHIVE_OK,
@@ -80,7 +80,7 @@ DEFINE_TEST(test_write_compress_bzip2)
        }
        archive_entry_free(ae);
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        assert((a = archive_read_new()) != NULL);
        assertEqualIntA(a, ARCHIVE_OK, archive_read_support_format_all(a));
@@ -94,7 +94,7 @@ DEFINE_TEST(test_write_compress_bzip2)
                assertEqualInt((int)datasize, archive_entry_size(ae));
        }
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        /*
         * Repeat the cycle again, this time setting some compression
@@ -125,7 +125,7 @@ DEFINE_TEST(test_write_compress_bzip2)
                archive_entry_free(ae);
        }
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /* Curiously, this test fails; the test data above compresses
         * better at default compression than at level 9. */
@@ -147,7 +147,7 @@ DEFINE_TEST(test_write_compress_bzip2)
                assertEqualInt((int)datasize, archive_entry_size(ae));
        }
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        /*
         * Repeat again, with much lower compression.
@@ -173,7 +173,7 @@ DEFINE_TEST(test_write_compress_bzip2)
                archive_entry_free(ae);
        }
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /* Level 0 really does result in larger data. */
        failure("Compression-level=0 wrote %d bytes; default wrote %d bytes",
@@ -192,7 +192,7 @@ DEFINE_TEST(test_write_compress_bzip2)
                assertEqualInt((int)datasize, archive_entry_size(ae));
        }
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        /*
         * Test various premature shutdown scenarios to make sure we
@@ -200,25 +200,25 @@ DEFINE_TEST(test_write_compress_bzip2)
         */
        assert((a = archive_write_new()) != NULL);
        assertEqualIntA(a, ARCHIVE_OK, archive_write_set_compression_bzip2(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        assert((a = archive_write_new()) != NULL);
        assertEqualIntA(a, ARCHIVE_OK, archive_write_set_compression_bzip2(a));
        assertEqualInt(ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        assert((a = archive_write_new()) != NULL);
        assertEqualIntA(a, ARCHIVE_OK, archive_write_set_format_ustar(a));
        assertEqualIntA(a, ARCHIVE_OK, archive_write_set_compression_bzip2(a));
        assertEqualInt(ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        assert((a = archive_write_new()) != NULL);
        assertEqualIntA(a, ARCHIVE_OK, archive_write_set_format_ustar(a));
        assertEqualIntA(a, ARCHIVE_OK, archive_write_set_compression_bzip2(a));
        assertEqualIntA(a, ARCHIVE_OK, archive_write_open_memory(a, buff, buffsize, &used2));
        assertEqualInt(ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /*
         * Clean up.
index 1666472871c381bbc1d48a5ac1e88b71a6d39624..47a636c9db369010584944c07e1bfc5e25ec21b8 100644 (file)
@@ -58,7 +58,7 @@ DEFINE_TEST(test_write_compress_gzip)
        r = archive_write_set_compression_gzip(a);
        if (r == ARCHIVE_FATAL) {
                skipping("gzip writing not supported on this platform");
-               assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_write_free(a));
                return;
        }
        assertEqualIntA(a, ARCHIVE_OK,
@@ -80,7 +80,7 @@ DEFINE_TEST(test_write_compress_gzip)
        }
        archive_entry_free(ae);
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        assert((a = archive_read_new()) != NULL);
        assertEqualIntA(a, ARCHIVE_OK, archive_read_support_format_all(a));
@@ -103,7 +103,7 @@ DEFINE_TEST(test_write_compress_gzip)
                }
                assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
        }
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        /*
         * Repeat the cycle again, this time setting some compression
@@ -134,7 +134,7 @@ DEFINE_TEST(test_write_compress_gzip)
                archive_entry_free(ae);
        }
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /* Curiously, this test fails; the test data above compresses
         * better at default compression than at level 9. */
@@ -164,7 +164,7 @@ DEFINE_TEST(test_write_compress_gzip)
                }
                assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
        }
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        /*
         * Repeat again, with much lower compression.
@@ -190,7 +190,7 @@ DEFINE_TEST(test_write_compress_gzip)
                archive_entry_free(ae);
        }
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /* Level 0 really does result in larger data. */
        failure("Compression-level=0 wrote %d bytes; default wrote %d bytes",
@@ -216,7 +216,7 @@ DEFINE_TEST(test_write_compress_gzip)
                }
                assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
        }
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        /*
         * Test various premature shutdown scenarios to make sure we
@@ -224,25 +224,25 @@ DEFINE_TEST(test_write_compress_gzip)
         */
        assert((a = archive_write_new()) != NULL);
        assertEqualIntA(a, ARCHIVE_OK, archive_write_set_compression_gzip(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        assert((a = archive_write_new()) != NULL);
        assertEqualIntA(a, ARCHIVE_OK, archive_write_set_compression_gzip(a));
        assertEqualInt(ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        assert((a = archive_write_new()) != NULL);
        assertEqualIntA(a, ARCHIVE_OK, archive_write_set_format_ustar(a));
        assertEqualIntA(a, ARCHIVE_OK, archive_write_set_compression_gzip(a));
        assertEqualInt(ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        assert((a = archive_write_new()) != NULL);
        assertEqualIntA(a, ARCHIVE_OK, archive_write_set_format_ustar(a));
        assertEqualIntA(a, ARCHIVE_OK, archive_write_set_compression_gzip(a));
        assertEqualIntA(a, ARCHIVE_OK, archive_write_open_memory(a, buff, buffsize, &used2));
        assertEqualInt(ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /*
         * Clean up.
index af172a8f3dc0db0120f1f812cf2a377052f91992..de663b05bf02552d1d61c56f2ec4d26c96173c1d 100644 (file)
@@ -57,7 +57,7 @@ DEFINE_TEST(test_write_compress_lzma)
        r = archive_write_set_compression_lzma(a);
        if (r == ARCHIVE_FATAL) {
                skipping("lzma writing not supported on this platform");
-               assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_write_free(a));
                return;
        }
        assertEqualIntA(a, ARCHIVE_OK,
@@ -79,7 +79,7 @@ DEFINE_TEST(test_write_compress_lzma)
        }
        archive_entry_free(ae);
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        assert((a = archive_read_new()) != NULL);
        assertEqualIntA(a, ARCHIVE_OK, archive_read_support_format_all(a));
@@ -102,7 +102,7 @@ DEFINE_TEST(test_write_compress_lzma)
                }
                assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
        }
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        /*
         * Repeat the cycle again, this time setting some compression
@@ -133,7 +133,7 @@ DEFINE_TEST(test_write_compress_lzma)
                archive_entry_free(ae);
        }
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
 
        assert((a = archive_read_new()) != NULL);
@@ -157,7 +157,7 @@ DEFINE_TEST(test_write_compress_lzma)
                }
                assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
        }
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        /*
         * Repeat again, with much lower compression.
@@ -183,7 +183,7 @@ DEFINE_TEST(test_write_compress_lzma)
                archive_entry_free(ae);
        }
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /* Level 0 really does result in larger data. */
        failure("Compression-level=0 wrote %d bytes; default wrote %d bytes",
@@ -209,7 +209,7 @@ DEFINE_TEST(test_write_compress_lzma)
                }
                assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
        }
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        /*
         * Test various premature shutdown scenarios to make sure we
@@ -217,25 +217,25 @@ DEFINE_TEST(test_write_compress_lzma)
         */
        assert((a = archive_write_new()) != NULL);
        assertEqualIntA(a, ARCHIVE_OK, archive_write_set_compression_lzma(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        assert((a = archive_write_new()) != NULL);
        assertEqualIntA(a, ARCHIVE_OK, archive_write_set_compression_lzma(a));
        assertEqualInt(ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        assert((a = archive_write_new()) != NULL);
        assertEqualIntA(a, ARCHIVE_OK, archive_write_set_format_ustar(a));
        assertEqualIntA(a, ARCHIVE_OK, archive_write_set_compression_lzma(a));
        assertEqualInt(ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        assert((a = archive_write_new()) != NULL);
        assertEqualIntA(a, ARCHIVE_OK, archive_write_set_format_ustar(a));
        assertEqualIntA(a, ARCHIVE_OK, archive_write_set_compression_lzma(a));
        assertEqualIntA(a, ARCHIVE_OK, archive_write_open_memory(a, buff, buffsize, &used2));
        assertEqualInt(ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /*
         * Clean up.
index 4593610eabec0e44ccf54c7578c71307774f2597..304f4051f3546d2380582e52653a5191712b3315 100644 (file)
@@ -49,7 +49,7 @@ DEFINE_TEST(test_write_compress_program)
        if (r == ARCHIVE_FATAL) {
                skipping("Write compression via external "
                    "program unsupported on this platform");
-               archive_write_finish(a);
+               archive_write_free(a);
                return;
        }
        assertA(0 == archive_write_set_bytes_per_block(a, blocksize));
@@ -73,7 +73,7 @@ DEFINE_TEST(test_write_compress_program)
 
        /* Close out the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /*
         * Now, read the data back through the built-in gzip support.
@@ -88,13 +88,13 @@ DEFINE_TEST(test_write_compress_program)
        if (r != ARCHIVE_OK && !canGunzip()) {
                skipping("No libz and no gunzip program, "
                    "unable to verify gzip compression");
-               assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_read_free(a));
                return;
        }
        assertEqualIntA(a, ARCHIVE_OK, archive_read_open_memory(a, buff, used));
 
        if (!assertEqualIntA(a, ARCHIVE_OK, archive_read_next_header(a, &ae))) {
-               archive_read_finish(a);
+               archive_read_free(a);
                return;
        }
 
@@ -110,5 +110,5 @@ DEFINE_TEST(test_write_compress_program)
        /* Verify the end of the archive. */
        assertEqualIntA(a, ARCHIVE_EOF, archive_read_next_header(a, &ae));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
index caa52f98ccf983dddd54f86b4eda56a22da4643f..2f32df27f2f37ce48970ccdb0437d554ec454e8d 100644 (file)
@@ -58,7 +58,7 @@ DEFINE_TEST(test_write_compress_xz)
        r = archive_write_set_compression_xz(a);
        if (r == ARCHIVE_FATAL) {
                skipping("xz writing not supported on this platform");
-               assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_write_free(a));
                return;
        }
        assertEqualIntA(a, ARCHIVE_OK,
@@ -80,7 +80,7 @@ DEFINE_TEST(test_write_compress_xz)
        }
        archive_entry_free(ae);
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        assert((a = archive_read_new()) != NULL);
        assertEqualIntA(a, ARCHIVE_OK, archive_read_support_format_all(a));
@@ -103,7 +103,7 @@ DEFINE_TEST(test_write_compress_xz)
                }
                assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
        }
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        /*
         * Repeat the cycle again, this time setting some compression
@@ -134,7 +134,7 @@ DEFINE_TEST(test_write_compress_xz)
                archive_entry_free(ae);
        }
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /* Curiously, this test fails; the test data above compresses
         * better at default compression than at level 9. */
@@ -165,7 +165,7 @@ DEFINE_TEST(test_write_compress_xz)
                }
                assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
        }
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        /*
         * Repeat again, with much lower compression.
@@ -191,7 +191,7 @@ DEFINE_TEST(test_write_compress_xz)
                archive_entry_free(ae);
        }
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /* Level 0 really does result in larger data. */
        failure("Compression-level=0 wrote %d bytes; default wrote %d bytes",
@@ -217,7 +217,7 @@ DEFINE_TEST(test_write_compress_xz)
                }
                assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
        }
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        /*
         * Test various premature shutdown scenarios to make sure we
@@ -225,25 +225,25 @@ DEFINE_TEST(test_write_compress_xz)
         */
        assert((a = archive_write_new()) != NULL);
        assertEqualIntA(a, ARCHIVE_OK, archive_write_set_compression_xz(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        assert((a = archive_write_new()) != NULL);
        assertEqualIntA(a, ARCHIVE_OK, archive_write_set_compression_xz(a));
        assertEqualInt(ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        assert((a = archive_write_new()) != NULL);
        assertEqualIntA(a, ARCHIVE_OK, archive_write_set_format_ustar(a));
        assertEqualIntA(a, ARCHIVE_OK, archive_write_set_compression_xz(a));
        assertEqualInt(ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        assert((a = archive_write_new()) != NULL);
        assertEqualIntA(a, ARCHIVE_OK, archive_write_set_format_ustar(a));
        assertEqualIntA(a, ARCHIVE_OK, archive_write_set_compression_xz(a));
        assertEqualIntA(a, ARCHIVE_OK, archive_write_open_memory(a, buff, buffsize, &used2));
        assertEqualInt(ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /*
         * Clean up.
index 23d5d5a98302870b16cd9645d1978508ed5b3837..9a4475599d4f1e41dc726a80c398ee034b1ab180 100644 (file)
@@ -45,7 +45,7 @@ static void create(struct archive_entry *ae, const char *msg)
        failure("%s", msg);
        assertEqualIntA(ad, 0, archive_write_header(ad, ae));
        assertEqualIntA(ad, 0, archive_write_finish_entry(ad));
-       assertEqualInt(0, archive_write_finish(ad));
+       assertEqualInt(0, archive_write_free(ad));
 
        /* Test the entries on disk. */
        assert(0 == stat(archive_entry_pathname(ae), &st));
@@ -92,7 +92,7 @@ static void create_reg_file(struct archive_entry *ae, const char *msg)
        assertEqualIntA(ad, 0, archive_write_header(ad, ae));
        assertEqualInt(sizeof(data), archive_write_data(ad, data, sizeof(data)));
        assertEqualIntA(ad, 0, archive_write_finish_entry(ad));
-       assertEqualInt(0, archive_write_finish(ad));
+       assertEqualInt(0, archive_write_free(ad));
 
        /* Test the entries on disk. */
        assertIsReg(archive_entry_pathname(ae), archive_entry_mode(ae) & 0777);
@@ -128,7 +128,7 @@ static void create_reg_file2(struct archive_entry *ae, const char *msg)
                    archive_write_data_block(ad, data + i, 1000, i));
        }
        assertEqualIntA(ad, 0, archive_write_finish_entry(ad));
-       assertEqualInt(0, archive_write_finish(ad));
+       assertEqualInt(0, archive_write_free(ad));
 
        /* Test the entries on disk. */
        assertIsReg(archive_entry_pathname(ae), archive_entry_mode(ae) & 0777);
@@ -151,7 +151,7 @@ static void create_reg_file3(struct archive_entry *ae, const char *msg)
        assertEqualIntA(ad, 0, archive_write_header(ad, ae));
        assertEqualInt(5, archive_write_data(ad, data, sizeof(data)));
        assertEqualIntA(ad, 0, archive_write_finish_entry(ad));
-       assertEqualInt(0, archive_write_finish(ad));
+       assertEqualInt(0, archive_write_free(ad));
 
        /* Test the entry on disk. */
        assert(0 == stat(archive_entry_pathname(ae), &st));
@@ -177,7 +177,7 @@ static void create_reg_file4(struct archive_entry *ae, const char *msg)
        assertEqualInt(ARCHIVE_OK,
            archive_write_data_block(ad, data, sizeof(data), 0));
        assertEqualIntA(ad, 0, archive_write_finish_entry(ad));
-       assertEqualInt(0, archive_write_finish(ad));
+       assertEqualInt(0, archive_write_free(ad));
 
        /* Test the entry on disk. */
        assert(0 == stat(archive_entry_pathname(ae), &st));
@@ -208,7 +208,7 @@ static void create_reg_file_win(struct archive_entry *ae, const char *msg)
        assertEqualIntA(ad, 0, archive_write_header(ad, ae));
        assertEqualInt(sizeof(data), archive_write_data(ad, data, sizeof(data)));
        assertEqualIntA(ad, 0, archive_write_finish_entry(ad));
-       assertEqualInt(0, archive_write_finish(ad));
+       assertEqualInt(0, archive_write_free(ad));
 
        /* Test the entries on disk. */
        l = strlen(archive_entry_pathname(ae));
index 8ca1aa707deb596a68b7b1bc8c69a86ab064ac7c..c563ce1d321280c5d93ed8fdfe38c2b36f52a53a 100644 (file)
@@ -59,7 +59,7 @@ DEFINE_TEST(test_write_disk_failures)
        archive_entry_set_mtime(ae, 123456789, 0);
        assertEqualIntA(a, ARCHIVE_FAILED, archive_write_header(a, ae));
        assertEqualIntA(a, 0, archive_write_finish_entry(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
        archive_entry_free(ae);
 #endif
 }
index 934aa08d5782e36eed7e74880903e02f26e4d4dc..93e5dc8d48fb459fd842b62a562a1a2460e604e2 100644 (file)
@@ -178,7 +178,7 @@ DEFINE_TEST(test_write_disk_hardlink)
                assertEqualIntA(ad, 0, archive_write_finish_entry(ad));
        }
        archive_entry_free(ae);
-       assertEqualInt(0, archive_write_finish(ad));
+       assertEqualInt(0, archive_write_free(ad));
 
        /* Test the entries on disk. */
 
index f1244bf79d5f7a6d895972ee20517373da9648a5..7861735bd5731ad25645fd8cac8ab07efeaa13bb 100644 (file)
@@ -365,7 +365,7 @@ DEFINE_TEST(test_write_disk_perms)
                assertEqualIntA(a,ARCHIVE_WARN,archive_write_finish_entry(a));
        }
 
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
        archive_entry_free(ae);
 
        /* Test the entries on disk. */
index 0f0815006d3f1c52539c4d56301e00524a226e32..31c5bfd7c4b31079160c18b85985be64fde39a2a 100644 (file)
@@ -178,7 +178,7 @@ DEFINE_TEST(test_write_disk_secure)
        assert(S_ISDIR(st.st_mode));
        archive_entry_free(ae);
 
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /* Test the entries on disk. */
        assert(0 == lstat("dir", &st));
index 638f0a4b26d34c8ceec4dfee7495df61f130f4a2..d25b6c00637d0155c9f1e0dac10c4873925c8fbf 100644 (file)
@@ -269,12 +269,12 @@ DEFINE_TEST(test_write_disk_sparse)
         archive_write_disk_set_options(ad, 0);
        verify_write_data(ad, 0);
        verify_write_data_block(ad, 0);
-       assertEqualInt(0, archive_write_finish(ad));
+       assertEqualInt(0, archive_write_free(ad));
 
        assert((ad = archive_write_disk_new()) != NULL);
         archive_write_disk_set_options(ad, ARCHIVE_EXTRACT_SPARSE);
        verify_write_data(ad, 1);
        verify_write_data_block(ad, 1);
-       assertEqualInt(0, archive_write_finish(ad));
+       assertEqualInt(0, archive_write_free(ad));
 
 }
index 60d0bdcbb0e831757c5d7c87821b171145c686d9..13089c78d8949bee089500250546cdb76ef4262b 100644 (file)
@@ -99,7 +99,7 @@ DEFINE_TEST(test_write_disk_symlink)
        assertEqualIntA(ad, 0, archive_write_finish_entry(ad));
        archive_entry_free(ae);
 
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(ad));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(ad));
 
        /* Test the entries on disk. */
 
index 9ecbff69b5680aec17443a8a3275433bde096c37..568d04c0017de29ec1bcf6a154205bc649c42ace 100644 (file)
@@ -163,5 +163,5 @@ DEFINE_TEST(test_write_disk_times)
        skipping("Platform-specific time restore tests");
 #endif
 
-       archive_write_finish(a);
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 }
index def40a4446360943fcafc6436944d66fa16a5ac9..2115c4d4db2696503ecb4aca2667d906810f5bf9 100644 (file)
@@ -98,7 +98,7 @@ DEFINE_TEST(test_write_format_ar)
        archive_entry_free(ae);
 
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /*
         * Now, read the data back.
@@ -133,7 +133,7 @@ DEFINE_TEST(test_write_format_ar)
        assertEqualMem(buff2, "88877766", 8);
 
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        /*
         * Then, we try to create a BSD format archive.
@@ -162,7 +162,7 @@ DEFINE_TEST(test_write_format_ar)
        assertEqualIntA(a, 6, archive_write_data(a, "555555", 7));
        archive_entry_free(ae);
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /* Now, Read the data back */
        assert((a = archive_read_new()) != NULL);
@@ -185,5 +185,5 @@ DEFINE_TEST(test_write_format_ar)
        /* Test EOF */
        assertEqualIntA(a, ARCHIVE_EOF, archive_read_next_header(a, &ae));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
index d61689e06ce519f69603ef52950821a10c6f35c7..3f3154b1be7cb9535b3ca193e3058e495e91d4da 100644 (file)
@@ -103,7 +103,7 @@ test_format(int     (*set_format)(struct archive *))
 
        /* Close out the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /*
         * Damage the second entry to test the search-ahead recovery.
@@ -132,7 +132,7 @@ test_format(int     (*set_format)(struct archive *))
        assertA(0 == archive_read_open_memory(a, buff, used));
 
        if (!assertEqualIntA(a, 0, archive_read_next_header(a, &ae))) {
-               archive_read_finish(a);
+               archive_read_free(a);
                return;
        }
 
@@ -168,7 +168,7 @@ test_format(int     (*set_format)(struct archive *))
        /* Verify the end of the archive. */
        assertEqualIntA(a, 1, archive_read_next_header(a, &ae));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 
        free(buff);
 }
index 953bf6567515f3a8e5f1ea5a60fd4f5d07688367..53aaec822712ccb2f0ffa4024d0d33780504369f 100644 (file)
@@ -62,7 +62,7 @@ DEFINE_TEST(test_write_format_cpio_empty)
 
        /* Close out the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        failure("Empty cpio archive should be exactly 87 bytes, was %d.", used);
        assert(used == 87);
index 62167e2066bac79a91392380b935fccfcf2eff1b..81c3d22d90e13661a628e5b17015b6489579f9f2 100644 (file)
@@ -111,7 +111,7 @@ DEFINE_TEST(test_write_format_cpio_newc)
        assertEqualIntA(a, 0, archive_write_header(a, entry));
        archive_entry_free(entry);
 
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /*
         * Verify the archive format.
index e45513639b787cd41a1e58444defd4f13adc41ad..48af04ecf355653e9b8d8c7596d16df20e7aa2e0 100644 (file)
@@ -123,7 +123,7 @@ DEFINE_TEST(test_write_format_cpio_odc)
        /* Write of data to symlink should fail == zero bytes get written. */
        assertEqualIntA(a, 0, archive_write_data(a, "1234567890", 10));
 
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /*
         * Verify the archive format.
index 0c6fd1fd127156d1dd09bfef5d9d7dd35dac4911..e998842385eb8594b9024a1cf41bf4b00fe6ae47 100644 (file)
@@ -87,7 +87,7 @@ test_write_format_mtree_sub(int use_set, int dironly)
                archive_entry_free(ae);
        }
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-        assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+        assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        if (use_set) {
                const char *p;
@@ -133,7 +133,7 @@ test_write_format_mtree_sub(int use_set, int dironly)
                        assertEqualInt(8, archive_entry_size(ae));
        }
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
 }
 
 DEFINE_TEST(test_write_format_mtree)
index d6383be56d693044a3ef835261b2b150d3a20b20..78c27ccfd6891ca7aa9d98a5586623c30d81c9fe 100644 (file)
@@ -106,7 +106,7 @@ DEFINE_TEST(test_write_format_pax)
 
        /* Close out the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualIntA(a, ARCHIVE_OK, archive_write_finish(a));
+       assertEqualIntA(a, ARCHIVE_OK, archive_write_free(a));
 
        /*
         *
@@ -193,7 +193,7 @@ DEFINE_TEST(test_write_format_pax)
         */
        assertEqualIntA(a, ARCHIVE_EOF, archive_read_next_header(a, &ae));
        assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-       assertEqualIntA(a, ARCHIVE_OK, archive_read_finish(a));
+       assertEqualIntA(a, ARCHIVE_OK, archive_read_free(a));
 
        free(buff);
 }
index dd2f10cc10ed7dd7f0389194589b248feb75466b..09cfcd6b7598404e97db663cd09ba5403b52620b 100644 (file)
@@ -47,7 +47,7 @@ DEFINE_TEST(test_write_format_shar_empty)
 
        /* Close out the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        failure("Empty shar archive should be exactly 0 bytes, was %d.", used);
        assert(used == 0);
index b8fd2e728399b259afac1ca4f3eb642c38e43900..a02570ca4d2dfe866e32ffc456fb683e78ec9c5d 100644 (file)
@@ -72,7 +72,7 @@ DEFINE_TEST(test_write_format_tar)
 
                /* Close out the archive. */
                assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-               assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
                /* This calculation gives "the smallest multiple of
                 * the block size that is at least 2048 bytes". */
@@ -102,6 +102,6 @@ DEFINE_TEST(test_write_format_tar)
                /* Verify the end of the archive. */
                assert(1 == archive_read_next_header(a, &ae));
                assertEqualIntA(a, ARCHIVE_OK, archive_read_close(a));
-               assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_read_free(a));
        }
 }
index d40026b33df40dbff71ac705bba4efe60f6f0a98..f9e972b4064b1d39dc96b2f7530a7f48e2411319 100644 (file)
@@ -46,7 +46,7 @@ DEFINE_TEST(test_write_format_tar_empty)
 
        /* Close out the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        assert(used == 1024);
        for (i = 0; i < used; i++) {
@@ -64,7 +64,7 @@ DEFINE_TEST(test_write_format_tar_empty)
 
        /* Close out the archive. */
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        assertEqualInt((int)used, 1024);
        for (i = 0; i < used; i++) {
index 939bfa844f34967da19c6db597fc3dd33bc0aa26..7cfc3e80b41f3d5f765cef6ab99276f19bba6f66 100644 (file)
@@ -188,7 +188,7 @@ DEFINE_TEST(test_write_format_tar_ustar)
        archive_entry_set_nlink(entry, 1);
        assertEqualIntA(a, 0, archive_write_header(a, entry));
        archive_entry_free(entry);
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /*
         * Verify the archive format.
index 250ddba91317d57063dae13b3be627fb9ee95f85..5ef98d3a6c0277f81cf949fc7348e7485c99116a 100644 (file)
@@ -111,7 +111,7 @@ DEFINE_TEST(test_write_format_zip)
 
        /* Close out the archive. */
        assertEqualInt(ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /*
         * Now, read the data back.
@@ -175,6 +175,6 @@ DEFINE_TEST(test_write_format_zip)
        /* Verify the end of the archive. */
        assertEqualIntA(a, ARCHIVE_EOF, archive_read_next_header(a, &ae));
        assertEqualInt(ARCHIVE_OK, archive_read_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_read_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_read_free(a));
        free(buff);
 }
index 7e9e684782847d662ccdf068bd4d2d12d23212b9..55e89fd9d6055abf291ba89909ae647a57f9f1b6 100644 (file)
@@ -46,7 +46,7 @@ DEFINE_TEST(test_write_format_zip_empty)
 
        /* Close out the archive without writing anything. */
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /* Verify the correct format for an empy Zip archive. */
        assertEqualInt(used, 22);
index f01c90afa4e8c662c590bef5412d334f2fb3f276..3f4ffe16f4fbf8f8f2ce24c5e16c5f72065cf413 100644 (file)
@@ -136,7 +136,7 @@ DEFINE_TEST(test_write_format_zip_no_compression)
 
        /* Close the archive . */
        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-       assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+       assertEqualInt(ARCHIVE_OK, archive_write_free(a));
 
        /* Remember the end of the archive in memory. */
        buffend = buff + used;
index e9bead4362cd0dcf62ac34bfea9508ef54569a0e..efa167ad677367a6f889263fa56409a6d0ca8c51 100644 (file)
@@ -64,7 +64,7 @@ DEFINE_TEST(test_write_open_memory)
                        assertA(ARCHIVE_FATAL == archive_write_close(a));
                else
                        assertEqualIntA(a, ARCHIVE_OK, archive_write_close(a));
-               assertEqualInt(ARCHIVE_OK, archive_write_finish(a));
+               assertEqualInt(ARCHIVE_OK, archive_write_free(a));
                assert(buff[i] == 0xAE);
                assert(s <= i);
        }
index aaaacac0dcaa2c82567d31dd8dbd6f3f2f513ef9..3d8b347d37e97ff980b5754c0275a04120f785ac 100644 (file)
@@ -332,7 +332,7 @@ read_archive(struct bsdtar *bsdtar, char mode)
                fprintf(stdout, "Archive Format: %s,  Compression: %s\n",
                    archive_format_name(a), archive_compression_name(a));
 
-       archive_read_finish(a);
+       archive_read_free(a);
 }
 
 
index 0d5c65c999bb915da7e07bba8816e303f178c402..35bb39831747cd31b2d3995e8bb252ac688fb191 100644 (file)
@@ -286,7 +286,7 @@ tar_mode_r(struct bsdtar *bsdtar)
                    archive_error_string(a));
        while (0 == archive_read_next_header(a, &entry)) {
                if (archive_compression(a) != ARCHIVE_COMPRESSION_NONE) {
-                       archive_read_finish(a);
+                       archive_read_free(a);
                        close(bsdtar->fd);
                        lafe_errc(1, 0,
                            "Cannot append to compressed archive.");
@@ -296,7 +296,7 @@ tar_mode_r(struct bsdtar *bsdtar)
        }
 
        end_offset = archive_read_header_position(a);
-       archive_read_finish(a);
+       archive_read_free(a);
 
        /* Re-open archive for writing */
        a = archive_write_new();
@@ -384,7 +384,7 @@ tar_mode_u(struct bsdtar *bsdtar)
        /* Build a list of all entries and their recorded mod times. */
        while (0 == archive_read_next_header(a, &entry)) {
                if (archive_compression(a) != ARCHIVE_COMPRESSION_NONE) {
-                       archive_read_finish(a);
+                       archive_read_free(a);
                        close(bsdtar->fd);
                        lafe_errc(1, 0,
                            "Cannot append to compressed archive.");
@@ -398,7 +398,7 @@ tar_mode_u(struct bsdtar *bsdtar)
        }
 
        end_offset = archive_read_header_position(a);
-       archive_read_finish(a);
+       archive_read_free(a);
 
        /* Re-open archive for writing. */
        a = archive_write_new();
@@ -509,7 +509,7 @@ cleanup:
        free(bsdtar->buff);
        archive_entry_linkresolver_free(bsdtar->resolver);
        bsdtar->resolver = NULL;
-       archive_read_finish(bsdtar->diskreader);
+       archive_read_free(bsdtar->diskreader);
        bsdtar->diskreader = NULL;
 
        if (bsdtar->option_totals) {
@@ -517,7 +517,7 @@ cleanup:
                    tar_i64toa(archive_position_compressed(a)));
        }
 
-       archive_write_finish(a);
+       archive_write_free(a);
 }
 
 /*
@@ -588,7 +588,7 @@ append_archive_filename(struct bsdtar *bsdtar, struct archive *a,
                    filename, archive_error_string(ina));
                bsdtar->return_value = 1;
        }
-       archive_read_finish(ina);
+       archive_read_free(ina);
 
        return (rc);
 }