]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
3.0-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 23 Jan 2013 01:19:40 +0000 (17:19 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 23 Jan 2013 01:19:40 +0000 (17:19 -0800)
added patches:
drm-i915-invalidate-the-relocation-presumed_offsets-along-the-slow-path.patch

queue-3.0/drm-i915-invalidate-the-relocation-presumed_offsets-along-the-slow-path.patch [new file with mode: 0644]
queue-3.0/series [new file with mode: 0644]

diff --git a/queue-3.0/drm-i915-invalidate-the-relocation-presumed_offsets-along-the-slow-path.patch b/queue-3.0/drm-i915-invalidate-the-relocation-presumed_offsets-along-the-slow-path.patch
new file mode 100644 (file)
index 0000000..fb2e87b
--- /dev/null
@@ -0,0 +1,71 @@
+From 262b6d363fcff16359c93bd58c297f961f6e6273 Mon Sep 17 00:00:00 2001
+From: Chris Wilson <chris@chris-wilson.co.uk>
+Date: Tue, 15 Jan 2013 16:17:54 +0000
+Subject: drm/i915: Invalidate the relocation presumed_offsets along the slow path
+
+From: Chris Wilson <chris@chris-wilson.co.uk>
+
+commit 262b6d363fcff16359c93bd58c297f961f6e6273 upstream.
+
+In the slow path, we are forced to copy the relocations prior to
+acquiring the struct mutex in order to handle pagefaults. We forgo
+copying the new offsets back into the relocation entries in order to
+prevent a recursive locking bug should we trigger a pagefault whilst
+holding the mutex for the reservations of the execbuffer. Therefore, we
+need to reset the presumed_offsets just in case the objects are rebound
+back into their old locations after relocating for this exexbuffer - if
+that were to happen we would assume the relocations were valid and leave
+the actual pointers to the kernels dangling, instant hang.
+
+Fixes regression from commit bcf50e2775bbc3101932d8e4ab8c7902aa4163b4
+Author: Chris Wilson <chris@chris-wilson.co.uk>
+Date:   Sun Nov 21 22:07:12 2010 +0000
+
+    drm/i915: Handle pagefaults in execbuffer user relocations
+
+Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=55984
+Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
+Cc: Daniel Vetter <daniel.vetter@fwll.ch>
+Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
+
+---
+ drivers/gpu/drm/i915/i915_gem_execbuffer.c |   21 +++++++++++++++++++++
+ 1 file changed, 21 insertions(+)
+
+--- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
++++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
+@@ -655,6 +655,8 @@ i915_gem_execbuffer_relocate_slow(struct
+       total = 0;
+       for (i = 0; i < count; i++) {
+               struct drm_i915_gem_relocation_entry __user *user_relocs;
++              u64 invalid_offset = (u64)-1;
++              int j;
+               user_relocs = (void __user *)(uintptr_t)exec[i].relocs_ptr;
+@@ -665,6 +667,25 @@ i915_gem_execbuffer_relocate_slow(struct
+                       goto err;
+               }
++              /* As we do not update the known relocation offsets after
++               * relocating (due to the complexities in lock handling),
++               * we need to mark them as invalid now so that we force the
++               * relocation processing next time. Just in case the target
++               * object is evicted and then rebound into its old
++               * presumed_offset before the next execbuffer - if that
++               * happened we would make the mistake of assuming that the
++               * relocations were valid.
++               */
++              for (j = 0; j < exec[i].relocation_count; j++) {
++                      if (copy_to_user(&user_relocs[j].presumed_offset,
++                                       &invalid_offset,
++                                       sizeof(invalid_offset))) {
++                              ret = -EFAULT;
++                              mutex_lock(&dev->struct_mutex);
++                              goto err;
++                      }
++              }
++
+               reloc_offset[i] = total;
+               total += exec[i].relocation_count;
+       }
diff --git a/queue-3.0/series b/queue-3.0/series
new file mode 100644 (file)
index 0000000..29d2788
--- /dev/null
@@ -0,0 +1 @@
+drm-i915-invalidate-the-relocation-presumed_offsets-along-the-slow-path.patch