net: dev: use kfree_skb_reason() for sch_handle_egress()

Replace kfree_skb() used in sch_handle_egress() with kfree_skb_reason().
The drop reason SKB_DROP_REASON_TC_EGRESS is introduced. Considering
the code path of tc egerss, we make it distinct with the drop reason
of SKB_DROP_REASON_QDISC_DROP in the next commit.

Signed-off-by: Menglong Dong <imagedong@tencent.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 5445860e1ba6e36adad44d6594585ea0ab1b0490..1ffe64616741bcfc62fc29366dd5e98ede2365c1 100644 (file)
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -394,6 +394,7 @@ enum skb_drop_reason {
                                                 * entry is full
                                                 */
        SKB_DROP_REASON_NEIGH_DEAD,     /* neigh entry is dead */
+       SKB_DROP_REASON_TC_EGRESS,      /* dropped in TC egress HOOK */
        SKB_DROP_REASON_MAX,
 };
 

diff --git a/include/trace/events/skb.h b/include/trace/events/skb.h
index 1977f301260da1ff01b95861fe918141ecb018e9..53755e8191a19e8f18ec195026bdf4166dc66779 100644 (file)
--- a/include/trace/events/skb.h
+++ b/include/trace/events/skb.h
@@ -45,6 +45,7 @@
        EM(SKB_DROP_REASON_NEIGH_FAILED, NEIGH_FAILED)          \
        EM(SKB_DROP_REASON_NEIGH_QUEUEFULL, NEIGH_QUEUEFULL)    \
        EM(SKB_DROP_REASON_NEIGH_DEAD, NEIGH_DEAD)              \
+       EM(SKB_DROP_REASON_TC_EGRESS, TC_EGRESS)                \
        EMe(SKB_DROP_REASON_MAX, MAX)
 
 #undef EM

diff --git a/net/core/dev.c b/net/core/dev.c
index 96bcc003e018569e22d89026d8be01e811efaca4..ef0b1992cf1365dfb55d2f1abd2f85a119f99caf 100644 (file)
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -3889,7 +3889,7 @@ sch_handle_egress(struct sk_buff *skb, int *ret, struct net_device *dev)
        case TC_ACT_SHOT:
                mini_qdisc_qstats_cpu_drop(miniq);
                *ret = NET_XMIT_DROP;
-               kfree_skb(skb);
+               kfree_skb_reason(skb, SKB_DROP_REASON_TC_EGRESS);
                return NULL;
        case TC_ACT_STOLEN:
        case TC_ACT_QUEUED: