re PR target/39179 (Wrong code in c++ for const members initialized in external file)

        PR target/39179
        * tree-ssa-ccp.c (get_symbol_constant_value): Don't assume zero
        value if DECL_EXTERNAL.
        * tree-sra.c (sra_walk_gimple_assign): Likewise.
        * target.h (gcc_target::binds_local_p): Clarify module.
        * tree.h (TREE_PUBLIC): Clarify module.

From-SVN: r144270

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index ac325e02264e0763d96aef5905e9fcf07c44e423..8f44f45a292a25065f204fc96fba47aa13b4f039 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,12 @@
+2009-02-18  Jason Merrill  <jason@redhat.com>
+
+       PR target/39179
+       * tree-ssa-ccp.c (get_symbol_constant_value): Don't assume zero
+       value if DECL_EXTERNAL.
+       * tree-sra.c (sra_walk_gimple_assign): Likewise.
+       * target.h (gcc_target::binds_local_p): Clarify "module".
+       * tree.h (TREE_PUBLIC): Clarify "module".
+
 2009-02-17  Xuepeng Guo  <xuepeng.guo@intel.com>
 
        PR target/38891

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index d9d6866e3ad48c62bd05589d77bdd1d423f25f24..3ca03d37a3afe61e714004954255637786133e01 100644 (file)
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,7 @@
+2009-02-18  Jason Merrill  <jason@redhat.com>
+
+       * cfns.h: Tweak pathname for cfns.gperf.
+
 2009-02-13  Jason Merrill  <jason@redhat.com>
 
        PR c++/39070

diff --git a/gcc/cp/cfns.h b/gcc/cp/cfns.h
index 82cdef76466fa5189d913bed1b10f424fe49eb74..e6d43d8acfb7d99f352d3201d0ba2c73b2091e1e 100644 (file)
--- a/gcc/cp/cfns.h
+++ b/gcc/cp/cfns.h
@@ -1,5 +1,5 @@
 /* ANSI-C code produced by gperf version 3.0.1 */
-/* Command-line: gperf -o -C -E -k '1-6,$' -j1 -D -N libc_name_p -L ANSI-C ../../gcc/gcc/cp/cfns.gperf  */
+/* Command-line: gperf -o -C -E -k '1-6,$' -j1 -D -N libc_name_p -L ANSI-C ../../gcc/cp/cfns.gperf  */
 
 #if !((' ' == 32) && ('!' == 33) && ('"' == 34) && ('#' == 35) \
       && ('%' == 37) && ('&' == 38) && ('\'' == 39) && ('(' == 40) \
@@ -28,7 +28,7 @@
 #error "gperf generated tables don't work with this execution character set. Please report a bug to <bug-gnu-gperf@gnu.org>."
 #endif
 
-#line 1 "../../gcc/gcc/cp/cfns.gperf"
+#line 1 "../../gcc/cp/cfns.gperf"
 
 #ifdef __GNUC__
 __inline

diff --git a/gcc/cp/ptree.c b/gcc/cp/ptree.c
index c91cb15dc74469d1b066cf5682597578475ac213..2452abc462252fdec2678c11e4357b1b256e15ee 100644 (file)
--- a/gcc/cp/ptree.c
+++ b/gcc/cp/ptree.c
@@ -44,7 +44,23 @@ cxx_print_decl (FILE *file, tree node, int indent)
   if (!CODE_CONTAINS_STRUCT (TREE_CODE (node), TS_DECL_COMMON)
       || !DECL_LANG_SPECIFIC (node))
     return;
+  if (TREE_CODE (node) == FUNCTION_DECL)
+    {
+      int flags = TFF_DECL_SPECIFIERS|TFF_RETURN_TYPE
+       |TFF_FUNCTION_DEFAULT_ARGUMENTS|TFF_EXCEPTION_SPECIFICATION ;
+      indent_to (file, indent + 3);
+      fprintf (file, " full-name \"%s\"", decl_as_string (node, flags));
+    }
+  else if (TREE_CODE (node) == TEMPLATE_DECL)
+    {
+      indent_to (file, indent + 3);
+      fprintf (file, " full-name \"%s\"",
+              decl_as_string (node, TFF_TEMPLATE_HEADER));
+    }
+
   indent_to (file, indent + 3);
+  if (DECL_EXTERNAL (node) && DECL_NOT_REALLY_EXTERN (node))
+    fprintf (file, " not-really-extern");
   if (TREE_CODE (node) == FUNCTION_DECL
       && DECL_PENDING_INLINE_INFO (node))
     fprintf (file, " pending-inline-info %p",
@@ -81,6 +97,9 @@ cxx_print_type (FILE *file, tree node, int indent)
 
     case RECORD_TYPE:
     case UNION_TYPE:
+      indent_to (file, indent + 4);
+      fprintf (file, "full-name \"%s\"",
+              type_as_string (node, TFF_CLASS_KEY_OR_ENUM));
       break;
 
     default:
@@ -97,7 +116,7 @@ cxx_print_type (FILE *file, tree node, int indent)
   indent_to (file, indent + 3);
 
   if (TYPE_NEEDS_CONSTRUCTING (node))
-    fputs ( "needs-constructor", file);
+    fputs ( " needs-constructor", file);
   if (TYPE_HAS_NONTRIVIAL_DESTRUCTOR (node))
     fputs (" needs-destructor", file);
   if (TYPE_HAS_DEFAULT_CONSTRUCTOR (node))

diff --git a/gcc/target.h b/gcc/target.h
index 21c46adbbe2c674a19477117092ad586c324f746..10aaf4c171c3f97619fd532453396c0696a82fd0 100644 (file)
--- a/gcc/target.h
+++ b/gcc/target.h
@@ -626,7 +626,7 @@ struct gcc_target
   bool (* in_small_data_p) (const_tree);
 
   /* True if EXP names an object for which name resolution must resolve
-     to the current module.  */
+     to the current executable or shared library.  */
   bool (* binds_local_p) (const_tree);
 
   /* Modify and return the identifier of a DECL's external name,

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 60b17cda832e0811bf17925d79785ced0d7183e3..f052878791fa3f458ee7bafd75bebb5aec33f625 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2009-02-18  Jason Merrill  <jason@redhat.com>
+
+       PR target/39179
+       * g++.dg/opt/const6.C: New test.
+
 2009-02-18  H.J. Lu  <hongjiu.lu@intel.com>
 
        * gcc.dg/callabi/callabi.exp: Moved to ...

diff --git a/gcc/testsuite/g++.dg/init/const7.C b/gcc/testsuite/g++.dg/init/const7.C
index 348bd58d6905d44e2adf3952974191ff39c044b4..18d04625db2da1178c806ee1f0a5cf287e65b66a 100644 (file)
--- a/gcc/testsuite/g++.dg/init/const7.C
+++ b/gcc/testsuite/g++.dg/init/const7.C
@@ -9,5 +9,5 @@ short offsets[1] = {
 // This ensures that we get a dump whether or not the bug is present.
 void fn() { }
 
-// { dg-final { scan-tree-dump-not "initialization"  "gimple" { xfail *-*-* } } }
+// { dg-final { scan-tree-dump-not "initialization"  "gimple" } }
 // { dg-final { cleanup-tree-dump "gimple" } }

diff --git a/gcc/testsuite/g++.dg/opt/const6.C b/gcc/testsuite/g++.dg/opt/const6.C
new file mode 100644 (file)
index 0000000..1a5c79b
--- /dev/null
+++ b/gcc/testsuite/g++.dg/opt/const6.C
@@ -0,0 +1,14 @@
+// PR target/39179
+// Make sure that we don't optimize away the load from K::k.
+// { dg-options "-O2" }
+// { dg-final { scan-assembler _ZN1K1kE } }
+
+struct K {
+    static const unsigned k;
+};
+extern "C" void abort (void);
+int main() {
+    if ( K::k != 1 )
+      abort ();
+    return 1;
+}

diff --git a/gcc/tree-pretty-print.c b/gcc/tree-pretty-print.c
index ff45ecc635d8a3d650b5847fcd5757c40421d6b8..e01433b142dab7e6c5a9a87ca42fa453e71bae92 100644 (file)
--- a/gcc/tree-pretty-print.c
+++ b/gcc/tree-pretty-print.c
@@ -2585,18 +2585,20 @@ print_call_name (pretty_printer *buffer, const_tree node)
   if (TREE_CODE (op0) == NON_LVALUE_EXPR)
     op0 = TREE_OPERAND (op0, 0);
 
+ again:
   switch (TREE_CODE (op0))
     {
     case VAR_DECL:
     case PARM_DECL:
+    case FUNCTION_DECL:
       dump_function_name (buffer, op0);
       break;
 
     case ADDR_EXPR:
     case INDIRECT_REF:
     case NOP_EXPR:
-      dump_generic_node (buffer, TREE_OPERAND (op0, 0), 0, 0, false);
-      break;
+      op0 = TREE_OPERAND (op0, 0);
+      goto again;
 
     case COND_EXPR:
       pp_string (buffer, "(");

diff --git a/gcc/tree-sra.c b/gcc/tree-sra.c
index 01c0e121e0035351fc509e20570f25db0e08469f..abcca2b93f88c7c23ce65a7165b09fb59894d482 100644 (file)
--- a/gcc/tree-sra.c
+++ b/gcc/tree-sra.c
@@ -1008,6 +1008,7 @@ sra_walk_gimple_assign (gimple stmt, gimple_stmt_iterator *gsi,
         we'd been passed the constructor directly.  Invoke INIT.  */
       else if (TREE_CODE (rhs) == VAR_DECL
               && TREE_STATIC (rhs)
+              && !DECL_EXTERNAL (rhs)
               && TREE_READONLY (rhs)
               && targetm.binds_local_p (rhs))
        fns->init (lhs_elt, DECL_INITIAL (rhs), gsi);

diff --git a/gcc/tree-ssa-ccp.c b/gcc/tree-ssa-ccp.c
index ef6890c65c3024dd33992df2aadc089b4127e2ee..46272659b65a0a4dcca7a2762ff8d4302b0e6567 100644 (file)
--- a/gcc/tree-ssa-ccp.c
+++ b/gcc/tree-ssa-ccp.c
@@ -287,10 +287,11 @@ get_symbol_constant_value (tree sym)
         have zero as the initializer if they may not be
         overridden at link or run time.  */
       if (!val
+         && !DECL_EXTERNAL (sym)
          && targetm.binds_local_p (sym)
           && (INTEGRAL_TYPE_P (TREE_TYPE (sym))
               || SCALAR_FLOAT_TYPE_P (TREE_TYPE (sym))))
-        return fold_convert (TREE_TYPE (sym), integer_zero_node);
+       return fold_convert (TREE_TYPE (sym), integer_zero_node);
     }
 
   return NULL_TREE;

diff --git a/gcc/tree.h b/gcc/tree.h
index b7300fa8b876a0c1382c6fbebc7132cd77cc6d50..29d3782119adcd624281c783daa942a6651e2d80 100644 (file)
--- a/gcc/tree.h
+++ b/gcc/tree.h
@@ -1195,9 +1195,9 @@ extern void omp_clause_range_check_failed (const_tree, const char *, int,
  (CONSTANT_CLASS_P (EXPR) && TREE_OVERFLOW (EXPR))
 
 /* In a VAR_DECL, FUNCTION_DECL, NAMESPACE_DECL or TYPE_DECL,
-   nonzero means name is to be accessible from outside this module.
+   nonzero means name is to be accessible from outside this translation unit.
    In an IDENTIFIER_NODE, nonzero means an external declaration
-   accessible from outside this module was previously seen
+   accessible from outside this translation unit was previously seen
    for this name in an inner scope.  */
 #define TREE_PUBLIC(NODE) ((NODE)->base.public_flag)
 

diff --git a/gcc/varasm.c b/gcc/varasm.c
index 7fed3009b84a748237df9c23c5e04cbad4ec521d..083cf093f2507383438a1fda33462b49658ce0bf 100644 (file)
--- a/gcc/varasm.c
+++ b/gcc/varasm.c
@@ -4316,12 +4316,10 @@ initializer_constant_valid_p (tree value, tree endtype)
        }
 
       /* Support narrowing pointer differences.  */
-      if (TREE_CODE (value) == POINTER_PLUS_EXPR)
-       {
-         ret = narrowing_initializer_constant_valid_p (value, endtype);
-         if (ret != NULL_TREE)
-           return ret;
-       }
+      ret = narrowing_initializer_constant_valid_p (value, endtype);
+      if (ret != NULL_TREE)
+       return ret;
+
       break;
 
     case MINUS_EXPR: