]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
4.19-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 22 Nov 2020 11:04:56 +0000 (12:04 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 22 Nov 2020 11:04:56 +0000 (12:04 +0100)
added patches:
ah6-fix-error-return-code-in-ah6_input.patch
atm-nicstar-unmap-dma-on-send-error.patch
bnxt_en-read-eeprom-a2h-address-using-page-0.patch
devlink-add-missing-genlmsg_cancel-in-devlink_nl_sb_port_pool_fill.patch
inet_diag-fix-error-path-to-cancel-the-meseage-in-inet_req_diag_fill.patch
lan743x-fix-issue-causing-intermittent-kernel-log-warnings.patch
lan743x-prevent-entire-kernel-hang-on-open-for-some-platforms.patch
mlxsw-core-use-variable-timeout-for-emad-retries.patch
net-b44-fix-error-return-code-in-b44_init_one.patch
net-bridge-add-missing-counters-to-ndo_get_stats64-callback.patch
net-dsa-mv88e6xxx-avoid-vtu-corruption-on-6097.patch
net-ftgmac100-fix-crash-when-removing-driver.patch
net-have-netpoll-bring-up-dsa-management-interface.patch
net-mlx4_core-fix-init_hca-fields-offset.patch
net-mlx5-disable-qos-when-min_rates-on-all-vfs-are-zero.patch
net-ncsi-fix-netlink-registration.patch
net-qualcomm-rmnet-fix-incorrect-receive-packet-handling-during-cleanup.patch
net-usb-qmi_wwan-set-dtr-quirk-for-mr400.patch
net-x25-increase-refcnt-of-struct-x25_neigh-in-x25_rx_call_request.patch
netlabel-fix-an-uninitialized-warning-in-netlbl_unlabel_staticlist.patch
netlabel-fix-our-progress-tracking-in-netlbl_unlabel_staticlist.patch
page_frag-recover-from-memory-pressure.patch
qed-fix-error-return-code-in-qed_iwarp_ll2_start.patch
qlcnic-fix-error-return-code-in-qlcnic_83xx_restart_hw.patch
sctp-change-to-hold-put-transport-for-proto_unreach_timer.patch
tcp-only-postpone-probe_rtt-if-rtt-is-current-min_rtt-estimate.patch

27 files changed:
queue-4.19/ah6-fix-error-return-code-in-ah6_input.patch [new file with mode: 0644]
queue-4.19/atm-nicstar-unmap-dma-on-send-error.patch [new file with mode: 0644]
queue-4.19/bnxt_en-read-eeprom-a2h-address-using-page-0.patch [new file with mode: 0644]
queue-4.19/devlink-add-missing-genlmsg_cancel-in-devlink_nl_sb_port_pool_fill.patch [new file with mode: 0644]
queue-4.19/inet_diag-fix-error-path-to-cancel-the-meseage-in-inet_req_diag_fill.patch [new file with mode: 0644]
queue-4.19/lan743x-fix-issue-causing-intermittent-kernel-log-warnings.patch [new file with mode: 0644]
queue-4.19/lan743x-prevent-entire-kernel-hang-on-open-for-some-platforms.patch [new file with mode: 0644]
queue-4.19/mlxsw-core-use-variable-timeout-for-emad-retries.patch [new file with mode: 0644]
queue-4.19/net-b44-fix-error-return-code-in-b44_init_one.patch [new file with mode: 0644]
queue-4.19/net-bridge-add-missing-counters-to-ndo_get_stats64-callback.patch [new file with mode: 0644]
queue-4.19/net-dsa-mv88e6xxx-avoid-vtu-corruption-on-6097.patch [new file with mode: 0644]
queue-4.19/net-ftgmac100-fix-crash-when-removing-driver.patch [new file with mode: 0644]
queue-4.19/net-have-netpoll-bring-up-dsa-management-interface.patch [new file with mode: 0644]
queue-4.19/net-mlx4_core-fix-init_hca-fields-offset.patch [new file with mode: 0644]
queue-4.19/net-mlx5-disable-qos-when-min_rates-on-all-vfs-are-zero.patch [new file with mode: 0644]
queue-4.19/net-ncsi-fix-netlink-registration.patch [new file with mode: 0644]
queue-4.19/net-qualcomm-rmnet-fix-incorrect-receive-packet-handling-during-cleanup.patch [new file with mode: 0644]
queue-4.19/net-usb-qmi_wwan-set-dtr-quirk-for-mr400.patch [new file with mode: 0644]
queue-4.19/net-x25-increase-refcnt-of-struct-x25_neigh-in-x25_rx_call_request.patch [new file with mode: 0644]
queue-4.19/netlabel-fix-an-uninitialized-warning-in-netlbl_unlabel_staticlist.patch [new file with mode: 0644]
queue-4.19/netlabel-fix-our-progress-tracking-in-netlbl_unlabel_staticlist.patch [new file with mode: 0644]
queue-4.19/page_frag-recover-from-memory-pressure.patch [new file with mode: 0644]
queue-4.19/qed-fix-error-return-code-in-qed_iwarp_ll2_start.patch [new file with mode: 0644]
queue-4.19/qlcnic-fix-error-return-code-in-qlcnic_83xx_restart_hw.patch [new file with mode: 0644]
queue-4.19/sctp-change-to-hold-put-transport-for-proto_unreach_timer.patch [new file with mode: 0644]
queue-4.19/series [new file with mode: 0644]
queue-4.19/tcp-only-postpone-probe_rtt-if-rtt-is-current-min_rtt-estimate.patch [new file with mode: 0644]

diff --git a/queue-4.19/ah6-fix-error-return-code-in-ah6_input.patch b/queue-4.19/ah6-fix-error-return-code-in-ah6_input.patch
new file mode 100644 (file)
index 0000000..3ac04a6
--- /dev/null
@@ -0,0 +1,34 @@
+From foo@baz Sun Nov 22 12:00:04 PM CET 2020
+From: Zhang Changzhong <zhangchangzhong@huawei.com>
+Date: Tue, 17 Nov 2020 10:45:05 +0800
+Subject: ah6: fix error return code in ah6_input()
+
+From: Zhang Changzhong <zhangchangzhong@huawei.com>
+
+[ Upstream commit a5ebcbdf34b65fcc07f38eaf2d60563b42619a59 ]
+
+Fix to return a negative error code from the error handling
+case instead of 0, as done elsewhere in this function.
+
+Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
+Reported-by: Hulk Robot <hulkci@huawei.com>
+Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
+Link: https://lore.kernel.org/r/1605581105-35295-1-git-send-email-zhangchangzhong@huawei.com
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ net/ipv6/ah6.c |    3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+--- a/net/ipv6/ah6.c
++++ b/net/ipv6/ah6.c
+@@ -600,7 +600,8 @@ static int ah6_input(struct xfrm_state *
+       memcpy(auth_data, ah->auth_data, ahp->icv_trunc_len);
+       memset(ah->auth_data, 0, ahp->icv_trunc_len);
+-      if (ipv6_clear_mutable_options(ip6h, hdr_len, XFRM_POLICY_IN))
++      err = ipv6_clear_mutable_options(ip6h, hdr_len, XFRM_POLICY_IN);
++      if (err)
+               goto out_free;
+       ip6h->priority    = 0;
diff --git a/queue-4.19/atm-nicstar-unmap-dma-on-send-error.patch b/queue-4.19/atm-nicstar-unmap-dma-on-send-error.patch
new file mode 100644 (file)
index 0000000..3d30080
--- /dev/null
@@ -0,0 +1,35 @@
+From foo@baz Sun Nov 22 12:00:04 PM CET 2020
+From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
+Date: Mon, 16 Nov 2020 17:21:14 +0100
+Subject: atm: nicstar: Unmap DMA on send error
+
+From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
+
+[ Upstream commit 6dceaa9f56e22d0f9b4c4ad2ed9e04e315ce7fe5 ]
+
+The `skb' is mapped for DMA in ns_send() but does not unmap DMA in case
+push_scqe() fails to submit the `skb'. The memory of the `skb' is
+released so only the DMA mapping is leaking.
+
+Unmap the DMA mapping in case push_scqe() failed.
+
+Fixes: 864a3ff635fa7 ("atm: [nicstar] remove virt_to_bus() and support 64-bit platforms")
+Cc: Chas Williams <3chas3@gmail.com>
+Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/atm/nicstar.c |    2 ++
+ 1 file changed, 2 insertions(+)
+
+--- a/drivers/atm/nicstar.c
++++ b/drivers/atm/nicstar.c
+@@ -1705,6 +1705,8 @@ static int ns_send(struct atm_vcc *vcc,
+       if (push_scqe(card, vc, scq, &scqe, skb) != 0) {
+               atomic_inc(&vcc->stats->tx_err);
++              dma_unmap_single(&card->pcidev->dev, NS_PRV_DMA(skb), skb->len,
++                               DMA_TO_DEVICE);
+               dev_kfree_skb_any(skb);
+               return -EIO;
+       }
diff --git a/queue-4.19/bnxt_en-read-eeprom-a2h-address-using-page-0.patch b/queue-4.19/bnxt_en-read-eeprom-a2h-address-using-page-0.patch
new file mode 100644 (file)
index 0000000..f4f9faa
--- /dev/null
@@ -0,0 +1,36 @@
+From foo@baz Sun Nov 22 12:00:04 PM CET 2020
+From: Edwin Peer <edwin.peer@broadcom.com>
+Date: Sun, 15 Nov 2020 19:27:49 -0500
+Subject: bnxt_en: read EEPROM A2h address using page 0
+
+From: Edwin Peer <edwin.peer@broadcom.com>
+
+[ Upstream commit 4260330b32b14330cfe427d568ac5f5b29b5be3d ]
+
+The module eeprom address range returned by bnxt_get_module_eeprom()
+should be 256 bytes of A0h address space, the lower half of the A2h
+address space, and page 0 for the upper half of the A2h address space.
+
+Fix the firmware call by passing page_number 0 for the A2h slave address
+space.
+
+Fixes: 42ee18fe4ca2 ("bnxt_en: Add Support for ETHTOOL_GMODULEINFO and ETHTOOL_GMODULEEEPRO")
+Signed-off-by: Edwin Peer <edwin.peer@broadcom.com>
+Signed-off-by: Michael Chan <michael.chan@broadcom.com>
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
++++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
+@@ -2300,7 +2300,7 @@ static int bnxt_get_module_eeprom(struct
+       /* Read A2 portion of the EEPROM */
+       if (length) {
+               start -= ETH_MODULE_SFF_8436_LEN;
+-              rc = bnxt_read_sfp_module_eeprom_info(bp, I2C_DEV_ADDR_A2, 1,
++              rc = bnxt_read_sfp_module_eeprom_info(bp, I2C_DEV_ADDR_A2, 0,
+                                                     start, length, data);
+       }
+       return rc;
diff --git a/queue-4.19/devlink-add-missing-genlmsg_cancel-in-devlink_nl_sb_port_pool_fill.patch b/queue-4.19/devlink-add-missing-genlmsg_cancel-in-devlink_nl_sb_port_pool_fill.patch
new file mode 100644 (file)
index 0000000..9b0af90
--- /dev/null
@@ -0,0 +1,45 @@
+From foo@baz Sun Nov 22 12:00:04 PM CET 2020
+From: Wang Hai <wanghai38@huawei.com>
+Date: Fri, 13 Nov 2020 19:16:22 +0800
+Subject: devlink: Add missing genlmsg_cancel() in devlink_nl_sb_port_pool_fill()
+
+From: Wang Hai <wanghai38@huawei.com>
+
+[ Upstream commit 849920c703392957f94023f77ec89ca6cf119d43 ]
+
+If sb_occ_port_pool_get() failed in devlink_nl_sb_port_pool_fill(),
+msg should be canceled by genlmsg_cancel().
+
+Fixes: df38dafd2559 ("devlink: implement shared buffer occupancy monitoring interface")
+Reported-by: Hulk Robot <hulkci@huawei.com>
+Signed-off-by: Wang Hai <wanghai38@huawei.com>
+Link: https://lore.kernel.org/r/20201113111622.11040-1-wanghai38@huawei.com
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ net/core/devlink.c |    6 ++++--
+ 1 file changed, 4 insertions(+), 2 deletions(-)
+
+--- a/net/core/devlink.c
++++ b/net/core/devlink.c
+@@ -1113,7 +1113,7 @@ static int devlink_nl_sb_port_pool_fill(
+               err = ops->sb_occ_port_pool_get(devlink_port, devlink_sb->index,
+                                               pool_index, &cur, &max);
+               if (err && err != -EOPNOTSUPP)
+-                      return err;
++                      goto sb_occ_get_failure;
+               if (!err) {
+                       if (nla_put_u32(msg, DEVLINK_ATTR_SB_OCC_CUR, cur))
+                               goto nla_put_failure;
+@@ -1126,8 +1126,10 @@ static int devlink_nl_sb_port_pool_fill(
+       return 0;
+ nla_put_failure:
++      err = -EMSGSIZE;
++sb_occ_get_failure:
+       genlmsg_cancel(msg, hdr);
+-      return -EMSGSIZE;
++      return err;
+ }
+ static int devlink_nl_cmd_sb_port_pool_get_doit(struct sk_buff *skb,
diff --git a/queue-4.19/inet_diag-fix-error-path-to-cancel-the-meseage-in-inet_req_diag_fill.patch b/queue-4.19/inet_diag-fix-error-path-to-cancel-the-meseage-in-inet_req_diag_fill.patch
new file mode 100644 (file)
index 0000000..7686445
--- /dev/null
@@ -0,0 +1,36 @@
+From foo@baz Sun Nov 22 12:00:04 PM CET 2020
+From: Wang Hai <wanghai38@huawei.com>
+Date: Mon, 16 Nov 2020 16:20:18 +0800
+Subject: inet_diag: Fix error path to cancel the meseage in inet_req_diag_fill()
+
+From: Wang Hai <wanghai38@huawei.com>
+
+[ Upstream commit e33de7c5317e2827b2ba6fd120a505e9eb727b05 ]
+
+nlmsg_cancel() needs to be called in the error path of
+inet_req_diag_fill to cancel the message.
+
+Fixes: d545caca827b ("net: inet: diag: expose the socket mark to privileged processes.")
+Reported-by: Hulk Robot <hulkci@huawei.com>
+Signed-off-by: Wang Hai <wanghai38@huawei.com>
+Link: https://lore.kernel.org/r/20201116082018.16496-1-wanghai38@huawei.com
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ net/ipv4/inet_diag.c |    4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+--- a/net/ipv4/inet_diag.c
++++ b/net/ipv4/inet_diag.c
+@@ -392,8 +392,10 @@ static int inet_req_diag_fill(struct soc
+       r->idiag_inode  = 0;
+       if (net_admin && nla_put_u32(skb, INET_DIAG_MARK,
+-                                   inet_rsk(reqsk)->ir_mark))
++                                   inet_rsk(reqsk)->ir_mark)) {
++              nlmsg_cancel(skb, nlh);
+               return -EMSGSIZE;
++      }
+       nlmsg_end(skb, nlh);
+       return 0;
diff --git a/queue-4.19/lan743x-fix-issue-causing-intermittent-kernel-log-warnings.patch b/queue-4.19/lan743x-fix-issue-causing-intermittent-kernel-log-warnings.patch
new file mode 100644 (file)
index 0000000..72f6279
--- /dev/null
@@ -0,0 +1,132 @@
+From foo@baz Sun Nov 22 12:00:04 PM CET 2020
+From: Sven Van Asbroeck <thesven73@gmail.com>
+Date: Thu, 12 Nov 2020 13:59:49 -0500
+Subject: lan743x: fix issue causing intermittent kernel log warnings
+
+From: Sven Van Asbroeck <thesven73@gmail.com>
+
+[ Upstream commit e35df62e04cc6fc4b9d90d054732f138349ff9b1 ]
+
+When running this chip on arm imx6, we intermittently observe
+the following kernel warning in the log, especially when the
+system is under high load:
+
+[   50.119484] ------------[ cut here ]------------
+[   50.124377] WARNING: CPU: 0 PID: 303 at kernel/softirq.c:169 __local_bh_enable_ip+0x100/0x184
+[   50.132925] IRQs not enabled as expected
+[   50.159250] CPU: 0 PID: 303 Comm: rngd Not tainted 5.7.8 #1
+[   50.164837] Hardware name: Freescale i.MX6 Quad/DualLite (Device Tree)
+[   50.171395] [<c0111a38>] (unwind_backtrace) from [<c010be28>] (show_stack+0x10/0x14)
+[   50.179162] [<c010be28>] (show_stack) from [<c05b9dec>] (dump_stack+0xac/0xd8)
+[   50.186408] [<c05b9dec>] (dump_stack) from [<c0122e40>] (__warn+0xd0/0x10c)
+[   50.193391] [<c0122e40>] (__warn) from [<c0123238>] (warn_slowpath_fmt+0x98/0xc4)
+[   50.200892] [<c0123238>] (warn_slowpath_fmt) from [<c012b010>] (__local_bh_enable_ip+0x100/0x184)
+[   50.209860] [<c012b010>] (__local_bh_enable_ip) from [<bf09ecbc>] (destroy_conntrack+0x48/0xd8 [nf_conntrack])
+[   50.220038] [<bf09ecbc>] (destroy_conntrack [nf_conntrack]) from [<c0ac9b58>] (nf_conntrack_destroy+0x94/0x168)
+[   50.230160] [<c0ac9b58>] (nf_conntrack_destroy) from [<c0a4aaa0>] (skb_release_head_state+0xa0/0xd0)
+[   50.239314] [<c0a4aaa0>] (skb_release_head_state) from [<c0a4aadc>] (skb_release_all+0xc/0x24)
+[   50.247946] [<c0a4aadc>] (skb_release_all) from [<c0a4b4cc>] (consume_skb+0x74/0x17c)
+[   50.255796] [<c0a4b4cc>] (consume_skb) from [<c081a2dc>] (lan743x_tx_release_desc+0x120/0x124)
+[   50.264428] [<c081a2dc>] (lan743x_tx_release_desc) from [<c081a98c>] (lan743x_tx_napi_poll+0x5c/0x18c)
+[   50.273755] [<c081a98c>] (lan743x_tx_napi_poll) from [<c0a6b050>] (net_rx_action+0x118/0x4a4)
+[   50.282306] [<c0a6b050>] (net_rx_action) from [<c0101364>] (__do_softirq+0x13c/0x53c)
+[   50.290157] [<c0101364>] (__do_softirq) from [<c012b29c>] (irq_exit+0x150/0x17c)
+[   50.297575] [<c012b29c>] (irq_exit) from [<c0196a08>] (__handle_domain_irq+0x60/0xb0)
+[   50.305423] [<c0196a08>] (__handle_domain_irq) from [<c05d44fc>] (gic_handle_irq+0x4c/0x90)
+[   50.313790] [<c05d44fc>] (gic_handle_irq) from [<c0100ed4>] (__irq_usr+0x54/0x80)
+[   50.321287] Exception stack(0xecd99fb0 to 0xecd99ff8)
+[   50.326355] 9fa0:                                     1cf1aa74 00000001 00000001 00000000
+[   50.334547] 9fc0: 00000001 00000000 00000000 00000000 00000000 00000000 00004097 b6d17d14
+[   50.342738] 9fe0: 00000001 b6d17c60 00000000 b6e71f94 800b0010 ffffffff
+[   50.349364] irq event stamp: 2525027
+[   50.352955] hardirqs last  enabled at (2525026): [<c0a6afec>] net_rx_action+0xb4/0x4a4
+[   50.360892] hardirqs last disabled at (2525027): [<c0d6d2fc>] _raw_spin_lock_irqsave+0x1c/0x50
+[   50.369517] softirqs last  enabled at (2524660): [<c01015b4>] __do_softirq+0x38c/0x53c
+[   50.377446] softirqs last disabled at (2524693): [<c012b29c>] irq_exit+0x150/0x17c
+[   50.385027] ---[ end trace c0b571db4bc8087d ]---
+
+The driver is calling dev_kfree_skb() from code inside a spinlock,
+where h/w interrupts are disabled. This is forbidden, as documented
+in include/linux/netdevice.h. The correct function to use
+dev_kfree_skb_irq(), or dev_kfree_skb_any().
+
+Fix by using the correct dev_kfree_skb_xxx() functions:
+
+in lan743x_tx_release_desc():
+  called by lan743x_tx_release_completed_descriptors()
+    called by in lan743x_tx_napi_poll()
+    which holds a spinlock
+  called by lan743x_tx_release_all_descriptors()
+    called by lan743x_tx_close()
+    which can-sleep
+conclusion: use dev_kfree_skb_any()
+
+in lan743x_tx_xmit_frame():
+  which holds a spinlock
+conclusion: use dev_kfree_skb_irq()
+
+in lan743x_tx_close():
+  which can-sleep
+conclusion: use dev_kfree_skb()
+
+in lan743x_rx_release_ring_element():
+  called by lan743x_rx_close()
+    which can-sleep
+  called by lan743x_rx_open()
+    which can-sleep
+conclusion: use dev_kfree_skb()
+
+Fixes: 23f0703c125b ("lan743x: Add main source files for new lan743x driver")
+Signed-off-by: Sven Van Asbroeck <thesven73@gmail.com>
+Link: https://lore.kernel.org/r/20201112185949.11315-1-TheSven73@gmail.com
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/net/ethernet/microchip/lan743x_main.c |   10 +++++-----
+ 1 file changed, 5 insertions(+), 5 deletions(-)
+
+--- a/drivers/net/ethernet/microchip/lan743x_main.c
++++ b/drivers/net/ethernet/microchip/lan743x_main.c
+@@ -1245,13 +1245,13 @@ clean_up_data_descriptor:
+               goto clear_active;
+       if (!(buffer_info->flags & TX_BUFFER_INFO_FLAG_TIMESTAMP_REQUESTED)) {
+-              dev_kfree_skb(buffer_info->skb);
++              dev_kfree_skb_any(buffer_info->skb);
+               goto clear_skb;
+       }
+       if (cleanup) {
+               lan743x_ptp_unrequest_tx_timestamp(tx->adapter);
+-              dev_kfree_skb(buffer_info->skb);
++              dev_kfree_skb_any(buffer_info->skb);
+       } else {
+               ignore_sync = (buffer_info->flags &
+                              TX_BUFFER_INFO_FLAG_IGNORE_SYNC) != 0;
+@@ -1561,7 +1561,7 @@ static netdev_tx_t lan743x_tx_xmit_frame
+       if (required_number_of_descriptors >
+               lan743x_tx_get_avail_desc(tx)) {
+               if (required_number_of_descriptors > (tx->ring_size - 1)) {
+-                      dev_kfree_skb(skb);
++                      dev_kfree_skb_irq(skb);
+               } else {
+                       /* save to overflow buffer */
+                       tx->overflow_skb = skb;
+@@ -1594,7 +1594,7 @@ static netdev_tx_t lan743x_tx_xmit_frame
+                                  start_frame_length,
+                                  do_timestamp,
+                                  skb->ip_summed == CHECKSUM_PARTIAL)) {
+-              dev_kfree_skb(skb);
++              dev_kfree_skb_irq(skb);
+               goto unlock;
+       }
+@@ -1614,7 +1614,7 @@ static netdev_tx_t lan743x_tx_xmit_frame
+                        * frame assembler clean up was performed inside
+                        *      lan743x_tx_frame_add_fragment
+                        */
+-                      dev_kfree_skb(skb);
++                      dev_kfree_skb_irq(skb);
+                       goto unlock;
+               }
+       }
diff --git a/queue-4.19/lan743x-prevent-entire-kernel-hang-on-open-for-some-platforms.patch b/queue-4.19/lan743x-prevent-entire-kernel-hang-on-open-for-some-platforms.patch
new file mode 100644 (file)
index 0000000..76a110f
--- /dev/null
@@ -0,0 +1,65 @@
+From foo@baz Sun Nov 22 12:00:04 PM CET 2020
+From: Sven Van Asbroeck <thesven73@gmail.com>
+Date: Thu, 12 Nov 2020 15:47:41 -0500
+Subject: lan743x: prevent entire kernel HANG on open, for some platforms
+
+From: Sven Van Asbroeck <thesven73@gmail.com>
+
+[ Upstream commit 796a2665ca3e91ebaba7222f76fd9a035714e2d8 ]
+
+On arm imx6, when opening the chip's netdev, the whole Linux
+kernel intermittently hangs/freezes.
+
+This is caused by a bug in the driver code which tests if pcie
+interrupts are working correctly, using the software interrupt:
+
+1. open: enable the software interrupt
+2. open: tell the chip to assert the software interrupt
+3. open: wait for flag
+4. ISR: acknowledge s/w interrupt, set flag
+5. open: notice flag, disable the s/w interrupt, continue
+
+Unfortunately the ISR only acknowledges the s/w interrupt, but
+does not disable it. This will re-trigger the ISR in a tight
+loop.
+
+On some (lucky) platforms, open proceeds to disable the s/w
+interrupt even while the ISR is 'spinning'. On arm imx6,
+the spinning ISR does not allow open to proceed, resulting
+in a hung Linux kernel.
+
+Fix minimally by disabling the s/w interrupt in the ISR, which
+will prevent it from spinning. This won't break anything because
+the s/w interrupt is used as a one-shot interrupt.
+
+Note that this is a minimal fix, overlooking many possible
+cleanups, e.g.:
+- lan743x_intr_software_isr() is completely redundant and reads
+  INT_STS twice for no apparent reason
+- disabling the s/w interrupt in lan743x_intr_test_isr() is now
+  redundant, but harmless
+- waiting on software_isr_flag can be converted from a sleeping
+  poll loop to wait_event_timeout()
+
+Fixes: 23f0703c125b ("lan743x: Add main source files for new lan743x driver")
+Tested-by: Sven Van Asbroeck <thesven73@gmail.com> # arm imx6 lan7430
+Signed-off-by: Sven Van Asbroeck <thesven73@gmail.com>
+Link: https://lore.kernel.org/r/20201112204741.12375-1-TheSven73@gmail.com
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/net/ethernet/microchip/lan743x_main.c |    3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+--- a/drivers/net/ethernet/microchip/lan743x_main.c
++++ b/drivers/net/ethernet/microchip/lan743x_main.c
+@@ -145,7 +145,8 @@ static void lan743x_intr_software_isr(vo
+       int_sts = lan743x_csr_read(adapter, INT_STS);
+       if (int_sts & INT_BIT_SW_GP_) {
+-              lan743x_csr_write(adapter, INT_STS, INT_BIT_SW_GP_);
++              /* disable the interrupt to prevent repeated re-triggering */
++              lan743x_csr_write(adapter, INT_EN_CLR, INT_BIT_SW_GP_);
+               intr->software_isr_flag = 1;
+       }
+ }
diff --git a/queue-4.19/mlxsw-core-use-variable-timeout-for-emad-retries.patch b/queue-4.19/mlxsw-core-use-variable-timeout-for-emad-retries.patch
new file mode 100644 (file)
index 0000000..5e25a33
--- /dev/null
@@ -0,0 +1,43 @@
+From foo@baz Sun Nov 22 12:00:04 PM CET 2020
+From: Ido Schimmel <idosch@nvidia.com>
+Date: Tue, 17 Nov 2020 19:33:52 +0200
+Subject: mlxsw: core: Use variable timeout for EMAD retries
+
+From: Ido Schimmel <idosch@nvidia.com>
+
+[ Upstream commit 1f492eab67bced119a0ac7db75ef2047e29a30c6 ]
+
+The driver sends Ethernet Management Datagram (EMAD) packets to the
+device for configuration purposes and waits for up to 200ms for a reply.
+A request is retried up to 5 times.
+
+When the system is under heavy load, replies are not always processed in
+time and EMAD transactions fail.
+
+Make the process more robust to such delays by using exponential
+backoff. First wait for up to 200ms, then retransmit and wait for up to
+400ms and so on.
+
+Fixes: caf7297e7ab5 ("mlxsw: core: Introduce support for asynchronous EMAD register access")
+Reported-by: Denis Yulevich <denisyu@nvidia.com>
+Tested-by: Denis Yulevich <denisyu@nvidia.com>
+Signed-off-by: Ido Schimmel <idosch@nvidia.com>
+Reviewed-by: Jiri Pirko <jiri@nvidia.com>
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/net/ethernet/mellanox/mlxsw/core.c |    3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+--- a/drivers/net/ethernet/mellanox/mlxsw/core.c
++++ b/drivers/net/ethernet/mellanox/mlxsw/core.c
+@@ -439,7 +439,8 @@ static void mlxsw_emad_trans_timeout_sch
+       if (trans->core->fw_flash_in_progress)
+               timeout = msecs_to_jiffies(MLXSW_EMAD_TIMEOUT_DURING_FW_FLASH_MS);
+-      queue_delayed_work(trans->core->emad_wq, &trans->timeout_dw, timeout);
++      queue_delayed_work(trans->core->emad_wq, &trans->timeout_dw,
++                         timeout << trans->retries);
+ }
+ static int mlxsw_emad_transmit(struct mlxsw_core *mlxsw_core,
diff --git a/queue-4.19/net-b44-fix-error-return-code-in-b44_init_one.patch b/queue-4.19/net-b44-fix-error-return-code-in-b44_init_one.patch
new file mode 100644 (file)
index 0000000..1189124
--- /dev/null
@@ -0,0 +1,35 @@
+From foo@baz Sun Nov 22 12:00:04 PM CET 2020
+From: Zhang Changzhong <zhangchangzhong@huawei.com>
+Date: Tue, 17 Nov 2020 11:02:11 +0800
+Subject: net: b44: fix error return code in b44_init_one()
+
+From: Zhang Changzhong <zhangchangzhong@huawei.com>
+
+[ Upstream commit 7b027c249da54f492699c43e26cba486cfd48035 ]
+
+Fix to return a negative error code from the error handling
+case instead of 0, as done elsewhere in this function.
+
+Fixes: 39a6f4bce6b4 ("b44: replace the ssb_dma API with the generic DMA API")
+Reported-by: Hulk Robot <hulkci@huawei.com>
+Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
+Reviewed-by: Michael Chan <michael.chan@broadcom.com>
+Link: https://lore.kernel.org/r/1605582131-36735-1-git-send-email-zhangchangzhong@huawei.com
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/net/ethernet/broadcom/b44.c |    3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+--- a/drivers/net/ethernet/broadcom/b44.c
++++ b/drivers/net/ethernet/broadcom/b44.c
+@@ -2389,7 +2389,8 @@ static int b44_init_one(struct ssb_devic
+               goto err_out_free_dev;
+       }
+-      if (dma_set_mask_and_coherent(sdev->dma_dev, DMA_BIT_MASK(30))) {
++      err = dma_set_mask_and_coherent(sdev->dma_dev, DMA_BIT_MASK(30));
++      if (err) {
+               dev_err(sdev->dev,
+                       "Required 30BIT DMA mask unsupported by the system\n");
+               goto err_out_powerdown;
diff --git a/queue-4.19/net-bridge-add-missing-counters-to-ndo_get_stats64-callback.patch b/queue-4.19/net-bridge-add-missing-counters-to-ndo_get_stats64-callback.patch
new file mode 100644 (file)
index 0000000..15f47eb
--- /dev/null
@@ -0,0 +1,32 @@
+From foo@baz Sun Nov 22 12:00:04 PM CET 2020
+From: Heiner Kallweit <hkallweit1@gmail.com>
+Date: Fri, 13 Nov 2020 10:27:27 +0100
+Subject: net: bridge: add missing counters to ndo_get_stats64 callback
+
+From: Heiner Kallweit <hkallweit1@gmail.com>
+
+[ Upstream commit 7a30ecc9237681bb125cbd30eee92bef7e86293d ]
+
+In br_forward.c and br_input.c fields dev->stats.tx_dropped and
+dev->stats.multicast are populated, but they are ignored in
+ndo_get_stats64.
+
+Fixes: 28172739f0a2 ("net: fix 64 bit counters on 32 bit arches")
+Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
+Link: https://lore.kernel.org/r/58ea9963-77ad-a7cf-8dfd-fc95ab95f606@gmail.com
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ net/bridge/br_device.c |    1 +
+ 1 file changed, 1 insertion(+)
+
+--- a/net/bridge/br_device.c
++++ b/net/bridge/br_device.c
+@@ -215,6 +215,7 @@ static void br_get_stats64(struct net_de
+               sum.rx_packets += tmp.rx_packets;
+       }
++      netdev_stats_to_stats64(stats, &dev->stats);
+       stats->tx_bytes   = sum.tx_bytes;
+       stats->tx_packets = sum.tx_packets;
+       stats->rx_bytes   = sum.rx_bytes;
diff --git a/queue-4.19/net-dsa-mv88e6xxx-avoid-vtu-corruption-on-6097.patch b/queue-4.19/net-dsa-mv88e6xxx-avoid-vtu-corruption-on-6097.patch
new file mode 100644 (file)
index 0000000..d829ef3
--- /dev/null
@@ -0,0 +1,140 @@
+From foo@baz Sun Nov 22 12:00:04 PM CET 2020
+From: Tobias Waldekranz <tobias@waldekranz.com>
+Date: Thu, 12 Nov 2020 12:43:35 +0100
+Subject: net: dsa: mv88e6xxx: Avoid VTU corruption on 6097
+
+From: Tobias Waldekranz <tobias@waldekranz.com>
+
+[ Upstream commit 92307069a96c07d9b6e74b96b79390e7cd7d2111 ]
+
+As soon as you add the second port to a VLAN, all other port
+membership configuration is overwritten with zeroes. The HW interprets
+this as all ports being "unmodified members" of the VLAN.
+
+In the simple case when all ports belong to the same VLAN, switching
+will still work. But using multiple VLANs or trying to set multiple
+ports as tagged members will not work.
+
+On the 6352, doing a VTU GetNext op, followed by an STU GetNext op
+will leave you with both the member- and state- data in the VTU/STU
+data registers. But on the 6097 (which uses the same implementation),
+the STU GetNext will override the information gathered from the VTU
+GetNext.
+
+Separate the two stages, parsing the result of the VTU GetNext before
+doing the STU GetNext.
+
+We opt to update the existing implementation for all applicable chips,
+as opposed to creating a separate callback for 6097, because although
+the previous implementation did work for (at least) 6352, the
+datasheet does not mention the masking behavior.
+
+Fixes: ef6fcea37f01 ("net: dsa: mv88e6xxx: get STU entry on VTU GetNext")
+Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
+Link: https://lore.kernel.org/r/20201112114335.27371-1-tobias@waldekranz.com
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/net/dsa/mv88e6xxx/global1_vtu.c |   59 ++++++++++++++++++++++++++------
+ 1 file changed, 49 insertions(+), 10 deletions(-)
+
+--- a/drivers/net/dsa/mv88e6xxx/global1_vtu.c
++++ b/drivers/net/dsa/mv88e6xxx/global1_vtu.c
+@@ -127,11 +127,9 @@ static int mv88e6xxx_g1_vtu_vid_write(st
+  * Offset 0x08: VTU/STU Data Register 2
+  * Offset 0x09: VTU/STU Data Register 3
+  */
+-
+-static int mv88e6185_g1_vtu_data_read(struct mv88e6xxx_chip *chip,
+-                                    struct mv88e6xxx_vtu_entry *entry)
++static int mv88e6185_g1_vtu_stu_data_read(struct mv88e6xxx_chip *chip,
++                                        u16 *regs)
+ {
+-      u16 regs[3];
+       int i;
+       /* Read all 3 VTU/STU Data registers */
+@@ -144,12 +142,45 @@ static int mv88e6185_g1_vtu_data_read(st
+                       return err;
+       }
+-      /* Extract MemberTag and PortState data */
++      return 0;
++}
++
++static int mv88e6185_g1_vtu_data_read(struct mv88e6xxx_chip *chip,
++                                    struct mv88e6xxx_vtu_entry *entry)
++{
++      u16 regs[3];
++      int err;
++      int i;
++
++      err = mv88e6185_g1_vtu_stu_data_read(chip, regs);
++      if (err)
++              return err;
++
++      /* Extract MemberTag data */
+       for (i = 0; i < mv88e6xxx_num_ports(chip); ++i) {
+               unsigned int member_offset = (i % 4) * 4;
+-              unsigned int state_offset = member_offset + 2;
+               entry->member[i] = (regs[i / 4] >> member_offset) & 0x3;
++      }
++
++      return 0;
++}
++
++static int mv88e6185_g1_stu_data_read(struct mv88e6xxx_chip *chip,
++                                    struct mv88e6xxx_vtu_entry *entry)
++{
++      u16 regs[3];
++      int err;
++      int i;
++
++      err = mv88e6185_g1_vtu_stu_data_read(chip, regs);
++      if (err)
++              return err;
++
++      /* Extract PortState data */
++      for (i = 0; i < mv88e6xxx_num_ports(chip); ++i) {
++              unsigned int state_offset = (i % 4) * 4 + 2;
++
+               entry->state[i] = (regs[i / 4] >> state_offset) & 0x3;
+       }
+@@ -322,6 +353,10 @@ int mv88e6185_g1_vtu_getnext(struct mv88
+               if (err)
+                       return err;
++              err = mv88e6185_g1_stu_data_read(chip, entry);
++              if (err)
++                      return err;
++
+               /* VTU DBNum[3:0] are located in VTU Operation 3:0
+                * VTU DBNum[7:4] are located in VTU Operation 11:8
+                */
+@@ -347,16 +382,20 @@ int mv88e6352_g1_vtu_getnext(struct mv88
+               return err;
+       if (entry->valid) {
+-              /* Fetch (and mask) VLAN PortState data from the STU */
+-              err = mv88e6xxx_g1_vtu_stu_get(chip, entry);
++              err = mv88e6185_g1_vtu_data_read(chip, entry);
+               if (err)
+                       return err;
+-              err = mv88e6185_g1_vtu_data_read(chip, entry);
++              err = mv88e6xxx_g1_vtu_fid_read(chip, entry);
+               if (err)
+                       return err;
+-              err = mv88e6xxx_g1_vtu_fid_read(chip, entry);
++              /* Fetch VLAN PortState data from the STU */
++              err = mv88e6xxx_g1_vtu_stu_get(chip, entry);
++              if (err)
++                      return err;
++
++              err = mv88e6185_g1_stu_data_read(chip, entry);
+               if (err)
+                       return err;
+       }
diff --git a/queue-4.19/net-ftgmac100-fix-crash-when-removing-driver.patch b/queue-4.19/net-ftgmac100-fix-crash-when-removing-driver.patch
new file mode 100644 (file)
index 0000000..f1f75e2
--- /dev/null
@@ -0,0 +1,68 @@
+From foo@baz Sun Nov 22 11:49:14 AM CET 2020
+From: Joel Stanley <joel@jms.id.au>
+Date: Tue, 17 Nov 2020 13:14:48 +1030
+Subject: net: ftgmac100: Fix crash when removing driver
+
+From: Joel Stanley <joel@jms.id.au>
+
+[ Upstream commit 3d5179458d22dc0b4fdc724e4bed4231a655112a ]
+
+When removing the driver we would hit BUG_ON(!list_empty(&dev->ptype_specific))
+in net/core/dev.c due to still having the NC-SI packet handler
+registered.
+
+ # echo 1e660000.ethernet > /sys/bus/platform/drivers/ftgmac100/unbind
+  ------------[ cut here ]------------
+  kernel BUG at net/core/dev.c:10254!
+  Internal error: Oops - BUG: 0 [#1] SMP ARM
+  CPU: 0 PID: 115 Comm: sh Not tainted 5.10.0-rc3-next-20201111-00007-g02e0365710c4 #46
+  Hardware name: Generic DT based system
+  PC is at netdev_run_todo+0x314/0x394
+  LR is at cpumask_next+0x20/0x24
+  pc : [<806f5830>]    lr : [<80863cb0>]    psr: 80000153
+  sp : 855bbd58  ip : 00000001  fp : 855bbdac
+  r10: 80c03d00  r9 : 80c06228  r8 : 81158c54
+  r7 : 00000000  r6 : 80c05dec  r5 : 80c05d18  r4 : 813b9280
+  r3 : 813b9054  r2 : 8122c470  r1 : 00000002  r0 : 00000002
+  Flags: Nzcv  IRQs on  FIQs off  Mode SVC_32  ISA ARM  Segment none
+  Control: 00c5387d  Table: 85514008  DAC: 00000051
+  Process sh (pid: 115, stack limit = 0x7cb5703d)
+ ...
+  Backtrace:
+  [<806f551c>] (netdev_run_todo) from [<80707eec>] (rtnl_unlock+0x18/0x1c)
+   r10:00000051 r9:854ed710 r8:81158c54 r7:80c76bb0 r6:81158c10 r5:8115b410
+   r4:813b9000
+  [<80707ed4>] (rtnl_unlock) from [<806f5db8>] (unregister_netdev+0x2c/0x30)
+  [<806f5d8c>] (unregister_netdev) from [<805a8180>] (ftgmac100_remove+0x20/0xa8)
+   r5:8115b410 r4:813b9000
+  [<805a8160>] (ftgmac100_remove) from [<805355e4>] (platform_drv_remove+0x34/0x4c)
+
+Fixes: bd466c3fb5a4 ("net/faraday: Support NCSI mode")
+Signed-off-by: Joel Stanley <joel@jms.id.au>
+Link: https://lore.kernel.org/r/20201117024448.1170761-1-joel@jms.id.au
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/net/ethernet/faraday/ftgmac100.c |    4 ++++
+ 1 file changed, 4 insertions(+)
+
+--- a/drivers/net/ethernet/faraday/ftgmac100.c
++++ b/drivers/net/ethernet/faraday/ftgmac100.c
+@@ -1884,6 +1884,8 @@ static int ftgmac100_probe(struct platfo
+       return 0;
+ err_ncsi_dev:
++      if (priv->ndev)
++              ncsi_unregister_dev(priv->ndev);
+ err_register_netdev:
+       ftgmac100_destroy_mdio(netdev);
+ err_setup_mdio:
+@@ -1904,6 +1906,8 @@ static int ftgmac100_remove(struct platf
+       netdev = platform_get_drvdata(pdev);
+       priv = netdev_priv(netdev);
++      if (priv->ndev)
++              ncsi_unregister_dev(priv->ndev);
+       unregister_netdev(netdev);
+       clk_disable_unprepare(priv->clk);
diff --git a/queue-4.19/net-have-netpoll-bring-up-dsa-management-interface.patch b/queue-4.19/net-have-netpoll-bring-up-dsa-management-interface.patch
new file mode 100644 (file)
index 0000000..369505c
--- /dev/null
@@ -0,0 +1,81 @@
+From foo@baz Sun Nov 22 12:00:04 PM CET 2020
+From: Florian Fainelli <f.fainelli@gmail.com>
+Date: Mon, 16 Nov 2020 19:52:34 -0800
+Subject: net: Have netpoll bring-up DSA management interface
+
+From: Florian Fainelli <f.fainelli@gmail.com>
+
+[ Upstream commit 1532b9778478577152201adbafa7738b1e844868 ]
+
+DSA network devices rely on having their DSA management interface up and
+running otherwise their ndo_open() will return -ENETDOWN. Without doing
+this it would not be possible to use DSA devices as netconsole when
+configured on the command line. These devices also do not utilize the
+upper/lower linking so the check about the netpoll device having upper
+is not going to be a problem.
+
+The solution adopted here is identical to the one done for
+net/ipv4/ipconfig.c with 728c02089a0e ("net: ipv4: handle DSA enabled
+master network devices"), with the network namespace scope being
+restricted to that of the process configuring netpoll.
+
+Fixes: 04ff53f96a93 ("net: dsa: Add netconsole support")
+Tested-by: Vladimir Oltean <olteanv@gmail.com>
+Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
+Link: https://lore.kernel.org/r/20201117035236.22658-1-f.fainelli@gmail.com
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ net/core/netpoll.c |   22 ++++++++++++++++++----
+ 1 file changed, 18 insertions(+), 4 deletions(-)
+
+--- a/net/core/netpoll.c
++++ b/net/core/netpoll.c
+@@ -28,6 +28,7 @@
+ #include <linux/slab.h>
+ #include <linux/export.h>
+ #include <linux/if_vlan.h>
++#include <net/dsa.h>
+ #include <net/tcp.h>
+ #include <net/udp.h>
+ #include <net/addrconf.h>
+@@ -638,15 +639,15 @@ EXPORT_SYMBOL_GPL(__netpoll_setup);
+ int netpoll_setup(struct netpoll *np)
+ {
+-      struct net_device *ndev = NULL;
++      struct net_device *ndev = NULL, *dev = NULL;
++      struct net *net = current->nsproxy->net_ns;
+       struct in_device *in_dev;
+       int err;
+       rtnl_lock();
+-      if (np->dev_name[0]) {
+-              struct net *net = current->nsproxy->net_ns;
++      if (np->dev_name[0])
+               ndev = __dev_get_by_name(net, np->dev_name);
+-      }
++
+       if (!ndev) {
+               np_err(np, "%s doesn't exist, aborting\n", np->dev_name);
+               err = -ENODEV;
+@@ -654,6 +655,19 @@ int netpoll_setup(struct netpoll *np)
+       }
+       dev_hold(ndev);
++      /* bring up DSA management network devices up first */
++      for_each_netdev(net, dev) {
++              if (!netdev_uses_dsa(dev))
++                      continue;
++
++              err = dev_change_flags(dev, dev->flags | IFF_UP);
++              if (err < 0) {
++                      np_err(np, "%s failed to open %s\n",
++                             np->dev_name, dev->name);
++                      goto put;
++              }
++      }
++
+       if (netdev_master_upper_dev_get(ndev)) {
+               np_err(np, "%s is a slave device, aborting\n", np->dev_name);
+               err = -EBUSY;
diff --git a/queue-4.19/net-mlx4_core-fix-init_hca-fields-offset.patch b/queue-4.19/net-mlx4_core-fix-init_hca-fields-offset.patch
new file mode 100644 (file)
index 0000000..7e8d63d
--- /dev/null
@@ -0,0 +1,69 @@
+From foo@baz Sun Nov 22 12:00:04 PM CET 2020
+From: Aya Levin <ayal@nvidia.com>
+Date: Wed, 18 Nov 2020 10:19:22 +0200
+Subject: net/mlx4_core: Fix init_hca fields offset
+
+From: Aya Levin <ayal@nvidia.com>
+
+[ Upstream commit 6d9c8d15af0ef20a66a0b432cac0d08319920602 ]
+
+Slave function read the following capabilities from the wrong offset:
+1. log_mc_entry_sz
+2. fs_log_entry_sz
+3. log_mc_hash_sz
+
+Fix that by adjusting these capabilities offset to match firmware
+layout.
+
+Due to the wrong offset read, the following issues might occur:
+1+2. Negative value reported at max_mcast_qp_attach.
+3. Driver to init FW with multicast hash size of zero.
+
+Fixes: a40ded604365 ("net/mlx4_core: Add masking for a few queries on HCA caps")
+Signed-off-by: Aya Levin <ayal@nvidia.com>
+Reviewed-by: Moshe Shemesh <moshe@nvidia.com>
+Reviewed-by: Eran Ben Elisha <eranbe@nvidia.com>
+Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
+Link: https://lore.kernel.org/r/20201118081922.553-1-tariqt@nvidia.com
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/net/ethernet/mellanox/mlx4/fw.c |    6 +++---
+ drivers/net/ethernet/mellanox/mlx4/fw.h |    4 ++--
+ 2 files changed, 5 insertions(+), 5 deletions(-)
+
+--- a/drivers/net/ethernet/mellanox/mlx4/fw.c
++++ b/drivers/net/ethernet/mellanox/mlx4/fw.c
+@@ -1861,8 +1861,8 @@ int mlx4_INIT_HCA(struct mlx4_dev *dev,
+ #define        INIT_HCA_LOG_RD_OFFSET          (INIT_HCA_QPC_OFFSET + 0x77)
+ #define INIT_HCA_MCAST_OFFSET          0x0c0
+ #define        INIT_HCA_MC_BASE_OFFSET         (INIT_HCA_MCAST_OFFSET + 0x00)
+-#define        INIT_HCA_LOG_MC_ENTRY_SZ_OFFSET (INIT_HCA_MCAST_OFFSET + 0x12)
+-#define        INIT_HCA_LOG_MC_HASH_SZ_OFFSET  (INIT_HCA_MCAST_OFFSET + 0x16)
++#define        INIT_HCA_LOG_MC_ENTRY_SZ_OFFSET (INIT_HCA_MCAST_OFFSET + 0x13)
++#define        INIT_HCA_LOG_MC_HASH_SZ_OFFSET  (INIT_HCA_MCAST_OFFSET + 0x17)
+ #define  INIT_HCA_UC_STEERING_OFFSET   (INIT_HCA_MCAST_OFFSET + 0x18)
+ #define        INIT_HCA_LOG_MC_TABLE_SZ_OFFSET (INIT_HCA_MCAST_OFFSET + 0x1b)
+ #define  INIT_HCA_DEVICE_MANAGED_FLOW_STEERING_EN     0x6
+@@ -1870,7 +1870,7 @@ int mlx4_INIT_HCA(struct mlx4_dev *dev,
+ #define  INIT_HCA_DRIVER_VERSION_SZ       0x40
+ #define  INIT_HCA_FS_PARAM_OFFSET         0x1d0
+ #define  INIT_HCA_FS_BASE_OFFSET          (INIT_HCA_FS_PARAM_OFFSET + 0x00)
+-#define  INIT_HCA_FS_LOG_ENTRY_SZ_OFFSET  (INIT_HCA_FS_PARAM_OFFSET + 0x12)
++#define  INIT_HCA_FS_LOG_ENTRY_SZ_OFFSET  (INIT_HCA_FS_PARAM_OFFSET + 0x13)
+ #define  INIT_HCA_FS_A0_OFFSET                  (INIT_HCA_FS_PARAM_OFFSET + 0x18)
+ #define  INIT_HCA_FS_LOG_TABLE_SZ_OFFSET  (INIT_HCA_FS_PARAM_OFFSET + 0x1b)
+ #define  INIT_HCA_FS_ETH_BITS_OFFSET      (INIT_HCA_FS_PARAM_OFFSET + 0x21)
+--- a/drivers/net/ethernet/mellanox/mlx4/fw.h
++++ b/drivers/net/ethernet/mellanox/mlx4/fw.h
+@@ -182,8 +182,8 @@ struct mlx4_init_hca_param {
+       u64 cmpt_base;
+       u64 mtt_base;
+       u64 global_caps;
+-      u16 log_mc_entry_sz;
+-      u16 log_mc_hash_sz;
++      u8 log_mc_entry_sz;
++      u8 log_mc_hash_sz;
+       u16 hca_core_clock; /* Internal Clock Frequency (in MHz) */
+       u8  log_num_qps;
+       u8  log_num_srqs;
diff --git a/queue-4.19/net-mlx5-disable-qos-when-min_rates-on-all-vfs-are-zero.patch b/queue-4.19/net-mlx5-disable-qos-when-min_rates-on-all-vfs-are-zero.patch
new file mode 100644 (file)
index 0000000..7c187b1
--- /dev/null
@@ -0,0 +1,77 @@
+From foo@baz Sun Nov 22 12:00:04 PM CET 2020
+From: Vladyslav Tarasiuk <vladyslavt@nvidia.com>
+Date: Wed, 21 Oct 2020 11:05:41 +0300
+Subject: net/mlx5: Disable QoS when min_rates on all VFs are zero
+
+From: Vladyslav Tarasiuk <vladyslavt@nvidia.com>
+
+[ Upstream commit 470b74758260e4abc2508cf1614573c00a00465c ]
+
+Currently when QoS is enabled for VF and any min_rate is configured,
+the driver sets bw_share value to at least 1 and doesn’t allow to set
+it to 0 to make minimal rate unlimited. It means there is always a
+minimal rate configured for every VF, even if user tries to remove it.
+
+In order to make QoS disable possible, check whether all vports have
+configured min_rate = 0. If this is true, set their bw_share to 0 to
+disable min_rate limitations.
+
+Fixes: c9497c98901c ("net/mlx5: Add support for setting VF min rate")
+Signed-off-by: Vladyslav Tarasiuk <vladyslavt@nvidia.com>
+Reviewed-by: Moshe Shemesh <moshe@nvidia.com>
+Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/net/ethernet/mellanox/mlx5/core/eswitch.c |   15 ++++++++-------
+ 1 file changed, 8 insertions(+), 7 deletions(-)
+
+--- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
++++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
+@@ -1999,12 +1999,15 @@ static u32 calculate_vports_min_rate_div
+               max_guarantee = evport->info.min_rate;
+       }
+-      return max_t(u32, max_guarantee / fw_max_bw_share, 1);
++      if (max_guarantee)
++              return max_t(u32, max_guarantee / fw_max_bw_share, 1);
++      return 0;
+ }
+-static int normalize_vports_min_rate(struct mlx5_eswitch *esw, u32 divider)
++static int normalize_vports_min_rate(struct mlx5_eswitch *esw)
+ {
+       u32 fw_max_bw_share = MLX5_CAP_QOS(esw->dev, max_tsar_bw_share);
++      u32 divider = calculate_vports_min_rate_divider(esw);
+       struct mlx5_vport *evport;
+       u32 vport_max_rate;
+       u32 vport_min_rate;
+@@ -2018,9 +2021,9 @@ static int normalize_vports_min_rate(str
+                       continue;
+               vport_min_rate = evport->info.min_rate;
+               vport_max_rate = evport->info.max_rate;
+-              bw_share = MLX5_MIN_BW_SHARE;
++              bw_share = 0;
+-              if (vport_min_rate)
++              if (divider)
+                       bw_share = MLX5_RATE_TO_BW_SHARE(vport_min_rate,
+                                                        divider,
+                                                        fw_max_bw_share);
+@@ -2045,7 +2048,6 @@ int mlx5_eswitch_set_vport_rate(struct m
+       struct mlx5_vport *evport;
+       u32 fw_max_bw_share;
+       u32 previous_min_rate;
+-      u32 divider;
+       bool min_rate_supported;
+       bool max_rate_supported;
+       int err = 0;
+@@ -2071,8 +2073,7 @@ int mlx5_eswitch_set_vport_rate(struct m
+       previous_min_rate = evport->info.min_rate;
+       evport->info.min_rate = min_rate;
+-      divider = calculate_vports_min_rate_divider(esw);
+-      err = normalize_vports_min_rate(esw, divider);
++      err = normalize_vports_min_rate(esw);
+       if (err) {
+               evport->info.min_rate = previous_min_rate;
+               goto unlock;
diff --git a/queue-4.19/net-ncsi-fix-netlink-registration.patch b/queue-4.19/net-ncsi-fix-netlink-registration.patch
new file mode 100644 (file)
index 0000000..9bcf978
--- /dev/null
@@ -0,0 +1,129 @@
+From foo@baz Sun Nov 22 11:49:14 AM CET 2020
+From: Joel Stanley <joel@jms.id.au>
+Date: Thu, 12 Nov 2020 16:42:10 +1030
+Subject: net/ncsi: Fix netlink registration
+
+From: Joel Stanley <joel@jms.id.au>
+
+[ Upstream commit 1922a46b8c18cb09d33e06a6cc2e43844ac1b9d0 ]
+
+If a user unbinds and re-binds a NC-SI aware driver the kernel will
+attempt to register the netlink interface at runtime. The structure is
+marked __ro_after_init so registration fails spectacularly at this point.
+
+ # echo 1e660000.ethernet > /sys/bus/platform/drivers/ftgmac100/unbind
+ # echo 1e660000.ethernet > /sys/bus/platform/drivers/ftgmac100/bind
+  ftgmac100 1e660000.ethernet: Read MAC address 52:54:00:12:34:56 from chip
+  ftgmac100 1e660000.ethernet: Using NCSI interface
+  8<--- cut here ---
+  Unable to handle kernel paging request at virtual address 80a8f858
+  pgd = 8c768dd6
+  [80a8f858] *pgd=80a0841e(bad)
+  Internal error: Oops: 80d [#1] SMP ARM
+  CPU: 0 PID: 116 Comm: sh Not tainted 5.10.0-rc3-next-20201111-00003-gdd25b227ec1e #51
+  Hardware name: Generic DT based system
+  PC is at genl_register_family+0x1f8/0x6d4
+  LR is at 0xff26ffff
+  pc : [<8073f930>]    lr : [<ff26ffff>]    psr: 20000153
+  sp : 8553bc80  ip : 81406244  fp : 8553bd04
+  r10: 8085d12c  r9 : 80a8f73c  r8 : 85739000
+  r7 : 00000017  r6 : 80a8f860  r5 : 80c8ab98  r4 : 80a8f858
+  r3 : 00000000  r2 : 00000000  r1 : 81406130  r0 : 00000017
+  Flags: nzCv  IRQs on  FIQs off  Mode SVC_32  ISA ARM  Segment none
+  Control: 00c5387d  Table: 85524008  DAC: 00000051
+  Process sh (pid: 116, stack limit = 0x1f1988d6)
+ ...
+  Backtrace:
+  [<8073f738>] (genl_register_family) from [<80860ac0>] (ncsi_init_netlink+0x20/0x48)
+   r10:8085d12c r9:80c8fb0c r8:85739000 r7:00000000 r6:81218000 r5:85739000
+   r4:8121c000
+  [<80860aa0>] (ncsi_init_netlink) from [<8085d740>] (ncsi_register_dev+0x1b0/0x210)
+   r5:8121c400 r4:8121c000
+  [<8085d590>] (ncsi_register_dev) from [<805a8060>] (ftgmac100_probe+0x6e0/0x778)
+   r10:00000004 r9:80950228 r8:8115bc10 r7:8115ab00 r6:9eae2c24 r5:813b6f88
+   r4:85739000
+  [<805a7980>] (ftgmac100_probe) from [<805355ec>] (platform_drv_probe+0x58/0xa8)
+   r9:80c76bb0 r8:00000000 r7:80cd4974 r6:80c76bb0 r5:8115bc10 r4:00000000
+  [<80535594>] (platform_drv_probe) from [<80532d58>] (really_probe+0x204/0x514)
+   r7:80cd4974 r6:00000000 r5:80cd4868 r4:8115bc10
+
+Jakub pointed out that ncsi_register_dev is obviously broken, because
+there is only one family so it would never work if there was more than
+one ncsi netdev.
+
+Fix the crash by registering the netlink family once on boot, and drop
+the code to unregister it.
+
+Fixes: 955dc68cb9b2 ("net/ncsi: Add generic netlink family")
+Signed-off-by: Joel Stanley <joel@jms.id.au>
+Reviewed-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>
+Link: https://lore.kernel.org/r/20201112061210.914621-1-joel@jms.id.au
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ net/ncsi/ncsi-manage.c  |    5 -----
+ net/ncsi/ncsi-netlink.c |   22 +++-------------------
+ net/ncsi/ncsi-netlink.h |    3 ---
+ 3 files changed, 3 insertions(+), 27 deletions(-)
+
+--- a/net/ncsi/ncsi-manage.c
++++ b/net/ncsi/ncsi-manage.c
+@@ -1484,9 +1484,6 @@ struct ncsi_dev *ncsi_register_dev(struc
+       ndp->ptype.dev = dev;
+       dev_add_pack(&ndp->ptype);
+-      /* Set up generic netlink interface */
+-      ncsi_init_netlink(dev);
+-
+       return nd;
+ }
+ EXPORT_SYMBOL_GPL(ncsi_register_dev);
+@@ -1566,8 +1563,6 @@ void ncsi_unregister_dev(struct ncsi_dev
+ #endif
+       spin_unlock_irqrestore(&ncsi_dev_lock, flags);
+-      ncsi_unregister_netlink(nd->dev);
+-
+       kfree(ndp);
+ }
+ EXPORT_SYMBOL_GPL(ncsi_unregister_dev);
+--- a/net/ncsi/ncsi-netlink.c
++++ b/net/ncsi/ncsi-netlink.c
+@@ -397,24 +397,8 @@ static struct genl_family ncsi_genl_fami
+       .n_ops = ARRAY_SIZE(ncsi_ops),
+ };
+-int ncsi_init_netlink(struct net_device *dev)
++static int __init ncsi_init_netlink(void)
+ {
+-      int rc;
+-
+-      rc = genl_register_family(&ncsi_genl_family);
+-      if (rc)
+-              netdev_err(dev, "ncsi: failed to register netlink family\n");
+-
+-      return rc;
+-}
+-
+-int ncsi_unregister_netlink(struct net_device *dev)
+-{
+-      int rc;
+-
+-      rc = genl_unregister_family(&ncsi_genl_family);
+-      if (rc)
+-              netdev_err(dev, "ncsi: failed to unregister netlink family\n");
+-
+-      return rc;
++      return genl_register_family(&ncsi_genl_family);
+ }
++subsys_initcall(ncsi_init_netlink);
+--- a/net/ncsi/ncsi-netlink.h
++++ b/net/ncsi/ncsi-netlink.h
+@@ -14,7 +14,4 @@
+ #include "internal.h"
+-int ncsi_init_netlink(struct net_device *dev);
+-int ncsi_unregister_netlink(struct net_device *dev);
+-
+ #endif /* __NCSI_NETLINK_H__ */
diff --git a/queue-4.19/net-qualcomm-rmnet-fix-incorrect-receive-packet-handling-during-cleanup.patch b/queue-4.19/net-qualcomm-rmnet-fix-incorrect-receive-packet-handling-during-cleanup.patch
new file mode 100644 (file)
index 0000000..d1c6521
--- /dev/null
@@ -0,0 +1,54 @@
+From foo@baz Sun Nov 22 12:00:04 PM CET 2020
+From: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
+Date: Fri, 13 Nov 2020 13:12:05 -0700
+Subject: net: qualcomm: rmnet: Fix incorrect receive packet handling during cleanup
+
+From: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
+
+[ Upstream commit fc70f5bf5e525dde81565f0a30d5e39168062eba ]
+
+During rmnet unregistration, the real device rx_handler is first cleared
+followed by the removal of rx_handler_data after the rcu synchronization.
+
+Any packets in the receive path may observe that the rx_handler is NULL.
+However, there is no check when dereferencing this value to use the
+rmnet_port information.
+
+This fixes following splat by adding the NULL check.
+
+Unable to handle kernel NULL pointer dereference at virtual
+address 000000000000000d
+pc : rmnet_rx_handler+0x124/0x284
+lr : rmnet_rx_handler+0x124/0x284
+ rmnet_rx_handler+0x124/0x284
+ __netif_receive_skb_core+0x758/0xd74
+ __netif_receive_skb+0x50/0x17c
+ process_backlog+0x15c/0x1b8
+ napi_poll+0x88/0x284
+ net_rx_action+0xbc/0x23c
+ __do_softirq+0x20c/0x48c
+
+Fixes: ceed73a2cf4a ("drivers: net: ethernet: qualcomm: rmnet: Initial implementation")
+Signed-off-by: Sean Tranchetti <stranche@codeaurora.org>
+Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
+Link: https://lore.kernel.org/r/1605298325-3705-1-git-send-email-subashab@codeaurora.org
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c |    5 +++++
+ 1 file changed, 5 insertions(+)
+
+--- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c
++++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c
+@@ -197,6 +197,11 @@ rx_handler_result_t rmnet_rx_handler(str
+       dev = skb->dev;
+       port = rmnet_get_port_rcu(dev);
++      if (unlikely(!port)) {
++              atomic_long_inc(&skb->dev->rx_nohandler);
++              kfree_skb(skb);
++              goto done;
++      }
+       switch (port->rmnet_mode) {
+       case RMNET_EPMODE_VND:
diff --git a/queue-4.19/net-usb-qmi_wwan-set-dtr-quirk-for-mr400.patch b/queue-4.19/net-usb-qmi_wwan-set-dtr-quirk-for-mr400.patch
new file mode 100644 (file)
index 0000000..8dfee72
--- /dev/null
@@ -0,0 +1,31 @@
+From foo@baz Sun Nov 22 12:00:04 PM CET 2020
+From: Filip Moc <dev@moc6.cz>
+Date: Tue, 17 Nov 2020 18:36:31 +0100
+Subject: net: usb: qmi_wwan: Set DTR quirk for MR400
+
+From: Filip Moc <dev@moc6.cz>
+
+[ Upstream commit df8d85d8c69d6837817e54dcb73c84a8b5a13877 ]
+
+LTE module MR400 embedded in TL-MR6400 v4 requires DTR to be set.
+
+Signed-off-by: Filip Moc <dev@moc6.cz>
+Acked-by: BjĆørn Mork <bjorn@mork.no>
+Link: https://lore.kernel.org/r/20201117173631.GA550981@moc6.cz
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/net/usb/qmi_wwan.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/drivers/net/usb/qmi_wwan.c
++++ b/drivers/net/usb/qmi_wwan.c
+@@ -1029,7 +1029,7 @@ static const struct usb_device_id produc
+       {QMI_FIXED_INTF(0x05c6, 0x9011, 4)},
+       {QMI_FIXED_INTF(0x05c6, 0x9021, 1)},
+       {QMI_FIXED_INTF(0x05c6, 0x9022, 2)},
+-      {QMI_FIXED_INTF(0x05c6, 0x9025, 4)},    /* Alcatel-sbell ASB TL131 TDD LTE  (China Mobile) */
++      {QMI_QUIRK_SET_DTR(0x05c6, 0x9025, 4)}, /* Alcatel-sbell ASB TL131 TDD LTE (China Mobile) */
+       {QMI_FIXED_INTF(0x05c6, 0x9026, 3)},
+       {QMI_FIXED_INTF(0x05c6, 0x902e, 5)},
+       {QMI_FIXED_INTF(0x05c6, 0x9031, 5)},
diff --git a/queue-4.19/net-x25-increase-refcnt-of-struct-x25_neigh-in-x25_rx_call_request.patch b/queue-4.19/net-x25-increase-refcnt-of-struct-x25_neigh-in-x25_rx_call_request.patch
new file mode 100644 (file)
index 0000000..982822c
--- /dev/null
@@ -0,0 +1,41 @@
+From foo@baz Sun Nov 22 12:00:04 PM CET 2020
+From: Xie He <xie.he.0141@gmail.com>
+Date: Thu, 12 Nov 2020 02:35:06 -0800
+Subject: net: x25: Increase refcnt of "struct x25_neigh" in x25_rx_call_request
+
+From: Xie He <xie.he.0141@gmail.com>
+
+[ Upstream commit 4ee18c179e5e815fa5575e0d2db0c05795a804ee ]
+
+The x25_disconnect function in x25_subr.c would decrease the refcount of
+"x25->neighbour" (struct x25_neigh) and reset this pointer to NULL.
+
+However, the x25_rx_call_request function in af_x25.c, which is called
+when we receive a connection request, does not increase the refcount when
+it assigns the pointer.
+
+Fix this issue by increasing the refcount of "struct x25_neigh" in
+x25_rx_call_request.
+
+This patch fixes frequent kernel crashes when using AF_X25 sockets.
+
+Fixes: 4becb7ee5b3d ("net/x25: Fix x25_neigh refcnt leak when x25 disconnect")
+Cc: Martin Schiller <ms@dev.tdt.de>
+Signed-off-by: Xie He <xie.he.0141@gmail.com>
+Link: https://lore.kernel.org/r/20201112103506.5875-1-xie.he.0141@gmail.com
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ net/x25/af_x25.c |    1 +
+ 1 file changed, 1 insertion(+)
+
+--- a/net/x25/af_x25.c
++++ b/net/x25/af_x25.c
+@@ -1049,6 +1049,7 @@ int x25_rx_call_request(struct sk_buff *
+       makex25->lci           = lci;
+       makex25->dest_addr     = dest_addr;
+       makex25->source_addr   = source_addr;
++      x25_neigh_hold(nb);
+       makex25->neighbour     = nb;
+       makex25->facilities    = facilities;
+       makex25->dte_facilities= dte_facilities;
diff --git a/queue-4.19/netlabel-fix-an-uninitialized-warning-in-netlbl_unlabel_staticlist.patch b/queue-4.19/netlabel-fix-an-uninitialized-warning-in-netlbl_unlabel_staticlist.patch
new file mode 100644 (file)
index 0000000..5ea182e
--- /dev/null
@@ -0,0 +1,35 @@
+From foo@baz Sun Nov 22 12:00:04 PM CET 2020
+From: Paul Moore <paul@paul-moore.com>
+Date: Fri, 13 Nov 2020 16:30:40 -0500
+Subject: netlabel: fix an uninitialized warning in netlbl_unlabel_staticlist()
+
+From: Paul Moore <paul@paul-moore.com>
+
+[ Upstream commit 1ba86d4366e023d96df3dbe415eea7f1dc08c303 ]
+
+Static checking revealed that a previous fix to
+netlbl_unlabel_staticlist() leaves a stack variable uninitialized,
+this patches fixes that.
+
+Fixes: 866358ec331f ("netlabel: fix our progress tracking in netlbl_unlabel_staticlist()")
+Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
+Signed-off-by: Paul Moore <paul@paul-moore.com>
+Reviewed-by: James Morris <jamorris@linux.microsoft.com>
+Link: https://lore.kernel.org/r/160530304068.15651.18355773009751195447.stgit@sifl
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ net/netlabel/netlabel_unlabeled.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/net/netlabel/netlabel_unlabeled.c
++++ b/net/netlabel/netlabel_unlabeled.c
+@@ -1180,7 +1180,7 @@ static int netlbl_unlabel_staticlist(str
+       u32 skip_bkt = cb->args[0];
+       u32 skip_chain = cb->args[1];
+       u32 skip_addr4 = cb->args[2];
+-      u32 iter_bkt, iter_chain, iter_addr4 = 0, iter_addr6 = 0;
++      u32 iter_bkt, iter_chain = 0, iter_addr4 = 0, iter_addr6 = 0;
+       struct netlbl_unlhsh_iface *iface;
+       struct list_head *iter_list;
+       struct netlbl_af4list *addr4;
diff --git a/queue-4.19/netlabel-fix-our-progress-tracking-in-netlbl_unlabel_staticlist.patch b/queue-4.19/netlabel-fix-our-progress-tracking-in-netlbl_unlabel_staticlist.patch
new file mode 100644 (file)
index 0000000..6543387
--- /dev/null
@@ -0,0 +1,89 @@
+From foo@baz Sun Nov 22 12:00:04 PM CET 2020
+From: Paul Moore <paul@paul-moore.com>
+Date: Sun, 8 Nov 2020 09:08:26 -0500
+Subject: netlabel: fix our progress tracking in netlbl_unlabel_staticlist()
+
+From: Paul Moore <paul@paul-moore.com>
+
+[ Upstream commit 866358ec331f8faa394995fb4b511af1db0247c8 ]
+
+The current NetLabel code doesn't correctly keep track of the netlink
+dump state in some cases, in particular when multiple interfaces with
+large configurations are loaded.  The problem manifests itself by not
+reporting the full configuration to userspace, even though it is
+loaded and active in the kernel.  This patch fixes this by ensuring
+that the dump state is properly reset when necessary inside the
+netlbl_unlabel_staticlist() function.
+
+Fixes: 8cc44579d1bd ("NetLabel: Introduce static network labels for unlabeled connections")
+Signed-off-by: Paul Moore <paul@paul-moore.com>
+Link: https://lore.kernel.org/r/160484450633.3752.16512718263560813473.stgit@sifl
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ net/netlabel/netlabel_unlabeled.c |   17 ++++++++++++-----
+ 1 file changed, 12 insertions(+), 5 deletions(-)
+
+--- a/net/netlabel/netlabel_unlabeled.c
++++ b/net/netlabel/netlabel_unlabeled.c
+@@ -1179,12 +1179,13 @@ static int netlbl_unlabel_staticlist(str
+       struct netlbl_unlhsh_walk_arg cb_arg;
+       u32 skip_bkt = cb->args[0];
+       u32 skip_chain = cb->args[1];
+-      u32 iter_bkt;
+-      u32 iter_chain = 0, iter_addr4 = 0, iter_addr6 = 0;
++      u32 skip_addr4 = cb->args[2];
++      u32 iter_bkt, iter_chain, iter_addr4 = 0, iter_addr6 = 0;
+       struct netlbl_unlhsh_iface *iface;
+       struct list_head *iter_list;
+       struct netlbl_af4list *addr4;
+ #if IS_ENABLED(CONFIG_IPV6)
++      u32 skip_addr6 = cb->args[3];
+       struct netlbl_af6list *addr6;
+ #endif
+@@ -1195,7 +1196,7 @@ static int netlbl_unlabel_staticlist(str
+       rcu_read_lock();
+       for (iter_bkt = skip_bkt;
+            iter_bkt < rcu_dereference(netlbl_unlhsh)->size;
+-           iter_bkt++, iter_chain = 0, iter_addr4 = 0, iter_addr6 = 0) {
++           iter_bkt++) {
+               iter_list = &rcu_dereference(netlbl_unlhsh)->tbl[iter_bkt];
+               list_for_each_entry_rcu(iface, iter_list, list) {
+                       if (!iface->valid ||
+@@ -1203,7 +1204,7 @@ static int netlbl_unlabel_staticlist(str
+                               continue;
+                       netlbl_af4list_foreach_rcu(addr4,
+                                                  &iface->addr4_list) {
+-                              if (iter_addr4++ < cb->args[2])
++                              if (iter_addr4++ < skip_addr4)
+                                       continue;
+                               if (netlbl_unlabel_staticlist_gen(
+                                             NLBL_UNLABEL_C_STATICLIST,
+@@ -1216,10 +1217,12 @@ static int netlbl_unlabel_staticlist(str
+                                       goto unlabel_staticlist_return;
+                               }
+                       }
++                      iter_addr4 = 0;
++                      skip_addr4 = 0;
+ #if IS_ENABLED(CONFIG_IPV6)
+                       netlbl_af6list_foreach_rcu(addr6,
+                                                  &iface->addr6_list) {
+-                              if (iter_addr6++ < cb->args[3])
++                              if (iter_addr6++ < skip_addr6)
+                                       continue;
+                               if (netlbl_unlabel_staticlist_gen(
+                                             NLBL_UNLABEL_C_STATICLIST,
+@@ -1232,8 +1235,12 @@ static int netlbl_unlabel_staticlist(str
+                                       goto unlabel_staticlist_return;
+                               }
+                       }
++                      iter_addr6 = 0;
++                      skip_addr6 = 0;
+ #endif /* IPv6 */
+               }
++              iter_chain = 0;
++              skip_chain = 0;
+       }
+ unlabel_staticlist_return:
diff --git a/queue-4.19/page_frag-recover-from-memory-pressure.patch b/queue-4.19/page_frag-recover-from-memory-pressure.patch
new file mode 100644 (file)
index 0000000..72d6967
--- /dev/null
@@ -0,0 +1,80 @@
+From foo@baz Sun Nov 22 12:00:04 PM CET 2020
+From: Dongli Zhang <dongli.zhang@oracle.com>
+Date: Sun, 15 Nov 2020 12:10:29 -0800
+Subject: page_frag: Recover from memory pressure
+
+From: Dongli Zhang <dongli.zhang@oracle.com>
+
+[ Upstream commit d8c19014bba8f565d8a2f1f46b4e38d1d97bf1a7 ]
+
+The ethernet driver may allocate skb (and skb->data) via napi_alloc_skb().
+This ends up to page_frag_alloc() to allocate skb->data from
+page_frag_cache->va.
+
+During the memory pressure, page_frag_cache->va may be allocated as
+pfmemalloc page. As a result, the skb->pfmemalloc is always true as
+skb->data is from page_frag_cache->va. The skb will be dropped if the
+sock (receiver) does not have SOCK_MEMALLOC. This is expected behaviour
+under memory pressure.
+
+However, once kernel is not under memory pressure any longer (suppose large
+amount of memory pages are just reclaimed), the page_frag_alloc() may still
+re-use the prior pfmemalloc page_frag_cache->va to allocate skb->data. As a
+result, the skb->pfmemalloc is always true unless page_frag_cache->va is
+re-allocated, even if the kernel is not under memory pressure any longer.
+
+Here is how kernel runs into issue.
+
+1. The kernel is under memory pressure and allocation of
+PAGE_FRAG_CACHE_MAX_ORDER in __page_frag_cache_refill() will fail. Instead,
+the pfmemalloc page is allocated for page_frag_cache->va.
+
+2: All skb->data from page_frag_cache->va (pfmemalloc) will have
+skb->pfmemalloc=true. The skb will always be dropped by sock without
+SOCK_MEMALLOC. This is an expected behaviour.
+
+3. Suppose a large amount of pages are reclaimed and kernel is not under
+memory pressure any longer. We expect skb->pfmemalloc drop will not happen.
+
+4. Unfortunately, page_frag_alloc() does not proactively re-allocate
+page_frag_alloc->va and will always re-use the prior pfmemalloc page. The
+skb->pfmemalloc is always true even kernel is not under memory pressure any
+longer.
+
+Fix this by freeing and re-allocating the page instead of recycling it.
+
+References: https://lore.kernel.org/lkml/20201103193239.1807-1-dongli.zhang@oracle.com/
+References: https://lore.kernel.org/linux-mm/20201105042140.5253-1-willy@infradead.org/
+Suggested-by: Matthew Wilcox (Oracle) <willy@infradead.org>
+Cc: Aruna Ramakrishna <aruna.ramakrishna@oracle.com>
+Cc: Bert Barbe <bert.barbe@oracle.com>
+Cc: Rama Nichanamatlu <rama.nichanamatlu@oracle.com>
+Cc: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
+Cc: Manjunath Patil <manjunath.b.patil@oracle.com>
+Cc: Joe Jin <joe.jin@oracle.com>
+Cc: SRINIVAS <srinivas.eeda@oracle.com>
+Fixes: 79930f5892e1 ("net: do not deplete pfmemalloc reserve")
+Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
+Acked-by: Vlastimil Babka <vbabka@suse.cz>
+Reviewed-by: Eric Dumazet <edumazet@google.com>
+Link: https://lore.kernel.org/r/20201115201029.11903-1-dongli.zhang@oracle.com
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ mm/page_alloc.c |    5 +++++
+ 1 file changed, 5 insertions(+)
+
+--- a/mm/page_alloc.c
++++ b/mm/page_alloc.c
+@@ -4554,6 +4554,11 @@ refill:
+               if (!page_ref_sub_and_test(page, nc->pagecnt_bias))
+                       goto refill;
++              if (unlikely(nc->pfmemalloc)) {
++                      free_the_page(page, compound_order(page));
++                      goto refill;
++              }
++
+ #if (PAGE_SIZE < PAGE_FRAG_CACHE_MAX_SIZE)
+               /* if size can vary use size else just use PAGE_SIZE */
+               size = nc->size;
diff --git a/queue-4.19/qed-fix-error-return-code-in-qed_iwarp_ll2_start.patch b/queue-4.19/qed-fix-error-return-code-in-qed_iwarp_ll2_start.patch
new file mode 100644 (file)
index 0000000..af47781
--- /dev/null
@@ -0,0 +1,60 @@
+From foo@baz Sun Nov 22 12:00:04 PM CET 2020
+From: Zhang Changzhong <zhangchangzhong@huawei.com>
+Date: Mon, 16 Nov 2020 21:07:13 +0800
+Subject: qed: fix error return code in qed_iwarp_ll2_start()
+
+From: Zhang Changzhong <zhangchangzhong@huawei.com>
+
+[ Upstream commit cb47d16ea21045c66eebbf5ed792e74a8537e27a ]
+
+Fix to return a negative error code from the error handling
+case instead of 0, as done elsewhere in this function.
+
+Fixes: 469981b17a4f ("qed: Add unaligned and packed packet processing")
+Fixes: fcb39f6c10b2 ("qed: Add mpa buffer descriptors for storing and processing mpa fpdus")
+Fixes: 1e28eaad07ea ("qed: Add iWARP support for fpdu spanned over more than two tcp packets")
+Reported-by: Hulk Robot <hulkci@huawei.com>
+Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
+Acked-by: Michal KalderonĀ <michal.kalderon@marvell.com>
+Link: https://lore.kernel.org/r/1605532033-27373-1-git-send-email-zhangchangzhong@huawei.com
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/net/ethernet/qlogic/qed/qed_iwarp.c |   12 +++++++++---
+ 1 file changed, 9 insertions(+), 3 deletions(-)
+
+--- a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
++++ b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
+@@ -2737,14 +2737,18 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_h
+       iwarp_info->partial_fpdus = kcalloc((u16)p_hwfn->p_rdma_info->num_qps,
+                                           sizeof(*iwarp_info->partial_fpdus),
+                                           GFP_KERNEL);
+-      if (!iwarp_info->partial_fpdus)
++      if (!iwarp_info->partial_fpdus) {
++              rc = -ENOMEM;
+               goto err;
++      }
+       iwarp_info->max_num_partial_fpdus = (u16)p_hwfn->p_rdma_info->num_qps;
+       iwarp_info->mpa_intermediate_buf = kzalloc(buff_size, GFP_KERNEL);
+-      if (!iwarp_info->mpa_intermediate_buf)
++      if (!iwarp_info->mpa_intermediate_buf) {
++              rc = -ENOMEM;
+               goto err;
++      }
+       /* The mpa_bufs array serves for pending RX packets received on the
+        * mpa ll2 that don't have place on the tx ring and require later
+@@ -2754,8 +2758,10 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_h
+       iwarp_info->mpa_bufs = kcalloc(data.input.rx_num_desc,
+                                      sizeof(*iwarp_info->mpa_bufs),
+                                      GFP_KERNEL);
+-      if (!iwarp_info->mpa_bufs)
++      if (!iwarp_info->mpa_bufs) {
++              rc = -ENOMEM;
+               goto err;
++      }
+       INIT_LIST_HEAD(&iwarp_info->mpa_buf_pending_list);
+       INIT_LIST_HEAD(&iwarp_info->mpa_buf_list);
diff --git a/queue-4.19/qlcnic-fix-error-return-code-in-qlcnic_83xx_restart_hw.patch b/queue-4.19/qlcnic-fix-error-return-code-in-qlcnic_83xx_restart_hw.patch
new file mode 100644 (file)
index 0000000..b7fbecb
--- /dev/null
@@ -0,0 +1,34 @@
+From foo@baz Sun Nov 22 12:00:04 PM CET 2020
+From: Zhang Changzhong <zhangchangzhong@huawei.com>
+Date: Fri, 13 Nov 2020 14:16:26 +0800
+Subject: qlcnic: fix error return code in qlcnic_83xx_restart_hw()
+
+From: Zhang Changzhong <zhangchangzhong@huawei.com>
+
+[ Upstream commit 3beb9be165083c2964eba1923601c3bfac0b02d4 ]
+
+Fix to return a negative error code from the error handling
+case instead of 0, as done elsewhere in this function.
+
+Fixes: 3ced0a88cd4c ("qlcnic: Add support to run firmware POST")
+Reported-by: Hulk Robot <hulkci@huawei.com>
+Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
+Link: https://lore.kernel.org/r/1605248186-16013-1-git-send-email-zhangchangzhong@huawei.com
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c |    3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
++++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
+@@ -2251,7 +2251,8 @@ static int qlcnic_83xx_restart_hw(struct
+       /* Boot either flash image or firmware image from host file system */
+       if (qlcnic_load_fw_file == 1) {
+-              if (qlcnic_83xx_load_fw_image_from_host(adapter))
++              err = qlcnic_83xx_load_fw_image_from_host(adapter);
++              if (err)
+                       return err;
+       } else {
+               QLC_SHARED_REG_WR32(adapter, QLCNIC_FW_IMG_VALID,
diff --git a/queue-4.19/sctp-change-to-hold-put-transport-for-proto_unreach_timer.patch b/queue-4.19/sctp-change-to-hold-put-transport-for-proto_unreach_timer.patch
new file mode 100644 (file)
index 0000000..3b5479f
--- /dev/null
@@ -0,0 +1,102 @@
+From foo@baz Sun Nov 22 12:00:04 PM CET 2020
+From: Xin Long <lucien.xin@gmail.com>
+Date: Sat, 14 Nov 2020 13:22:53 +0800
+Subject: sctp: change to hold/put transport for proto_unreach_timer
+
+From: Xin Long <lucien.xin@gmail.com>
+
+[ Upstream commit 057a10fa1f73d745c8e69aa54ab147715f5630ae ]
+
+A call trace was found in Hangbin's Codenomicon testing with debug kernel:
+
+  [ 2615.981988] ODEBUG: free active (active state 0) object type: timer_list hint: sctp_generate_proto_unreach_event+0x0/0x3a0 [sctp]
+  [ 2615.995050] WARNING: CPU: 17 PID: 0 at lib/debugobjects.c:328 debug_print_object+0x199/0x2b0
+  [ 2616.095934] RIP: 0010:debug_print_object+0x199/0x2b0
+  [ 2616.191533] Call Trace:
+  [ 2616.194265]  <IRQ>
+  [ 2616.202068]  debug_check_no_obj_freed+0x25e/0x3f0
+  [ 2616.207336]  slab_free_freelist_hook+0xeb/0x140
+  [ 2616.220971]  kfree+0xd6/0x2c0
+  [ 2616.224293]  rcu_do_batch+0x3bd/0xc70
+  [ 2616.243096]  rcu_core+0x8b9/0xd00
+  [ 2616.256065]  __do_softirq+0x23d/0xacd
+  [ 2616.260166]  irq_exit+0x236/0x2a0
+  [ 2616.263879]  smp_apic_timer_interrupt+0x18d/0x620
+  [ 2616.269138]  apic_timer_interrupt+0xf/0x20
+  [ 2616.273711]  </IRQ>
+
+This is because it holds asoc when transport->proto_unreach_timer starts
+and puts asoc when the timer stops, and without holding transport the
+transport could be freed when the timer is still running.
+
+So fix it by holding/putting transport instead for proto_unreach_timer
+in transport, just like other timers in transport.
+
+v1->v2:
+  - Also use sctp_transport_put() for the "out_unlock:" path in
+    sctp_generate_proto_unreach_event(), as Marcelo noticed.
+
+Fixes: 50b5d6ad6382 ("sctp: Fix a race between ICMP protocol unreachable and connect()")
+Reported-by: Hangbin Liu <liuhangbin@gmail.com>
+Signed-off-by: Xin Long <lucien.xin@gmail.com>
+Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
+Link: https://lore.kernel.org/r/102788809b554958b13b95d33440f5448113b8d6.1605331373.git.lucien.xin@gmail.com
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ net/sctp/input.c         |    4 ++--
+ net/sctp/sm_sideeffect.c |    4 ++--
+ net/sctp/transport.c     |    2 +-
+ 3 files changed, 5 insertions(+), 5 deletions(-)
+
+--- a/net/sctp/input.c
++++ b/net/sctp/input.c
+@@ -461,7 +461,7 @@ void sctp_icmp_proto_unreachable(struct
+               else {
+                       if (!mod_timer(&t->proto_unreach_timer,
+                                               jiffies + (HZ/20)))
+-                              sctp_association_hold(asoc);
++                              sctp_transport_hold(t);
+               }
+       } else {
+               struct net *net = sock_net(sk);
+@@ -470,7 +470,7 @@ void sctp_icmp_proto_unreachable(struct
+                        "encountered!\n", __func__);
+               if (del_timer(&t->proto_unreach_timer))
+-                      sctp_association_put(asoc);
++                      sctp_transport_put(t);
+               sctp_do_sm(net, SCTP_EVENT_T_OTHER,
+                          SCTP_ST_OTHER(SCTP_EVENT_ICMP_PROTO_UNREACH),
+--- a/net/sctp/sm_sideeffect.c
++++ b/net/sctp/sm_sideeffect.c
+@@ -434,7 +434,7 @@ void sctp_generate_proto_unreach_event(s
+               /* Try again later.  */
+               if (!mod_timer(&transport->proto_unreach_timer,
+                               jiffies + (HZ/20)))
+-                      sctp_association_hold(asoc);
++                      sctp_transport_hold(transport);
+               goto out_unlock;
+       }
+@@ -450,7 +450,7 @@ void sctp_generate_proto_unreach_event(s
+ out_unlock:
+       bh_unlock_sock(sk);
+-      sctp_association_put(asoc);
++      sctp_transport_put(transport);
+ }
+  /* Handle the timeout of the RE-CONFIG timer. */
+--- a/net/sctp/transport.c
++++ b/net/sctp/transport.c
+@@ -148,7 +148,7 @@ void sctp_transport_free(struct sctp_tra
+       /* Delete the ICMP proto unreachable timer if it's active. */
+       if (del_timer(&transport->proto_unreach_timer))
+-              sctp_association_put(transport->asoc);
++              sctp_transport_put(transport);
+       sctp_transport_put(transport);
+ }
diff --git a/queue-4.19/series b/queue-4.19/series
new file mode 100644 (file)
index 0000000..6bb33be
--- /dev/null
@@ -0,0 +1,26 @@
+ah6-fix-error-return-code-in-ah6_input.patch
+atm-nicstar-unmap-dma-on-send-error.patch
+bnxt_en-read-eeprom-a2h-address-using-page-0.patch
+devlink-add-missing-genlmsg_cancel-in-devlink_nl_sb_port_pool_fill.patch
+inet_diag-fix-error-path-to-cancel-the-meseage-in-inet_req_diag_fill.patch
+lan743x-fix-issue-causing-intermittent-kernel-log-warnings.patch
+lan743x-prevent-entire-kernel-hang-on-open-for-some-platforms.patch
+mlxsw-core-use-variable-timeout-for-emad-retries.patch
+net-b44-fix-error-return-code-in-b44_init_one.patch
+net-bridge-add-missing-counters-to-ndo_get_stats64-callback.patch
+net-dsa-mv88e6xxx-avoid-vtu-corruption-on-6097.patch
+net-have-netpoll-bring-up-dsa-management-interface.patch
+netlabel-fix-our-progress-tracking-in-netlbl_unlabel_staticlist.patch
+netlabel-fix-an-uninitialized-warning-in-netlbl_unlabel_staticlist.patch
+net-mlx4_core-fix-init_hca-fields-offset.patch
+net-qualcomm-rmnet-fix-incorrect-receive-packet-handling-during-cleanup.patch
+net-x25-increase-refcnt-of-struct-x25_neigh-in-x25_rx_call_request.patch
+page_frag-recover-from-memory-pressure.patch
+qed-fix-error-return-code-in-qed_iwarp_ll2_start.patch
+qlcnic-fix-error-return-code-in-qlcnic_83xx_restart_hw.patch
+sctp-change-to-hold-put-transport-for-proto_unreach_timer.patch
+tcp-only-postpone-probe_rtt-if-rtt-is-current-min_rtt-estimate.patch
+net-mlx5-disable-qos-when-min_rates-on-all-vfs-are-zero.patch
+net-usb-qmi_wwan-set-dtr-quirk-for-mr400.patch
+net-ncsi-fix-netlink-registration.patch
+net-ftgmac100-fix-crash-when-removing-driver.patch
diff --git a/queue-4.19/tcp-only-postpone-probe_rtt-if-rtt-is-current-min_rtt-estimate.patch b/queue-4.19/tcp-only-postpone-probe_rtt-if-rtt-is-current-min_rtt-estimate.patch
new file mode 100644 (file)
index 0000000..7ec1a5f
--- /dev/null
@@ -0,0 +1,46 @@
+From foo@baz Sun Nov 22 12:00:04 PM CET 2020
+From: Ryan Sharpelletti <sharpelletti@google.com>
+Date: Mon, 16 Nov 2020 17:44:13 +0000
+Subject: tcp: only postpone PROBE_RTT if RTT is < current min_rtt estimate
+
+From: Ryan Sharpelletti <sharpelletti@google.com>
+
+[ Upstream commit 1b9e2a8c99a5c021041bfb2d512dc3ed92a94ffd ]
+
+During loss recovery, retransmitted packets are forced to use TCP
+timestamps to calculate the RTT samples, which have a millisecond
+granularity. BBR is designed using a microsecond granularity. As a
+result, multiple RTT samples could be truncated to the same RTT value
+during loss recovery. This is problematic, as BBR will not enter
+PROBE_RTT if the RTT sample is <= the current min_rtt sample, meaning
+that if there are persistent losses, PROBE_RTT will constantly be
+pushed off and potentially never re-entered. This patch makes sure
+that BBR enters PROBE_RTT by checking if RTT sample is < the current
+min_rtt sample, rather than <=.
+
+The Netflix transport/TCP team discovered this bug in the Linux TCP
+BBR code during lab tests.
+
+Fixes: 0f8782ea1497 ("tcp_bbr: add BBR congestion control")
+Signed-off-by: Ryan Sharpelletti <sharpelletti@google.com>
+Signed-off-by: Neal Cardwell <ncardwell@google.com>
+Signed-off-by: Soheil Hassas Yeganeh <soheil@google.com>
+Signed-off-by: Yuchung Cheng <ycheng@google.com>
+Link: https://lore.kernel.org/r/20201116174412.1433277-1-sharpelletti.kdev@gmail.com
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ net/ipv4/tcp_bbr.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/net/ipv4/tcp_bbr.c
++++ b/net/ipv4/tcp_bbr.c
+@@ -917,7 +917,7 @@ static void bbr_update_min_rtt(struct so
+       filter_expired = after(tcp_jiffies32,
+                              bbr->min_rtt_stamp + bbr_min_rtt_win_sec * HZ);
+       if (rs->rtt_us >= 0 &&
+-          (rs->rtt_us <= bbr->min_rtt_us ||
++          (rs->rtt_us < bbr->min_rtt_us ||
+            (filter_expired && !rs->is_ack_delayed))) {
+               bbr->min_rtt_us = rs->rtt_us;
+               bbr->min_rtt_stamp = tcp_jiffies32;