dict-sql: Cleanup - Remove unnecessary code

The values are explicitly added to params. sql_dict_update_query() doesn't
add them again. Since the "diff" parameter is already a long long type,
this avoids unnecessary conversion to string and back.

diff --git a/src/lib-dict/dict-sql.c b/src/lib-dict/dict-sql.c
index ebb2d858633c774e5a77a24983a1e44b0e267ae0..6237751bd47cf535a884028220aced54bf2d2279 100644 (file)
--- a/src/lib-dict/dict-sql.c
+++ b/src/lib-dict/dict-sql.c
@@ -1248,7 +1248,7 @@ static void sql_dict_atomic_inc_real(struct sql_dict_transaction_context *ctx,
        i_assert(map != NULL);
 
        field.map = map;
-       field.value = t_strdup_printf("%lld", diff);
+       field.value = NULL; /* unused */
 
        i_zero(&build);
        build.dict = dict;
@@ -1434,10 +1434,9 @@ static void sql_dict_atomic_inc(struct dict_transaction_context *_ctx,
 
                field = array_append_space(&build.fields);
                field->map = ctx->prev_inc_map;
-               field->value = t_strdup_printf("%lld", ctx->prev_inc_diff);
                field = array_append_space(&build.fields);
                field->map = map;
-               field->value = t_strdup_printf("%lld", diff);
+               /* field->value is unused */
 
                t_array_init(&params, 4);
                param = array_append_space(&params);