]> git.ipfire.org Git - thirdparty/kmod.git/commitdiff
Partially fix parsing of alias with dots
authorLucas De Marchi <lucas.demarchi@profusion.mobi>
Sun, 29 Jan 2012 17:22:09 +0000 (15:22 -0200)
committerLucas De Marchi <lucas.demarchi@profusion.mobi>
Mon, 30 Jan 2012 22:05:33 +0000 (20:05 -0200)
Alias names may contain dots. However since kmod_module_from_alias()
still calls kmod_module_new_from_name(), the bug is not entirely fixed,
and will be completely corrected in a later patch.

libkmod/libkmod-util.c
testsuite/rootfs.tar.xz

index 1bcc1dfb90ff97aae5578c2458afee3baa24cd64..f499578d550c67752b64da1f6354b482ea3caf1b 100644 (file)
@@ -134,8 +134,7 @@ inline int alias_normalize(const char *alias, char buf[PATH_MAX], size_t *len)
                case ']':
                        return -EINVAL;
                case '[':
-                       while (alias[s] != ']' &&
-                                       alias[s] != '.' && alias[s] != '\0') {
+                       while (alias[s] != ']' && alias[s] != '\0') {
                                buf[s] = alias[s];
                                s++;
                        }
@@ -146,7 +145,6 @@ inline int alias_normalize(const char *alias, char buf[PATH_MAX], size_t *len)
                        buf[s] = alias[s];
                        break;
                case '\0':
-               case '.':
                        goto finish;
                default:
                        buf[s] = c;
index b12a4bf0584e7566ee3c1368f98fdae3f55ec2d1..dbba188508313f4552298a98b22f811f7e103884 100644 (file)
Binary files a/testsuite/rootfs.tar.xz and b/testsuite/rootfs.tar.xz differ