lmtp: proxy: Fix bad error handling code path with assert

diff --git a/src/lmtp/lmtp-proxy.c b/src/lmtp/lmtp-proxy.c
index 8c1cb16684ad4209b9c3b293e86f27b3ecb0ff9c..0679dc398c5e7589a241877d7fbbcb115cd8d3e6 100644 (file)
--- a/src/lmtp/lmtp-proxy.c
+++ b/src/lmtp/lmtp-proxy.c
@@ -560,8 +560,8 @@ lmtp_proxy_rcpt_parse_redirect(const struct smtp_reply *proxy_reply,
                               const char **host_r, struct ip_addr *ip_r,
                               in_port_t *port_r, const char **error_r)
 {
-       if (proxy_reply->text_lines == NULL)
-               return -1;
+       i_assert(proxy_reply->text_lines != NULL);
+
        return smtp_proxy_redirect_parse(*proxy_reply->text_lines, destuser_r,
                                         host_r, ip_r, port_r, error_r);
 }