]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
soc: samsung: exynos-pmu: fix device leak on regmap lookup
authorJohan Hovold <johan@kernel.org>
Fri, 21 Nov 2025 12:18:52 +0000 (13:18 +0100)
committerKrzysztof Kozlowski <krzk@kernel.org>
Thu, 27 Nov 2025 15:55:38 +0000 (16:55 +0100)
Make sure to drop the reference taken when looking up the PMU device and
its regmap.

Note that holding a reference to a device does not prevent its regmap
from going away so there is no point in keeping the reference.

Fixes: 0b7c6075022c ("soc: samsung: exynos-pmu: Add regmap support for SoCs that protect PMU regs")
Cc: stable@vger.kernel.org # 6.9
Cc: Peter Griffin <peter.griffin@linaro.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20251121121852.16825-1-johan@kernel.org
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
drivers/soc/samsung/exynos-pmu.c

index df5b1f299a260451b53aca6610ba3d8b4114f7d2..f8fe1a5965ab47b5efa5da702ff1e86c165c3d41 100644 (file)
@@ -346,6 +346,8 @@ struct regmap *exynos_get_pmu_regmap_by_phandle(struct device_node *np,
        if (!dev)
                return ERR_PTR(-EPROBE_DEFER);
 
+       put_device(dev);
+
        return syscon_node_to_regmap(pmu_np);
 }
 EXPORT_SYMBOL_GPL(exynos_get_pmu_regmap_by_phandle);