]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
selftests/bpf: Test changing packet data from kfunc
authorAmery Hung <ameryhung@gmail.com>
Fri, 26 Sep 2025 16:41:42 +0000 (09:41 -0700)
committerMartin KaFai Lau <martin.lau@kernel.org>
Fri, 26 Sep 2025 17:44:51 +0000 (10:44 -0700)
bpf_xdp_pull_data() is the first kfunc that changes packet data. Make
sure the verifier clear all packet pointers after calling packet data
changing kfunc.

Signed-off-by: Amery Hung <ameryhung@gmail.com>
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
Link: https://patch.msgid.link/20250926164142.1850176-1-ameryhung@gmail.com
tools/testing/selftests/bpf/progs/verifier_sock.c

index b4d31f10a9768723be8c46c3408c88a69b86aadd..2b4610b53382d0c98f1e2d22c49be7fd45612b19 100644 (file)
@@ -1096,6 +1096,20 @@ int invalidate_xdp_pkt_pointers_from_global_func(struct xdp_md *x)
        return XDP_PASS;
 }
 
+/* XDP packet changing kfunc calls invalidate packet pointers */
+SEC("xdp")
+__failure __msg("invalid mem access")
+int invalidate_xdp_pkt_pointers(struct xdp_md *x)
+{
+       int *p = (void *)(long)x->data;
+
+       if ((void *)(p + 1) > (void *)(long)x->data_end)
+               return XDP_DROP;
+       bpf_xdp_pull_data(x, 0);
+       *p = 42; /* this is unsafe */
+       return XDP_PASS;
+}
+
 __noinline
 int tail_call(struct __sk_buff *sk)
 {