]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
kselftest: timers: Fix const correctness
authorPiotr Zalewski <pZ010001011111@proton.me>
Mon, 19 Aug 2024 17:58:34 +0000 (17:58 +0000)
committerShuah Khan <skhan@linuxfoundation.org>
Wed, 21 Aug 2024 06:48:48 +0000 (00:48 -0600)
Make timespec pointers, pointers to const in checklist function. As a
consequence, make list parameter in checklist function pointer to const
as well. Const-correctness increases readability.

Improvement was found by running cppcheck tool on the patched file as
follows:
```
cppcheck --enable=all \
tools/testing/selftests/timers/threadtest.c \
--suppress=missingIncludeSystem \
--suppress=unusedFunction
```

Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Piotr Zalewski <pZ010001011111@proton.me>
Acked-by: John Stultz <jstultz@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
tools/testing/selftests/timers/threadtest.c

index 76b38e41d9c7fa34bfc2c80dd4d23cb810654fbc..d5564bbf0e50d1ec966b478698be6c7c4a24397e 100644 (file)
@@ -38,10 +38,10 @@ struct timespec global_list[LISTSIZE];
 int listcount = 0;
 
 
-void checklist(struct timespec *list, int size)
+void checklist(const struct timespec *list, int size)
 {
        int i, j;
-       struct timespec *a, *b;
+       const struct timespec *a, *b;
 
        /* scan the list */
        for (i = 0; i < size-1; i++) {