]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: amphion: adjust the encoder's value range of gop size
authorMing Qian <ming.qian@nxp.com>
Fri, 15 Jul 2022 07:38:00 +0000 (09:38 +0200)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Tue, 30 Aug 2022 13:01:06 +0000 (15:01 +0200)
adjust the value range of gop size from [0, 65535] to [1, 8000].
when the gop size is set to a too large value,
it may affect the encoded picture quality.
so constrain it to a reasonable range.

Fixes: 0401e659c1f92 ("media: amphion: add v4l2 m2m vpu encoder stateful driver")
Signed-off-by: Ming Qian <ming.qian@nxp.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/platform/amphion/venc.c

index 461524dd1e441423f1ffa952a54fbadccc119b96..37212f087fdd983a224378a49da37394fdb17b2c 100644 (file)
@@ -644,7 +644,7 @@ static int venc_ctrl_init(struct vpu_inst *inst)
                          BITRATE_DEFAULT_PEAK);
 
        v4l2_ctrl_new_std(&inst->ctrl_handler, &venc_ctrl_ops,
-                         V4L2_CID_MPEG_VIDEO_GOP_SIZE, 0, (1 << 16) - 1, 1, 30);
+                         V4L2_CID_MPEG_VIDEO_GOP_SIZE, 1, 8000, 1, 30);
 
        v4l2_ctrl_new_std(&inst->ctrl_handler, &venc_ctrl_ops,
                          V4L2_CID_MPEG_VIDEO_B_FRAMES, 0, 4, 1, 0);