]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
Revert "gdb: support zero inode in generate-core-file command"
authorAndrew Burgess <aburgess@redhat.com>
Tue, 6 May 2025 15:55:44 +0000 (16:55 +0100)
committerAndrew Burgess <aburgess@redhat.com>
Tue, 6 May 2025 15:55:44 +0000 (16:55 +0100)
This reverts commit 1e21c846c275fc6e387ca903a129096be2a53d0b.

This change was causing unexpected mappings to be included in the core
files generated by GDB, which was triggering warnings when GDB opened
a core file, like this:

  warning: Can't open file [stack] during file-backed mapping note processing

  warning: Can't open file [vvar] during file-backed mapping note processing

For now I'm reverting the above commit and will come to the list again
when I have a solution that addresses the original issue without also
including the unexpected mappings.

gdb/linux-tdep.c

index a03f9315560bbe437b09e792d38c0f2fc407b894..bbffb3d1c90a925fe350a79482c43d021fb68f0c 100644 (file)
@@ -1712,7 +1712,7 @@ linux_make_mappings_callback (ULONGEST vaddr, ULONGEST size,
     = (struct linux_make_mappings_data *) data;
   gdb_byte buf[sizeof (ULONGEST)];
 
-  if (*filename == '\0')
+  if (*filename == '\0' || inode == 0)
     return 0;
 
   ++map_data->file_count;