Fix non-build-id core files on build-id system

Signed-off-by: Jan Kratochvil <jan.kratochvil@redhat.com>

diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog
index 3c2ffc8149629807aacd786b4dd5cda38d2b7044..deb501407488502cdcb3c4145146bfaca6078138 100644 (file)
--- a/libdwfl/ChangeLog
+++ b/libdwfl/ChangeLog
@@ -1,3 +1,9 @@
+2013-11-21  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+       Fix non-build-id core files on build-id system.
+       * link_map.c (report_r_debug): Remove valid clearing if build-id cannot
+       be read from memory.
+
 2013-11-21  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
        * dwfl_segment_report_module.c (dwfl_segment_report_module): New

diff --git a/libdwfl/link_map.c b/libdwfl/link_map.c
index b30f2e37a0380010a87656e6e381b55d1331eefd..2913d9f73a0ac70aa1676d20bc096e1de4643f76 100644 (file)
--- a/libdwfl/link_map.c
+++ b/libdwfl/link_map.c
@@ -415,9 +415,11 @@ report_r_debug (uint_fast8_t elfclass, uint_fast8_t elfdata,
                                                &buffer, &buffer_available,
                                                build_id_vaddr, build_id_len,
                                                memory_callback_arg))
-                       /* File has valid build-id which cannot be verified
-                          in memory.  */
-                       valid = false;
+                       {
+                         /* File has valid build-id which cannot be read from
+                            memory.  This happens for core files without bit 4
+                            (0x10) set in Linux /proc/PID/coredump_filter.  */
+                       }
                      else
                        {
                          if (memcmp (build_id_bits, buffer, build_id_len) != 0)