__attribute__: add a few missing format attributes

A public function mem_pool_strfmt() takes printf like parameters,
but is not given an attribute as such.  Also a few file-scope static
functions were missing their format attribute.

Add them.

Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/mem-pool.h b/mem-pool.h
index d1c66413ec322104f6199cc2248466c734cee868..321d86a63c7211b451446d051d25309de32bc84b 100644 (file)
--- a/mem-pool.h
+++ b/mem-pool.h
@@ -50,6 +50,7 @@ char *mem_pool_strndup(struct mem_pool *pool, const char *str, size_t len);
 /*
  * Allocate memory from the memory pool and format a string into it.
  */
+__attribute__((format (printf, 2, 3)))
 char *mem_pool_strfmt(struct mem_pool *pool, const char *fmt, ...);
 
 /*

diff --git a/scalar.c b/scalar.c
index 552ac8f0d98e370f1912ec291b3f22c92b4950a8..363341b957d05d76fe17b01b337514f2417deb6c 100644 (file)
--- a/scalar.c
+++ b/scalar.c
@@ -289,6 +289,7 @@ static int unregister_dir(void)
 }
 
 /* printf-style interface, expects `<key>=<value>` argument */
+__attribute__((format (printf, 1, 2)))
 static int set_config(const char *fmt, ...)
 {
        struct strbuf buf = STRBUF_INIT;

diff --git a/wt-status.c b/wt-status.c
index bdfc23e2ae7de8a9521c03420448e412d4262d84..a12406eee004e17471b0f8ca4d036a540c5dac44 100644 (file)
--- a/wt-status.c
+++ b/wt-status.c
@@ -126,6 +126,7 @@ void status_printf(struct wt_status *s, const char *color,
        va_end(ap);
 }
 
+__attribute__((format (printf, 3, 4)))
 static void status_printf_more(struct wt_status *s, const char *color,
                               const char *fmt, ...)
 {