Just like the hard link case, for symlinks we need to remove first

for ARCHIVE_EXTRACT_SAFE_WRITES.

diff --git a/libarchive/archive_write_disk_posix.c b/libarchive/archive_write_disk_posix.c
index 63a5fc71fbb496abff1f5de7b5f207412f565437..cc53a3d318e0196a6694b9a27d5119a672086d19 100644 (file)
--- a/libarchive/archive_write_disk_posix.c
+++ b/libarchive/archive_write_disk_posix.c
@@ -2306,6 +2306,13 @@ create_filesystem_object(struct archive_write_disk *a)
        linkname = archive_entry_symlink(a->entry);
        if (linkname != NULL) {
 #if HAVE_SYMLINK
+               /*
+                * Unlinking and linking here is really not atomic,
+                * but doing it right, would require us to construct
+                * an mktempsymlink() function, and then use rename(2).
+                */
+               if (a->flags & ARCHIVE_EXTRACT_SAFE_WRITES)
+                       unlink(a->name);
                return symlink(linkname, a->name) ? errno : 0;
 #else
                return (EPERM);