]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
selftests/vsock: disable shellcheck SC2317 and SC2119
authorBobby Eshleman <bobbyeshleman@meta.com>
Sat, 8 Nov 2025 16:01:03 +0000 (08:01 -0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 12 Nov 2025 14:19:40 +0000 (06:19 -0800)
Disable shellcheck rules SC2317 and SC2119. These rules are being
triggered due to false positives. For SC2317, many `return
"${KSFT_PASS}"` lines are reported as unreachable, even though they are
executed during normal runs. For SC2119, the fact that
log_guest/log_host accept either stdin or arguments triggers SC2119,
despite being valid.

Signed-off-by: Bobby Eshleman <bobbyeshleman@meta.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Link: https://patch.msgid.link/20251108-vsock-selftests-fixes-and-improvements-v4-12-d5e8d6c87289@meta.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/vsock/vmtest.sh

index 42e155b45602f765281d670996fc100ae80a77b6..c7b270dd77a92d033c2c98f963d186300a97d8c0 100755 (executable)
@@ -7,6 +7,8 @@
 #              * virtme-ng
 #              * busybox-static (used by virtme-ng)
 #              * qemu  (used by virtme-ng)
+#
+# shellcheck disable=SC2317,SC2119
 
 readonly SCRIPT_DIR="$(cd -P -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd -P)"
 readonly KERNEL_CHECKOUT=$(realpath "${SCRIPT_DIR}"/../../../../)